Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

resource/aws_secretsmanager_secret: Support ForceDeleteWithoutRecovery and recreation after immediate deletion #5583

Merged

Commits on Aug 16, 2018

  1. resource/aws_secretsmanager_secret: Support ForceDeleteWithoutRecover…

    …y and recreation after immediate deletion
    
    * When `recovery_window_in_days` is set to 0, use `ForceDeleteWithoutRecovery` with `DeleteSecret`
    * On creation, allow two minutes of retry for `InvalidRequestException: You can’t perform this operation on the secret because it was deleted.`
    
    make testacc TEST=./aws TESTARGS='-run=TestAccAwsSecretsManagerSecret_'
    ==> Checking that code complies with gofmt requirements...
    TF_ACC=1 go test ./aws -v -run=TestAccAwsSecretsManagerSecret_ -timeout 120m
    === RUN   TestAccAwsSecretsManagerSecret_Basic
    --- PASS: TestAccAwsSecretsManagerSecret_Basic (13.95s)
    === RUN   TestAccAwsSecretsManagerSecret_Description
    --- PASS: TestAccAwsSecretsManagerSecret_Description (22.19s)
    === RUN   TestAccAwsSecretsManagerSecret_KmsKeyID
    --- PASS: TestAccAwsSecretsManagerSecret_KmsKeyID (53.60s)
    === RUN   TestAccAwsSecretsManagerSecret_RecoveryWindowInDays_Recreate
    --- PASS: TestAccAwsSecretsManagerSecret_RecoveryWindowInDays_Recreate (51.11s)
    === RUN   TestAccAwsSecretsManagerSecret_RotationLambdaARN
    --- PASS: TestAccAwsSecretsManagerSecret_RotationLambdaARN (51.04s)
    === RUN   TestAccAwsSecretsManagerSecret_RotationRules
    --- PASS: TestAccAwsSecretsManagerSecret_RotationRules (52.66s)
    === RUN   TestAccAwsSecretsManagerSecret_Tags
    --- PASS: TestAccAwsSecretsManagerSecret_Tags (40.70s)
    === RUN   TestAccAwsSecretsManagerSecret_policy
    --- PASS: TestAccAwsSecretsManagerSecret_policy (11.81s)
    PASS
    ok  	github.com/terraform-providers/terraform-provider-aws/aws	297.680s
    bflad committed Aug 16, 2018
    Configuration menu
    Copy the full SHA
    ca0991e View commit details
    Browse the repository at this point in the history