Add example for cloudfront_distribution with s3 webhosting endpoint

[gersilex]

The change adds another example with separate headers.

• The AWS API (and the resource docs) were unclear about this and this commit clarifies it with an example.
• Targets current Terraform version.

Fixes #4757

[ekini]

you probably don't need to forward any cookies here, because s3 doesn't care if they are present. It will improve caching on Cloudfront. Same with most of the headers, except CORS ones.

[gersilex]

The User-Agent custom_header is used as authentication for the S3 Website endpoint, so if you meant this header, we cannot remove it.

I will remove cookies block tomorrow and run the tests again, to see if it introduced any malbehaviour. Your suggestion sounds very reasonable, though, so I don't think we might expect any issues.

[gersilex]

All tests were - of course - successful. Sorry for the delay. Changed the cookie forwarding to none in 754f0a8.

[ekini]

@gersilex I actually meant this: https://www.terraform.io/docs/providers/aws/r/cloudfront_distribution.html#headers

However, I've checked that if you don't specify any value here, then it forwards no headers, which is good :)
So it's all good, sorry for confusion.

[gersilex]

@ekini I added your recommendation and this Pull Request is ready for review again.

[gersilex]

@ekini I added your recommendation and this Pull Request is ready for review again.

[gersilex]

As soon as GitHub is fully up and running again, my latest commit 754f0a8 should appear and is ready to be reviewed again.

@ekini I changed the forwarding of cookies to none as suggested by you. As expected, all tests went fine here, sorry for the delay.

[gersilex]

@austinbutler Your updates look great. Thank you very much.

[zhelding]

Pull request #21306 has significantly refactored the AWS Provider codebase. As a result, most PRs opened prior to the refactor now have merge conflicts that must be resolved before proceeding.

Specifically, PR #21306 relocated the code for all AWS resources and data sources from a single aws directory to a large number of separate directories in internal/service, each corresponding to a particular AWS service. This separation of code has also allowed for us to simplify the names of underlying functions -- while still avoiding namespace collisions.

We recognize that many pull requests have been open for some time without yet being addressed by our maintainers. Therefore, we want to make it clear that resolving these conflicts in no way affects the prioritization of a particular pull request. Once a pull request has been prioritized for review, the necessary changes will be made by a maintainer -- either directly or in collaboration with the pull request author.

For a more complete description of this refactor, including examples of how old filepaths and function names correspond to their new counterparts: please refer to issue #20000.

For a quick guide on how to amend your pull request to resolve the merge conflicts resulting from this refactor and bring it in line with our new code patterns: please refer to our Service Package Refactor Pull Request Guide.