Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support S3 Intelligent-Tiering storage class #6589

Merged
merged 1 commit into from
Dec 2, 2018
Merged

Support S3 Intelligent-Tiering storage class #6589

merged 1 commit into from
Dec 2, 2018

Conversation

ewbankkit
Copy link
Contributor

Fixes #6588.
Acceptance tests:

$ make testacc TEST=./aws/ TESTARGS='-run=TestAccAWSS3BucketObject_storageClass'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws/ -v -parallel 20 -run=TestAccAWSS3BucketObject_storageClass -timeout 120m
=== RUN   TestAccAWSS3BucketObject_storageClass
=== PAUSE TestAccAWSS3BucketObject_storageClass
=== CONT  TestAccAWSS3BucketObject_storageClass
--- PASS: TestAccAWSS3BucketObject_storageClass (75.72s)
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws	94.751s
$ make testacc TEST=./aws/ TESTARGS='-run=^TestAccAWSS3Bucket_Lifecycle$'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws/ -v -parallel 20 -run=^TestAccAWSS3Bucket_Lifecycle -timeout 120m
=== RUN   TestAccAWSS3Bucket_Lifecycle
=== PAUSE TestAccAWSS3Bucket_Lifecycle
=== RUN   TestAccAWSS3Bucket_LifecycleExpireMarkerOnly
=== PAUSE TestAccAWSS3Bucket_LifecycleExpireMarkerOnly
=== CONT  TestAccAWSS3Bucket_Lifecycle
=== CONT  TestAccAWSS3Bucket_LifecycleExpireMarkerOnly
--- PASS: TestAccAWSS3Bucket_LifecycleExpireMarkerOnly (53.31s)
--- PASS: TestAccAWSS3Bucket_Lifecycle (76.01s)
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws	94.304s

@ghost ghost added size/M Managed by automation to categorize the size of a PR. documentation Introduces or discusses updates to documentation. service/s3 Issues and PRs that pertain to the s3 service. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. labels Nov 26, 2018
ewbankkit
ewbankkit commented Nov 26, 2018
View reviewed changes
aws/validators.go
@@ -644,11 +644,12 @@ func validateS3BucketLifecycleTimestamp(v interface{}, k string) (ws []string, e
return
}

func validateS3BucketLifecycleStorageClass() schema.SchemaValidateFunc {
func validateS3BucketLifecycleTransitionStorageClass() schema.SchemaValidateFunc {
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Renamed to more accurately reflect its usage.

ewbankkit
ewbankkit commented Nov 26, 2018
View reviewed changes
aws/resource_aws_s3_bucket_object.go
s3.StorageClassReducedRedundancy,
s3.StorageClassOnezoneIa,
s3.StorageClassStandardIa,
s3.ObjectStorageClassStandard,
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Use the correct enum 😄.

This was referenced Nov 27, 2018
Merged
Merged
@bflad bflad added the enhancement Requests to existing resources that expand the functionality or scope. label Dec 2, 2018
@bflad bflad added this to the v1.51.0 milestone Dec 2, 2018
bflad
bflad approved these changes Dec 2, 2018
View reviewed changes
Copy link
Contributor

@bflad bflad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks @ewbankkit! 🚀

--- PASS: TestAccAWSS3Bucket_LifecycleExpireMarkerOnly (9.36s)
--- PASS: TestAccAWSS3BucketObject_storageClass (10.60s)
--- PASS: TestAccAWSS3Bucket_Lifecycle (12.27s)

@bflad bflad merged commit 4bb23b4 into hashicorp:master Dec 2, 2018
bflad added a commit that referenced this pull request Dec 2, 2018
@bflad
Update CHANGELOG for #6589
6f4f515
@ewbankkit ewbankkit deleted the issue-6588 branch December 2, 2018 12:55
@bflad
Copy link
Contributor

bflad commented Dec 5, 2018

This has been released in version 1.51.0 of the AWS provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

@ghost
Copy link

ghost commented Apr 1, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!

@ghost ghost locked and limited conversation to collaborators Apr 1, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@bflad bflad bflad approved these changes

Assignees
No one assigned
Labels
documentation Introduces or discusses updates to documentation. enhancement Requests to existing resources that expand the functionality or scope. service/s3 Issues and PRs that pertain to the s3 service. size/M Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Milestone
v1.51.0
Development

Successfully merging this pull request may close these issues.

Feature request: Support S3 Intelligent-Tiering storage class
2 participants
@ewbankkit @bflad