Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

r/aws_securityhub: Add aws_securityhub_member resource #6975

Merged
merged 3 commits into from
Mar 17, 2020
Merged

r/aws_securityhub: Add aws_securityhub_member resource #6975

merged 3 commits into from
Mar 17, 2020

Conversation

gazoakley
Copy link
Contributor

Partly addresses #6674

Changes proposed in this pull request:

  • New Resource: aws_securityhub_member

Output from acceptance testing:

$ make testacc TEST=./aws TESTARGS='-run=TestAccAWSSecurityHub'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws -v -parallel 20 -run=TestAccAWSSecurityHub -timeout 120m
=== RUN   TestAccAWSSecurityHub
=== RUN   TestAccAWSSecurityHub/Account
=== RUN   TestAccAWSSecurityHub/Account/basic
=== RUN   TestAccAWSSecurityHub/Member
=== RUN   TestAccAWSSecurityHub/Member/invite
=== RUN   TestAccAWSSecurityHub/Member/basic
=== RUN   TestAccAWSSecurityHub/ProductSubscription
=== RUN   TestAccAWSSecurityHub/ProductSubscription/basic
=== RUN   TestAccAWSSecurityHub/StandardsSubscription
=== RUN   TestAccAWSSecurityHub/StandardsSubscription/basic
--- PASS: TestAccAWSSecurityHub (185.81s)
    --- PASS: TestAccAWSSecurityHub/Account (27.28s)
        --- PASS: TestAccAWSSecurityHub/Account/basic (27.28s)
    --- PASS: TestAccAWSSecurityHub/Member (70.77s)
        --- PASS: TestAccAWSSecurityHub/Member/invite (46.90s)
        --- PASS: TestAccAWSSecurityHub/Member/basic (23.87s)
    --- PASS: TestAccAWSSecurityHub/ProductSubscription (51.00s)
        --- PASS: TestAccAWSSecurityHub/ProductSubscription/basic (51.00s)
    --- PASS: TestAccAWSSecurityHub/StandardsSubscription (36.75s)
        --- PASS: TestAccAWSSecurityHub/StandardsSubscription/basic (36.75s)
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws	185.852s

@ghost ghost added size/XL Managed by automation to categorize the size of a PR. documentation Introduces or discusses updates to documentation. provider Pertains to the provider itself, rather than any interaction with AWS. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. labels Dec 24, 2018
@gazoakley
Copy link
Contributor Author

Actually, I'll probably tweak this to include better error information once aws/aws-sdk-go#2372 is resolved

@bflad bflad added new-resource Introduces a new resource. service/securityhub Issues and PRs that pertain to the securityhub service. labels Jan 16, 2019
@aeschright aeschright requested a review from a team June 25, 2019 21:46
@nozaq nozaq mentioned this pull request Aug 12, 2019
Closed
@reedloden
Copy link
Contributor

Looks like this needs to be rebased. @gazoakley

@scrofungulus
Copy link

This has been open for a while. What will it take to get this merged in?

@scrofungulus
Copy link

@gazoakley ^^

gdavison
gdavison reviewed Nov 14, 2019
View reviewed changes
Copy link
Contributor

@gdavison gdavison left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for submitting this PR so long ago, @gazoakley. Just one comment about the example in the documentation and it needs to be rebased, otherwise LGTM

website/docs/r/securityhub_member.markdown
```hcl
resource "aws_securityhub_account" "example" {}

resource "aws_securityhub_member" "example" {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should this include a depends_on argument?

@gdavison gdavison added the waiting-response Maintainers are waiting on response from community or contributor. label Nov 14, 2019
@gazoakley
Copy link
Contributor Author

@gdavison Rebased and should be up to date now

@ghost ghost removed the waiting-response Maintainers are waiting on response from community or contributor. label Nov 15, 2019
@anuj-modi
Copy link

What is the status on this PR? Really looking forward to this feature along with a corresponding acceptor.

@cteig
Copy link

cteig commented Jan 24, 2020

I'm also waiting for this one. What does it take to get this merged?

@anuj-modi
Copy link

@gdavison What work still needs to be done for this PR to be accepted?

@mhmdio
Copy link

mhmdio commented Feb 5, 2020

@gdavison look like all require work is done, Can this be merged? LGTM.

@frodeb
Copy link

frodeb commented Feb 19, 2020

Patiently waiting for this feature to be merged as well :-)

bflad
bflad approved these changes Mar 17, 2020
View reviewed changes
Copy link
Member

@bflad bflad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, thanks @gazoakley 🚀

Output from acceptance testing:

--- PASS: TestAccAWSSecurityHub (89.60s)
    --- PASS: TestAccAWSSecurityHub/Account (12.62s)
        --- PASS: TestAccAWSSecurityHub/Account/basic (12.62s)
    --- PASS: TestAccAWSSecurityHub/Member (19.02s)
        --- PASS: TestAccAWSSecurityHub/Member/basic (9.65s)
        --- PASS: TestAccAWSSecurityHub/Member/invite (9.37s)
    --- PASS: TestAccAWSSecurityHub/ProductSubscription (20.25s)
        --- PASS: TestAccAWSSecurityHub/ProductSubscription/basic (20.25s)
    --- PASS: TestAccAWSSecurityHub/StandardsSubscription (37.71s)
        --- PASS: TestAccAWSSecurityHub/StandardsSubscription/basic (37.71s)

@bflad bflad added this to the v2.54.0 milestone Mar 17, 2020
@bflad bflad merged commit 6ed264f into hashicorp:master Mar 17, 2020
bflad added a commit that referenced this pull request Mar 17, 2020
@bflad
Update CHANGELOG for #6975
14d7420
@ghost
Copy link

ghost commented Mar 19, 2020

This has been released in version 2.54.0 of the Terraform AWS provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template for triage. Thanks!

@ghost
Copy link

ghost commented Apr 17, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!

@ghost ghost locked and limited conversation to collaborators Apr 17, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@gdavison gdavison gdavison left review comments

@bflad bflad bflad approved these changes

Assignees
No one assigned
Labels
documentation Introduces or discusses updates to documentation. new-resource Introduces a new resource. provider Pertains to the provider itself, rather than any interaction with AWS. service/securityhub Issues and PRs that pertain to the securityhub service. size/XL Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Milestone
v2.54.0
Development

Successfully merging this pull request may close these issues.

None yet
9 participants
@gazoakley @reedloden @scrofungulus @anuj-modi @cteig @mhmdio @frodeb @bflad @gdavison