Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

resource/aws_acm_certificate: Prevent crash with empty SubjectAlternativeNames #7127

Merged
merged 1 commit into from
Jan 14, 2019

Conversation

bflad
Copy link
Contributor

@bflad bflad commented Jan 12, 2019

Fixes #7103

Its possible to import certificates into ACM with an IP address CommonName, which leaves SubjectAlternativeNames empty in the API response. The resource previously assumed there was always one element in the list (the domain name).

Previous output from acceptance testing:

=== CONT  TestAccAWSAcmCertificate_imported_IpAddress
panic: runtime error: makeslice: cap out of range

goroutine 437 [running]:
github.com/terraform-providers/terraform-provider-aws/aws.cleanUpSubjectAlternativeNames(0xc000962fc0, 0x48ed811, 0x3, 0x3dbe1a0)
	/Users/bflad/go/src/github.com/terraform-providers/terraform-provider-aws/aws/resource_aws_acm_certificate.go:280 +0x71
github.com/terraform-providers/terraform-provider-aws/aws.resourceAwsAcmCertificateRead.func1(0xc000872cd0)
	/Users/bflad/go/src/github.com/terraform-providers/terraform-provider-aws/aws/resource_aws_acm_certificate.go:213 +0x284

Output from acceptance testing:

--- PASS: TestAccAWSAcmCertificate_imported_IpAddress (14.29s)
--- PASS: TestAccAWSAcmCertificate_imported_DomainName (22.19s)

…tiveNames

Reference: #7103

Its possible to import certificates into ACM with an IP address CommonName, which leaves SubjectAlternativeNames empty in the API response. The resource previously assumed there was always one element in the list (the domain name).

Previous output from acceptance testing:

```
=== CONT  TestAccAWSAcmCertificate_imported_IpAddress
panic: runtime error: makeslice: cap out of range

goroutine 437 [running]:
github.com/terraform-providers/terraform-provider-aws/aws.cleanUpSubjectAlternativeNames(0xc000962fc0, 0x48ed811, 0x3, 0x3dbe1a0)
	/Users/bflad/go/src/github.com/terraform-providers/terraform-provider-aws/aws/resource_aws_acm_certificate.go:280 +0x71
github.com/terraform-providers/terraform-provider-aws/aws.resourceAwsAcmCertificateRead.func1(0xc000872cd0)
	/Users/bflad/go/src/github.com/terraform-providers/terraform-provider-aws/aws/resource_aws_acm_certificate.go:213 +0x284
```

Output from acceptance testing:

```
--- PASS: TestAccAWSAcmCertificate_imported_IpAddress (14.29s)
--- PASS: TestAccAWSAcmCertificate_imported_DomainName (22.19s)
```
@bflad bflad added bug Addresses a defect in current functionality. crash Results from or addresses a Terraform crash or kernel panic. service/acm Issues and PRs that pertain to the acm service. labels Jan 12, 2019
@bflad bflad requested a review from a team January 12, 2019 16:38
@ghost ghost added size/M Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. labels Jan 12, 2019
Copy link
Member

@mbfrahry mbfrahry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@bflad bflad added this to the v1.56.0 milestone Jan 14, 2019
@bflad bflad merged commit 644235b into master Jan 14, 2019
@bflad bflad deleted the b-aws_acm_certificate-import-ip-address-cert branch January 14, 2019 13:48
bflad added a commit that referenced this pull request Jan 14, 2019
@bflad
Copy link
Contributor Author

bflad commented Jan 16, 2019

This has been released in version 1.56.0 of the AWS provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

@ghost
Copy link

ghost commented Apr 1, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!

@ghost ghost locked and limited conversation to collaborators Apr 1, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Addresses a defect in current functionality. crash Results from or addresses a Terraform crash or kernel panic. service/acm Issues and PRs that pertain to the acm service. size/M Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fatal Crash on import of aws_acm_certificate.selfsignedcert resource (panic)
2 participants