Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Additional (computed) Direct Connect attributes #7131

Merged
merged 1 commit into from
Mar 15, 2019

Conversation

ewbankkit
Copy link
Contributor

Fixes #6493.

Additional Computed attributes:

  • aws_device for
    • aws_dx_bgp_peer resource
    • aws_dx_connection resource
    • aws_hosted_private_virtual_interface resource
    • aws_hosted_public_virtual_interface resource
    • aws_private_virtual_interface resource
    • aws_public_virtual_interface resource
  • bgp_peer_id for
    • aws_dx_bgp_peer resource
  • has_logical_redundancy for
    • aws_dx_connection resource
    • aws_dx_lag resource
  • jumbo_frame_capable for

@ghost ghost added size/S Managed by automation to categorize the size of a PR. documentation Introduces or discusses updates to documentation. service/directconnect Issues and PRs that pertain to the directconnect service. labels Jan 13, 2019
@bflad bflad added the enhancement Requests to existing resources that expand the functionality or scope. label Mar 15, 2019
@bflad bflad added this to the v2.2.0 milestone Mar 15, 2019
Copy link
Contributor

@bflad bflad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks @ewbankkit 🚀 Will add missing schema on merge.

@@ -189,6 +189,7 @@ func resourceAwsDxPrivateVirtualInterfaceRead(d *schema.ResourceData, meta inter
d.Set("dx_gateway_id", vif.DirectConnectGatewayId)
d.Set("mtu", vif.Mtu)
d.Set("jumbo_frame_capable", vif.JumboFrameCapable)
d.Set("aws_device", vif.AwsDeviceV2)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Missing schema definition

@bflad bflad merged commit 64654c4 into hashicorp:master Mar 15, 2019
bflad added a commit that referenced this pull request Mar 15, 2019
@bflad
Copy link
Contributor

bflad commented Mar 15, 2019

This has been released in version 2.2.0 of the Terraform AWS provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

@ewbankkit ewbankkit deleted the issue-6493 branch March 15, 2019 11:13
@ghost
Copy link

ghost commented Mar 31, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!

@ghost ghost locked and limited conversation to collaborators Mar 31, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
documentation Introduces or discusses updates to documentation. enhancement Requests to existing resources that expand the functionality or scope. service/directconnect Issues and PRs that pertain to the directconnect service. size/S Managed by automation to categorize the size of a PR.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Feature request: DirectConnect virtual interface logical redundancy
2 participants