Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

resource/aws_ram_principal_association: Organizations principals should be ARNs not IDs #8048

Merged
merged 1 commit into from
Mar 26, 2019
Merged

resource/aws_ram_principal_association: Organizations principals should be ARNs not IDs #8048

merged 1 commit into from
Mar 26, 2019

Conversation

bflad
Copy link
Contributor

@bflad bflad commented Mar 22, 2019

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
  • Please do not leave "+1" comments, they generate extra noise for pull request followers and do not help prioritize the request

Fixes #7632

Output from acceptance testing:

--- PASS: TestAccAwsRamPrincipalAssociation_disappears (14.65s)
--- PASS: TestAccAwsRamPrincipalAssociation_basic (16.24s)

@bflad
resource/aws_ram_principal_association: Organizations principals shou…
b14d49d 
…ld be ARNs not IDs

Reference: #7632

Output from acceptance testing:

```
--- PASS: TestAccAwsRamPrincipalAssociation_disappears (14.65s)
--- PASS: TestAccAwsRamPrincipalAssociation_basic (16.24s)
```
@bflad bflad added enhancement Requests to existing resources that expand the functionality or scope. service/ram Issues and PRs that pertain to the ram service. labels Mar 22, 2019
@bflad bflad requested a review from a team March 22, 2019 12:33
@ghost ghost added size/XS Managed by automation to categorize the size of a PR. documentation Introduces or discusses updates to documentation. labels Mar 22, 2019
@bflad bflad mentioned this pull request Mar 22, 2019
Closed
nywilken
nywilken approved these changes Mar 26, 2019
View reviewed changes
Copy link
Member

@nywilken nywilken left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@bflad bflad added this to the v2.4.0 milestone Mar 26, 2019
@bflad bflad merged commit 72576c2 into master Mar 26, 2019
@bflad bflad deleted the f-aws_ram_principal_association-principal-validation branch March 26, 2019 17:08
bflad added a commit that referenced this pull request Mar 26, 2019
@bflad
Update CHANGELOG for #8048
3a5403b
@bflad
Copy link
Contributor Author

bflad commented Mar 29, 2019

This has been released in version 2.4.0 of the Terraform AWS provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

@ghost
Copy link

ghost commented Mar 30, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!

@ghost ghost locked and limited conversation to collaborators Mar 30, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@nywilken nywilken nywilken approved these changes

Assignees
No one assigned
Labels
documentation Introduces or discusses updates to documentation. enhancement Requests to existing resources that expand the functionality or scope. service/ram Issues and PRs that pertain to the ram service. size/XS Managed by automation to categorize the size of a PR.
Projects
None yet
Milestone
v2.4.0
Development

Successfully merging this pull request may close these issues.

error associating RAM Resource Share
2 participants
@bflad @nywilken