Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

resource/aws_cloudfront_distribution: Add wait_for_deployment argument #8116

Merged
merged 3 commits into from
Apr 1, 2019
Merged

resource/aws_cloudfront_distribution: Add wait_for_deployment argument #8116

merged 3 commits into from
Apr 1, 2019

Commits on Mar 28, 2019

  1. resource/aws_cloudfront_distribution: Add wait_for_deployment argument 

    Reference: #8073

Since we are adding a virtual attribute with a `Default`, we must use include a schema state migration to prevent the `"" => "true"` difference on upgrade.

Output from acceptance testing:

```
--- PASS: TestAccAWSCloudFrontDistribution_Origin_EmptyDomainName (1.25s)
--- PASS: TestAccAWSCloudFrontDistribution_Origin_EmptyOriginID (1.30s)
--- PASS: TestAccAWSCloudFrontDistribution_disappears (571.01s)
--- PASS: TestAccAWSCloudFrontDistribution_noOptionalItemsConfig (1263.05s)
--- PASS: TestAccAWSCloudFrontDistribution_noCustomErrorResponseConfig (1265.06s)
--- PASS: TestAccAWSCloudFrontDistribution_HTTP11Config (1265.34s)
--- PASS: TestAccAWSCloudFrontDistribution_customOrigin (1267.09s)
--- PASS: TestAccAWSCloudFrontDistribution_OriginGroups (1267.68s)
--- PASS: TestAccAWSCloudFrontDistribution_RetainOnDelete (1268.95s)
--- PASS: TestAccAWSCloudFrontDistribution_orderedCacheBehavior (1271.12s)
--- PASS: TestAccAWSCloudFrontDistribution_S3Origin (1271.30s)
--- PASS: TestAccAWSCloudFrontDistribution_multiOrigin (1271.50s)
--- PASS: TestAccAWSCloudFrontDistribution_IsIPV6EnabledConfig (1272.82s)
--- PASS: TestAccAWSCloudFrontDistribution_ViewerCertificate_AcmCertificateArn (1275.16s)
--- PASS: TestAccAWSCloudFrontDistribution_WaitForDeployment (1275.81s)
--- PASS: TestAccAWSCloudFrontDistribution_ViewerCertificate_AcmCertificateArn_ConflictsWithCloudFrontDefaultCertificate (1372.94s)
--- PASS: TestAccAWSCloudFrontDistribution_S3OriginWithTags (1782.07s)
--- PASS: TestAccAWSCloudFrontDistribution_Enabled (1782.38s)
```
    @bflad
    bflad committed Mar 28, 2019
    Configuration menu
    Copy the full SHA
    c0e7f5f View commit details
    Browse the repository at this point in the history

  2. docs/resource/aws_cloudfront_distribution: Add wait_for_deployment ar… 

    …gument documentation
    @bflad
    bflad committed Mar 28, 2019
    Configuration menu
    Copy the full SHA
    0a0ac22 View commit details
    Browse the repository at this point in the history

  3. resource/aws_cloudfront_distribution: Clarify state migration variabl… 

    …e naming and improve wait_for_deployment documentation

Reference: #8116
    @bflad
    bflad committed Mar 28, 2019
    Configuration menu
    Copy the full SHA
    6bec133 View commit details
    Browse the repository at this point in the history