Add Import Support for aws_cloudwatch_log_subscription_filter

[teraken0509]

Community Note

• Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
• Please do not leave "+1" comments, they generate extra noise for pull request followers and do not help prioritize the request

Fixes #8147

Changes proposed in this pull request:

• add import support for aws_cloudwatch_log_subscription_filter resource

Output from acceptance testing:

$ make testacc TEST=./aws TESTARGS='-run=TestAccAWSCloudwatchLogSubscriptionFilter_'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws -v -parallel 20 -run=TestAccAWSCloudwatchLogSubscriptionFilter_ -timeout 120m
=== RUN   TestAccAWSCloudwatchLogSubscriptionFilter_basic
=== PAUSE TestAccAWSCloudwatchLogSubscriptionFilter_basic
=== RUN   TestAccAWSCloudwatchLogSubscriptionFilter_disappears
=== PAUSE TestAccAWSCloudwatchLogSubscriptionFilter_disappears
=== RUN   TestAccAWSCloudwatchLogSubscriptionFilter_disappears_LogGroup
=== PAUSE TestAccAWSCloudwatchLogSubscriptionFilter_disappears_LogGroup
=== CONT  TestAccAWSCloudwatchLogSubscriptionFilter_basic
=== CONT  TestAccAWSCloudwatchLogSubscriptionFilter_disappears
=== CONT  TestAccAWSCloudwatchLogSubscriptionFilter_disappears_LogGroup
--- PASS: TestAccAWSCloudwatchLogSubscriptionFilter_disappears (48.92s)
--- PASS: TestAccAWSCloudwatchLogSubscriptionFilter_disappears_LogGroup (49.19s)
--- PASS: TestAccAWSCloudwatchLogSubscriptionFilter_basic (53.27s)
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws	53.347s

[bflad]

Looks good, @kterada0509, thanks! 🚀 I'll fix up the little error message thing on merge.

Output from acceptance testing:

--- PASS: TestAccAWSCloudwatchLogSubscriptionFilter_basic (23.84s)
--- PASS: TestAccAWSCloudwatchLogSubscriptionFilter_disappears (24.66s)
--- PASS: TestAccAWSCloudwatchLogSubscriptionFilter_disappears_LogGroup (24.77s)

[bflad]

Nit: We really need to document and start standardizing on a single import separator. 😅 Preferably this would be something more like a , comma to not interfere with the shell | pipe operator, but not going to stop this pull request over this as it is something we should address holistically across the provider. (Maybe commas won't be right either.)

[bflad]

This error should use | not / 😄

Suggested change

	return nil, fmt.Errorf("unexpected format of ID (%q), expected <log-group-name>/<filter-name-prefix>", d.Id())
	return nil, fmt.Errorf("unexpected format of ID (%q), expected <log-group-name>|<filter-name>", d.Id())

[bflad]

This has been released in version 2.5.0 of the Terraform AWS provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

[ghost]

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!