resource/aws_route53_record: Remove deprecation from allow_overwrite argument
#8274
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…` argument Reference: #7846 Route53 Record `UPSERT` on creation does have some minor valid use cases. We will keep this argument for now while discouraging its usage in the documentation. Output from acceptance testing: ``` --- PASS: TestAccAWSRoute53Record_allowOverwrite (149.81s) ```
bflad
added
service/route53
ghost
added
documentation
nywilken
reviewed
Apr 10, 2019
| Optional: true, | ||
| Computed: true, | ||
| Deprecated: "The next major version of the Terraform AWS Provider will require importing existing records", | ||
| Type: schema.TypeBool, |
There was a problem hiding this comment.
Where there any tests removed when the attribute was deprecated that should be restored?
There was a problem hiding this comment.
Nope we don't tend to remove testing on deprecations as the functionality is still expected to work as it did previously. 👍 Here's the deprecation pull request for verification: #7734
|
I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks! |
ghost
locked and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Community Note
Closes #7846
Route53 Record
UPSERTon creation does have some minor valid use cases. We will keep this argument for now while discouraging its usage in the documentation.Output from acceptance testing: