New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support EXTERNAL deployment controller for ECS #8652
Conversation
Any update on this PR?? |
It looks like this is a duplicate of #8134. |
Right, would be nice if one of them gets merged tho |
Anyone can merge this PR or #8134 ? |
@bflad Looks like this PR is got burried, and forgotten |
Fixed merge conflict, can someone please merge this? PR is a year old. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you so much, @kumarappan-arumugam 🚀 Pulling this in a 3-way merge with #8134 to give the earlier contributor credit and with very minor documentation/testing tweaks.
Output from acceptance testing:
--- PASS: TestAccAWSEcsService_basicImport (81.33s)
--- PASS: TestAccAWSEcsService_disappears (77.65s)
--- PASS: TestAccAWSEcsService_healthCheckGracePeriodSeconds (345.88s)
--- PASS: TestAccAWSEcsService_ManagedTags (80.69s)
--- PASS: TestAccAWSEcsService_PropagateTags (216.71s)
--- PASS: TestAccAWSEcsService_Tags (108.07s)
--- PASS: TestAccAWSEcsService_withAlb (289.93s)
--- PASS: TestAccAWSEcsService_withARN (92.20s)
--- PASS: TestAccAWSEcsService_withCapacityProviderStrategy (195.70s)
--- PASS: TestAccAWSEcsService_withDaemonSchedulingStrategy (48.74s)
--- PASS: TestAccAWSEcsService_withDaemonSchedulingStrategySetDeploymentMinimum (60.43s)
--- PASS: TestAccAWSEcsService_withDeploymentController_Type_CodeDeploy (298.78s)
--- PASS: TestAccAWSEcsService_withDeploymentController_Type_External (49.28s)
--- PASS: TestAccAWSEcsService_withDeploymentMinimumZeroMaximumOneHundred (77.40s)
--- PASS: TestAccAWSEcsService_withDeploymentValues (76.81s)
--- PASS: TestAccAWSEcsService_withEcsClusterName (90.55s)
--- PASS: TestAccAWSEcsService_withFamilyAndRevision (91.38s)
--- PASS: TestAccAWSEcsService_withForceNewDeployment (91.77s)
--- PASS: TestAccAWSEcsService_withIamRole (142.00s)
--- PASS: TestAccAWSEcsService_withLaunchTypeEC2AndNetworkConfiguration (114.04s)
--- PASS: TestAccAWSEcsService_withLaunchTypeFargate (167.26s)
--- PASS: TestAccAWSEcsService_withLaunchTypeFargateAndPlatformVersion (166.53s)
--- PASS: TestAccAWSEcsService_withLbChanges (237.65s)
--- PASS: TestAccAWSEcsService_withMultipleCapacityProviderStrategies (145.14s)
--- PASS: TestAccAWSEcsService_withMultipleTargetGroups (301.04s)
--- PASS: TestAccAWSEcsService_withPlacementConstraints (71.84s)
--- PASS: TestAccAWSEcsService_withPlacementConstraints_emptyExpression (76.82s)
--- PASS: TestAccAWSEcsService_withPlacementStrategy (125.39s)
--- PASS: TestAccAWSEcsService_withRenamedCluster (154.21s)
--- PASS: TestAccAWSEcsService_withReplicaSchedulingStrategy (59.51s)
--- PASS: TestAccAWSEcsService_withServiceRegistries (176.92s)
--- PASS: TestAccAWSEcsService_withServiceRegistries_container (176.53s)
--- PASS: TestAccAWSEcsService_withUnnormalizedPlacementStrategy (77.25s)
This has been released in version 2.68.0 of the Terraform AWS provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template for triage. Thanks! |
I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks! |
Community Note
Fixes #8133
Release note for CHANGELOG:
Changes:
EXTERNAL
deployment_controllerOutput from acceptance testing: