Commits on Jun 10, 2019

1. resource/aws_iam_service_linked_role: Automatically suppress Applicat… …

   …ion Autoscaling custom_suffix differences
   
   Reference: #4439
   
   Previously:
   
   ```
   --- FAIL: TestAccAWSIAMServiceLinkedRole_CustomSuffix_DiffSuppressFunc (17.09s)
       testing.go:568: Step 0 error: After applying this step, the plan was not empty:
   
           DIFF:
   
           DESTROY/CREATE: aws_iam_service_linked_role.test
             arn:              "arn:aws:iam::--OMITTED--:role/aws-service-role/custom-resource.application-autoscaling.amazonaws.com/AWSServiceRoleForApplicationAutoScaling_CustomResource" => "<computed>"
             aws_service_name: "custom-resource.application-autoscaling.amazonaws.com" => "custom-resource.application-autoscaling.amazonaws.com"
             create_date:      "" => "<computed>"
             custom_suffix:    "CustomResource" => "" (forces new resource)
             description:      "" => ""
             id:               "arn:aws:iam::--OMITTED--:role/aws-service-role/custom-resource.application-autoscaling.amazonaws.com/AWSServiceRoleForApplicationAutoScaling_CustomResource" => "<computed>"
             name:             "AWSServiceRoleForApplicationAutoScaling_CustomResource" => "<computed>"
             path:             "/aws-service-role/custom-resource.application-autoscaling.amazonaws.com/" => "<computed>"
             unique_id:        "AROASXIXB4ZJ7W7CHKUUX" => "<computed>"
   ```
   
   Output from acceptance testing in AWS Commercial:
   
   ```
   --- PASS: TestAccAWSIAMServiceLinkedRole_basic (19.36s)
   --- PASS: TestAccAWSIAMServiceLinkedRole_CustomSuffix_DiffSuppressFunc (19.78s)
   --- PASS: TestAccAWSIAMServiceLinkedRole_CustomSuffix (19.80s)
   --- PASS: TestAccAWSIAMServiceLinkedRole_Description (22.87s)
   ```
   
   Output from acceptance testing in AWS GovCloud (US) (now passing with usage of `testAccCheckResourceAttrGlobalARN`):
   
   ```
   --- PASS: TestAccAWSIAMServiceLinkedRole_CustomSuffix_DiffSuppressFunc (25.54s)
   --- PASS: TestAccAWSIAMServiceLinkedRole_CustomSuffix (25.58s)
   --- PASS: TestAccAWSIAMServiceLinkedRole_basic (26.78s)
   --- PASS: TestAccAWSIAMServiceLinkedRole_Description (34.22s)
   ```

   

   bflad committed Jun 10, 2019
   Configuration menu

   • View commit details
   • Copy full SHA for 79dfeb3
   • Browse repository at this point

   Copy the full SHA

   79dfeb3 View commit details

   Browse the repository at this point in the history