Final retries for elasticache

[ryndaniels]

Community Note

• Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
• Please do not leave "+1" comments, they generate extra noise for pull request followers and do not help prioritize the request

References #7873

Release note for CHANGELOG:

BUG FIXES:
* resource/aws_elasticache_parameter_group - Final retry deleting parameter group
* resource/aws_elasticache_replication_group - Final retry deleting replication group
* resource/aws_elasticache_subnet_group - Final retry deleting subnet group

Output from acceptance testing:

$ make testacc TESTARGS="-run=TestAccDataSourceAwsElasticacheReplicationGroup"  ==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./... -v -parallel 20 -run=TestAccDataSourceAwsElasticacheReplicationGroup -timeout 120m
?       github.com/terraform-providers/terraform-provider-aws   [no test files]



=== RUN   TestAccDataSourceAwsElasticacheReplicationGroup_basic
=== PAUSE TestAccDataSourceAwsElasticacheReplicationGroup_basic
=== RUN   TestAccDataSourceAwsElasticacheReplicationGroup_ClusterMode
=== PAUSE TestAccDataSourceAwsElasticacheReplicationGroup_ClusterMode
=== CONT  TestAccDataSourceAwsElasticacheReplicationGroup_basic
=== CONT  TestAccDataSourceAwsElasticacheReplicationGroup_ClusterMode
--- PASS: TestAccDataSourceAwsElasticacheReplicationGroup_basic (1658.23s)
--- PASS: TestAccDataSourceAwsElasticacheReplicationGroup_ClusterMode (2433.72s)
PASS
ok      github.com/terraform-providers/terraform-provider-aws/aws       2435.736s


make testacc TESTARGS="-run=TestAccAWSElasticacheParameterGroup"            
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./... -v -parallel 20 -run=TestAccAWSElasticacheParameterGroup -timeout 120m
?       github.com/terraform-providers/terraform-provider-aws   [no test files]
=== RUN   TestAccAWSElasticacheParameterGroup_basic
=== PAUSE TestAccAWSElasticacheParameterGroup_basic
=== RUN   TestAccAWSElasticacheParameterGroup_addParameter
=== PAUSE TestAccAWSElasticacheParameterGroup_addParameter
=== RUN   TestAccAWSElasticacheParameterGroup_removeAllParameters
=== PAUSE TestAccAWSElasticacheParameterGroup_removeAllParameters
=== RUN   TestAccAWSElasticacheParameterGroup_removeReservedMemoryParameter
=== PAUSE TestAccAWSElasticacheParameterGroup_removeReservedMemoryParameter
=== RUN   TestAccAWSElasticacheParameterGroup_switchReservedMemoryParameter
=== PAUSE TestAccAWSElasticacheParameterGroup_switchReservedMemoryParameter
=== RUN   TestAccAWSElasticacheParameterGroup_updateReservedMemoryParameter
=== PAUSE TestAccAWSElasticacheParameterGroup_updateReservedMemoryParameter
=== RUN   TestAccAWSElasticacheParameterGroup_UppercaseName
=== PAUSE TestAccAWSElasticacheParameterGroup_UppercaseName
=== RUN   TestAccAWSElasticacheParameterGroup_Description
=== PAUSE TestAccAWSElasticacheParameterGroup_Description
=== CONT  TestAccAWSElasticacheParameterGroup_basic
=== CONT  TestAccAWSElasticacheParameterGroup_UppercaseName
=== CONT  TestAccAWSElasticacheParameterGroup_Description
=== CONT  TestAccAWSElasticacheParameterGroup_switchReservedMemoryParameter
=== CONT  TestAccAWSElasticacheParameterGroup_removeReservedMemoryParameter
=== CONT  TestAccAWSElasticacheParameterGroup_removeAllParameters
=== CONT  TestAccAWSElasticacheParameterGroup_updateReservedMemoryParameter
=== CONT  TestAccAWSElasticacheParameterGroup_addParameter
--- PASS: TestAccAWSElasticacheParameterGroup_Description (27.68s)
--- PASS: TestAccAWSElasticacheParameterGroup_basic (27.78s)
--- PASS: TestAccAWSElasticacheParameterGroup_UppercaseName (29.39s)
--- PASS: TestAccAWSElasticacheParameterGroup_addParameter (47.73s)
--- PASS: TestAccAWSElasticacheParameterGroup_removeReservedMemoryParameter (51.79s)
--- PASS: TestAccAWSElasticacheParameterGroup_removeAllParameters (51.98s)
--- PASS: TestAccAWSElasticacheParameterGroup_updateReservedMemoryParameter (107.63s)
--- PASS: TestAccAWSElasticacheParameterGroup_switchReservedMemoryParameter (108.39s)
PASS
ok      github.com/terraform-providers/terraform-provider-aws/aws       110.184s


make testacc TESTARGS="-run=TestAccAWSElasticacheSubnetGroup"   
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./... -v -parallel 20 -run=TestAccAWSElasticacheSubnetGroup -timeout 120m
?       github.com/terraform-providers/terraform-provider-aws   [no test files]
=== RUN   TestAccAWSElasticacheSubnetGroup_importBasic
=== PAUSE TestAccAWSElasticacheSubnetGroup_importBasic
=== RUN   TestAccAWSElasticacheSubnetGroup_basic
=== PAUSE TestAccAWSElasticacheSubnetGroup_basic
=== RUN   TestAccAWSElasticacheSubnetGroup_update
=== PAUSE TestAccAWSElasticacheSubnetGroup_update
=== CONT  TestAccAWSElasticacheSubnetGroup_importBasic
=== CONT  TestAccAWSElasticacheSubnetGroup_update
=== CONT  TestAccAWSElasticacheSubnetGroup_basic
--- PASS: TestAccAWSElasticacheSubnetGroup_basic (54.73s)
--- PASS: TestAccAWSElasticacheSubnetGroup_importBasic (56.37s)
--- PASS: TestAccAWSElasticacheSubnetGroup_update (90.97s)
PASS
ok      github.com/terraform-providers/terraform-provider-aws/aws       93.517s

[bflad]

Please reach out with any questions. 😄

[bflad]

LGTM! 🚀

Output from acceptance testing (single failure unrelated):

--- PASS: TestAccAWSElasticacheParameterGroup_basic (15.22s)
--- PASS: TestAccAWSElasticacheParameterGroup_UppercaseName (18.17s)
--- PASS: TestAccAWSElasticacheParameterGroup_removeAllParameters (19.17s)
--- PASS: TestAccAWSElasticacheReplicationGroup_clusteringAndCacheNodesCausesError (7.98s)
--- PASS: TestAccAWSElasticacheParameterGroup_Description (26.46s)
--- PASS: TestAccAWSElasticacheParameterGroup_removeReservedMemoryParameter (31.44s)
--- PASS: TestAccAWSElasticacheParameterGroup_addParameter (38.28s)
--- PASS: TestAccAWSElasticacheParameterGroup_switchReservedMemoryParameter (82.63s)
--- PASS: TestResourceAWSElastiCacheReplicationGroupIdValidation (0.00s)
--- PASS: TestResourceAWSElastiCacheReplicationGroupEngineValidation (0.00s)
--- PASS: TestAccAWSElasticacheParameterGroup_updateReservedMemoryParameter (83.04s)
--- PASS: TestAccAWSElasticacheSubnetGroup_basic (9.80s)
--- PASS: TestAccAWSElasticacheSubnetGroup_importBasic (10.88s)
--- PASS: TestAccAWSElasticacheSubnetGroup_update (17.09s)
--- FAIL: TestAccAWSElasticacheReplicationGroup_updateParameterGroup (181.09s)
--- PASS: TestAccAWSElasticacheReplicationGroup_Uppercase (636.51s)
--- PASS: TestAccAWSElasticacheReplicationGroup_redisClusterInVpc2 (811.48s)
--- PASS: TestAccAWSElasticacheReplicationGroup_importBasic (813.01s)
--- PASS: TestAccAWSElasticacheReplicationGroup_basic (874.31s)
--- PASS: TestAccAWSElasticacheReplicationGroup_updateMaintenanceWindow (916.20s)
--- PASS: TestAccAWSElasticacheReplicationGroup_ClusterMode_Basic (932.62s)
--- PASS: TestAccAWSElasticacheReplicationGroup_enableSnapshotting (1056.43s)
--- PASS: TestAccAWSElasticacheReplicationGroup_enableAuthTokenTransitEncryption (1059.04s)
--- PASS: TestAccAWSElasticacheReplicationGroup_enableAtRestEncryption (1305.38s)
--- PASS: TestAccAWSElasticacheReplicationGroup_updateDescription (1363.37s)
--- PASS: TestAccAWSElasticacheReplicationGroup_multiAzInVpc (1431.70s)
--- PASS: TestAccAWSElasticacheReplicationGroup_vpc (1516.03s)
--- PASS: TestAccAWSElasticacheReplicationGroup_updateNodeSize (1686.41s)
--- PASS: TestAccAWSElasticacheReplicationGroup_NumberCacheClusters (1680.68s)
--- PASS: TestAccAWSElasticacheReplicationGroup_NumberCacheClusters_Failover_AutoFailoverDisabled (1753.00s)
--- PASS: TestAccAWSElasticacheReplicationGroup_NumberCacheClusters_Failover_AutoFailoverEnabled (2301.74s)
--- PASS: TestAccAWSElasticacheReplicationGroup_ClusterMode_NumNodeGroups (3279.65s)

[bflad]

This has been released in version 2.16.0 of the Terraform AWS provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

[ghost]

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!