resource/alb_target_group: Add support for UDP protocol #9111
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
added
size/XS
stack72
force-pushed
the
stack72/elbv2-udp
branch
from
737adb2
to
b77b088
Compare
stack72
changed the title
bflad
added
the
enhancement
|
@stack72 fantastic, thanks! Adding this to this week's release. Would you mind adding a quick copy-paste acceptance test for the new UDP support? ❤️ |
|
@bflad sude - give me 5 mins to add and test one! |
stack72
force-pushed
the
stack72/elbv2-udp
branch
from
b77b088
to
86cbcc2
Compare
ghost
added
size/L
|
Sorry, had an issue but I just pushed 2 tests and updated the comments |
stack72
force-pushed
the
stack72/elbv2-udp
branch
3 times, most recently
from
e5e04f1
to
c9a6ad9
Compare
stack72
force-pushed
the
stack72/elbv2-udp
branch
from
c9a6ad9
to
e33c76b
Compare
bflad
approved these changes
Jun 25, 2019
There was a problem hiding this comment.
LGTM with one minor thing. 🚀 Thanks so much, @stack72!
--- PASS: TestAccAWSLBListenerRule_multipleConditionThrowsError (4.61s)
--- FAIL: TestAccAWSLBListener_BackwardsCompatibility (21.17s)
--- PASS: TestAccAWSLBListenerRule_basic (184.74s)
--- PASS: TestAccAWSLBListenerRule_redirect (185.49s)
--- PASS: TestAccAWSLBListener_basic (186.35s)
--- PASS: TestAccAWSLBListener_https (199.16s)
--- PASS: TestAccAWSLBListener_cognito (204.01s)
--- PASS: TestLBTargetGroupCloudwatchSuffixFromARN (0.00s)
--- PASS: TestAccAWSLBListenerRule_Action_Order_Recreates (206.63s)
--- PASS: TestAccAWSLBListener_fixedResponse (213.71s)
--- PASS: TestAccAWSLBListener_redirect (213.88s)
--- PASS: TestAccAWSLBListenerRule_fixedResponse (214.30s)
--- PASS: TestAccAWSLBTargetGroup_basic (10.44s)
--- PASS: TestAccAWSLBListenerRule_cognito (219.60s)
--- PASS: TestAccAWSLBTargetGroup_withoutHealthcheck (7.71s)
--- PASS: TestAccAWSLBTargetGroup_Protocol_Tls (11.06s)
--- PASS: TestAccAWSLBListenerRuleBackwardsCompatibility (229.04s)
--- PASS: TestAccAWSLBTargetGroup_basicUdp (23.62s)
--- PASS: TestAccAWSLBListenerRule_changeListenerRuleArnForcesNew (231.02s)
--- PASS: TestAccAWSLBListenerRule_updateRulePriority (231.19s)
--- PASS: TestAccAWSLBTargetGroupBackwardsCompatibility (10.06s)
--- PASS: TestAccAWSLBTargetGroup_namePrefix (12.14s)
--- PASS: TestAccAWSLBListenerRule_Action_Order (237.65s)
--- PASS: TestAccAWSLBListener_DefaultAction_Order (218.80s)
--- PASS: TestAccAWSLBTargetGroup_networkLB_TargetGroupWithProxy (25.83s)
--- PASS: TestAccAWSLBListener_oidc (236.57s)
--- PASS: TestAccAWSLBTargetGroup_generatedName (17.35s)
--- PASS: TestAccAWSLBTargetGroup_TCP_HTTPHealthCheck (27.89s)
--- PASS: TestAccAWSLBTargetGroup_networkLB_TargetGroup (37.13s)
--- PASS: TestAccAWSLBListenerRule_oidc (252.69s)
--- PASS: TestAccAWSLBListener_basicUdp (254.78s)
--- PASS: TestAccAWSLBTargetGroup_stickinessWithTCPEnabledShouldError (4.26s)
--- PASS: TestAccAWSLBTargetGroup_enableHealthCheck (17.90s)
--- PASS: TestAccAWSLBListener_Protocol_Tls (258.11s)
--- PASS: TestAccAWSLBTargetGroupAttachmentBackwardsCompatibility (76.26s)
--- PASS: TestAccAWSLBTargetGroup_changeProtocolForceNew (32.89s)
--- PASS: TestAccAWSLBTargetGroupAttachment_basic (80.61s)
--- PASS: TestAccAWSLBTargetGroup_defaults_application (26.04s)
--- PASS: TestAccAWSLBTargetGroup_stickinessWithTCPDisabled (20.87s)
--- PASS: TestAccAWSLBTargetGroup_changeVpcForceNew (37.34s)
--- PASS: TestAccAWSLBTargetGroup_changePortForceNew (39.34s)
--- PASS: TestAccAWSLBTargetGroup_changeNameForceNew (40.48s)
--- PASS: TestAccAWSLBTargetGroup_defaults_network (24.73s)
--- PASS: TestAccAWSLBTargetGroup_updateHealthCheck (32.71s)
--- PASS: TestAccAWSLBTargetGroup_tags (36.06s)
--- PASS: TestAccAWSLBTargetGroup_updateSticknessEnabled (42.46s)
--- PASS: TestAccAWSLBTargetGroupAttachment_withoutPort (93.57s)
--- PASS: TestAccAWSLBListenerRule_priority (298.02s)
--- PASS: TestAccAWSLBListener_DefaultAction_Order_Recreates (181.15s)
bflad
added a commit
that referenced
this pull request
Jun 25, 2019
bflad
added a commit
that referenced
this pull request
Jun 25, 2019
…wardsCompatibility configuration update Reference: #9111 (comment)
|
This has been released in version 2.17.0 of the Terraform AWS provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template for triage. Thanks! |
|
I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks! |
ghost
locked and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #9109
All this does is to restrict the validation in the
protocoland updates the documentation. AFACIT, there are no other specific changes required for UDP LoadBalancersIf someone does notice differences, then we can easily add them