Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

resource/aws_backup_selection: IAM retries, test fix, documentation updates to remove wildcard usage #9298

Merged
merged 3 commits into from
Jul 10, 2019
Merged

resource/aws_backup_selection: IAM retries, test fix, documentation updates to remove wildcard usage #9298

merged 3 commits into from
Jul 10, 2019

Commits on Jul 10, 2019

  1. resource/aws_backup_selection: Retry creation for IAM eventual consis… 

    …tency error

Reference: #9297

Output from acceptance testing (failure present on master):

```
--- FAIL: TestAccAwsBackupSelection_withResources (12.00s)
    testing.go:568: Step 0 error: errors during apply:

        Error: error creating Backup Selection: InvalidParameterValueException: Invalid ARN: arn:aws:elasticfilesystem:us-west-2:--OMITTED--:file-system/. Specified resource is not supported
        	status code: 400, request id: 2f845d03-51d3-48df-b853-46c077f85780

          on /var/folders/v0/_d108fkx1pbbg4_sh864_7740000gn/T/tf-test308326165/main.tf line 22:
          (source code not available)

--- PASS: TestAccAwsBackupSelection_disappears (17.20s)
--- PASS: TestAccAwsBackupSelection_basic (18.44s)
--- PASS: TestAccAwsBackupSelection_withTags (18.47s)
--- PASS: TestAccAwsBackupSelection_updateTag (28.73s)
```
    @bflad
    bflad committed Jul 10, 2019
    Configuration menu
    Copy the full SHA
    d799998 View commit details
    Browse the repository at this point in the history

  2. tests/resource/aws_backup_selection: Remove wildcard usage in withRes… 

    …ources acceptance test

The usage of wildcards differs between AWS Regions while ARNs are supported everywhere.

Previously from acceptance testing:

```
--- FAIL: TestAccAwsBackupSelection_withResources (12.00s)
    testing.go:568: Step 0 error: errors during apply:

        Error: error creating Backup Selection: InvalidParameterValueException: Invalid ARN: arn:aws:elasticfilesystem:us-west-2:--OMITTED--:file-system/. Specified resource is not supported
```

Output from acceptance testing:

```
--- PASS: TestAccAwsBackupSelection_withResources (29.35s)
```
    @bflad
    bflad committed Jul 10, 2019
    Configuration menu
    Copy the full SHA
    3cea315 View commit details
    Browse the repository at this point in the history

  3. docs/resource/aws_backup_selection: Expand example documentation to s… 

    …how IAM Role creation and show using resource ARNs

The support for wildcard resource selection does not work in all AWS Regions while ARN support is consistent.

Reference: #9269
    @bflad
    bflad committed Jul 10, 2019
    Configuration menu
    Copy the full SHA
    b97d5e7 View commit details
    Browse the repository at this point in the history