Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for timeout_seconds in SSM MW #9306

Closed
wants to merge 3 commits into from
Closed

Add support for timeout_seconds in SSM MW #9306

wants to merge 3 commits into from

Conversation

kristiandrucker
Copy link
Contributor

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
  • Please do not leave "+1" comments, they generate extra noise for pull request followers and do not help prioritize the request

Fixes #2876

Release note for CHANGELOG:

Added `timeout_seconds` to be used in `aws_ssm_maintenance_window_task` for `RUN_COMMAND` task type
Added functionality to use `TaskInvocationParameters` with Parameters and S3 Log bucket when `RUN_COMMAND` task type is used

Output from acceptance testing:

$ make testacc TESTARGS='-run=TestAccAWSSSMMaintenanceWindowTask'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./... -v -parallel 20 -run=TestAccAWSSSMMaintenanceWindowTask -timeout 120m
?   	github.com/terraform-providers/terraform-provider-aws	[no test files]
=== RUN   TestAccAWSSSMMaintenanceWindowTask_basic
=== PAUSE TestAccAWSSSMMaintenanceWindowTask_basic
=== RUN   TestAccAWSSSMMaintenanceWindowTask_updateForcesNewResource
=== PAUSE TestAccAWSSSMMaintenanceWindowTask_updateForcesNewResource
=== CONT  TestAccAWSSSMMaintenanceWindowTask_basic
=== CONT  TestAccAWSSSMMaintenanceWindowTask_updateForcesNewResource
--- PASS: TestAccAWSSSMMaintenanceWindowTask_basic (97.18s)
--- PASS: TestAccAWSSSMMaintenanceWindowTask_updateForcesNewResource (111.73s)
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws	111.782s

...

@kristiandrucker kristiandrucker requested a review from a team July 10, 2019 20:16
@ghost ghost added size/S Managed by automation to categorize the size of a PR. documentation Introduces or discusses updates to documentation. service/ssm Issues and PRs that pertain to the ssm service. labels Jul 10, 2019
@kristiandrucker kristiandrucker changed the title Add support for timeout_seconds in SSM Add support for timeout_seconds in SSM MW Jul 11, 2019
@bflad
Copy link
Contributor

bflad commented Jul 11, 2019

Hi @kristiandrucker 👋 Thank you for submitting this. Just a FYI, there is currently a large pull request under review for this resource already (#7823), which will be merged ahead of this one and likely introduce breaking changes for this pull request.

@bflad bflad added the enhancement Requests to existing resources that expand the functionality or scope. label Jul 11, 2019
@bflad bflad self-assigned this Jul 11, 2019
@kristiandrucker
Copy link
Contributor Author

Hi @bflad 👋 I think that this pull request is a duplicate of (#7823). Timeout Seconds is created here. I have just implemented that and put TaskParameters along with S3 Log bucket into TaskInvocationParameters because AWS doesn't recognise them when I just put TimeoutSeconds in TaskInvocationParameters.

@bflad
Copy link
Contributor

bflad commented Jul 16, 2019

Hi again @kristiandrucker 👋 I just merged #7823 which it sounds like may have covered the functionality this pull request. If I misunderstood here, please feel free to submit a new pull request thats rebased against master as the merge introduced merge conflicts. Thank you for contributing!

@bflad bflad closed this Jul 16, 2019
@ghost
Copy link

ghost commented Nov 2, 2019

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!

@ghost ghost locked and limited conversation to collaborators Nov 2, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
documentation Introduces or discusses updates to documentation. enhancement Requests to existing resources that expand the functionality or scope. service/ssm Issues and PRs that pertain to the ssm service. size/S Managed by automation to categorize the size of a PR.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Various AWS SSM Providers parameters are missing arguments
2 participants