Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

resource/aws_vpc_peering_connection: Implement sweeper and refactor deletion StateChangeConf logic into function #9499

Merged
merged 1 commit into from
Jul 29, 2019
Merged

resource/aws_vpc_peering_connection: Implement sweeper and refactor deletion StateChangeConf logic into function #9499

merged 1 commit into from
Jul 29, 2019

Conversation

bflad
Copy link
Contributor

@bflad bflad commented Jul 25, 2019 •
edited
Loading

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
  • Please do not leave "+1" comments, they generate extra noise for pull request followers and do not help prioritize the request

Release note for CHANGELOG:

NONE

Previously:

[12:24:03][Step 2/5] 2019/07/25 12:24:03 [ERR] error running (aws_eip): Error deleting VPC (vpc-08c9a1e96fdc6802e): DependencyViolation: The vpc 'vpc-08c9a1e96fdc6802e' has dependencies and cannot be deleted.

Output from sweeper:

$ go test ./aws -v -sweep=us-east-1,us-west-2 -sweep-run=aws_vpc -timeout 10h
...
2019/07/25 09:35:28 [INFO] Deleting EC2 VPC Peering Connection: pcx-0a3b6b695a8021b0f
...
2019/07/25 09:36:06 [DEBUG] Deleting VPC: {
  VpcId: "vpc-08c9a1e96fdc6802e"
}
2019/07/25 09:36:06 [DEBUG] Waiting for state to become: [success]
2019/07/25 09:36:07 [DEBUG] Deleting VPC: {
  VpcId: "vpc-0ad093f967850f7dc"
}
...

@bflad bflad added tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. service/ec2 Issues and PRs that pertain to the ec2 service. labels Jul 25, 2019
@bflad bflad requested a review from a team July 25, 2019 13:39
@ghost ghost added the size/M Managed by automation to categorize the size of a PR. label Jul 25, 2019
@bflad
resource/aws_vpc_peering_connection: Implement sweeper and refactor d…
1bf6a97 
…eletion StateChangeConf logic into function

Previously:

```
[12:24:03][Step 2/5] 2019/07/25 12:24:03 [ERR] error running (aws_eip): Error deleting VPC (vpc-08c9a1e96fdc6802e): DependencyViolation: The vpc 'vpc-08c9a1e96fdc6802e' has dependencies and cannot be deleted.
```

Output from sweeper in AWS Commercial:

```
$ go test ./aws -v -sweep=us-east-1,us-west-2 -sweep-run=aws_ec2_transit_gateway -timeout 10h
...
2019/07/25 09:35:28 [INFO] Deleting EC2 VPC Peering Connection: pcx-0a3b6b695a8021b0f
...
2019/07/25 09:36:06 [DEBUG] Deleting VPC: {
  VpcId: "vpc-08c9a1e96fdc6802e"
}
2019/07/25 09:36:06 [DEBUG] Waiting for state to become: [success]
2019/07/25 09:36:07 [DEBUG] Deleting VPC: {
  VpcId: "vpc-0ad093f967850f7dc"
}
...
```
@bflad bflad force-pushed the t-aws_vpc_peering_connection-sweeper branch from 1eb03b8 to 1bf6a97 Compare July 25, 2019 22:26
nywilken
nywilken approved these changes Jul 29, 2019
View reviewed changes
Copy link
Member

@nywilken nywilken left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍 👍

@bflad bflad added this to the v2.22.0 milestone Jul 29, 2019
@bflad
Copy link
Contributor Author

bflad commented Jul 29, 2019

Whoops looks like I didn't include acceptance test output originally even though I refactored the resource code. All good:

--- PASS: TestAccAWSVPCPeeringConnection_basic (21.83s)
--- PASS: TestAccAWSVPCPeeringConnection_failedState (19.10s)
--- PASS: TestAccAWSVPCPeeringConnection_importBasic (20.82s)
--- PASS: TestAccAWSVPCPeeringConnection_options (44.76s)
--- PASS: TestAccAWSVPCPeeringConnection_peerRegionAndAutoAccept (14.65s)
--- PASS: TestAccAWSVPCPeeringConnection_plan (20.94s)
--- PASS: TestAccAWSVPCPeeringConnection_region (36.42s)
--- PASS: TestAccAWSVPCPeeringConnection_tags (27.96s)

@bflad bflad merged commit e45c3f2 into master Jul 29, 2019
@bflad bflad deleted the t-aws_vpc_peering_connection-sweeper branch July 29, 2019 19:55
@ghost
Copy link

ghost commented Aug 1, 2019

This has been released in version 2.22.0 of the Terraform AWS provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template for triage. Thanks!

@ewbankkit ewbankkit mentioned this pull request Aug 2, 2019
Merged
@ghost
Copy link

ghost commented Nov 2, 2019

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!

@ghost ghost locked and limited conversation to collaborators Nov 2, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@nywilken nywilken nywilken approved these changes

Assignees
No one assigned
Labels
service/ec2 Issues and PRs that pertain to the ec2 service. size/M Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Milestone
v2.22.0
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@bflad @nywilken