Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

resource/aws_autoscaling_group: Temporarily revert load_balancers and target_group_arns Computed behavior #9518

Merged
merged 1 commit into from
Jul 26, 2019
Merged

resource/aws_autoscaling_group: Temporarily revert load_balancers and target_group_arns Computed behavior #9518

merged 1 commit into from
Jul 26, 2019

Conversation

bflad
Copy link
Contributor

@bflad bflad commented Jul 26, 2019

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
  • Please do not leave "+1" comments, they generate extra noise for pull request followers and do not help prioritize the request

The original change will likely occur in a future major version of the Terraform AWS Provider.

Closes #9513

Release note for CHANGELOG:

* resource/aws_autoscaling_group: Revert change from version 2.21.0 to `load_balancers` and `target_group_arns` arguments that removes attachments when using the `aws_autoscaling_attachment` resource (https://github.com/terraform-providers/terraform-provider-aws/issues/9513)

Output from acceptance testing:

--- PASS: TestAccAWSAutoScalingGroup_WithLoadBalancer_ToTargetGroup (645.69s)

@bflad
resource/aws_autoscaling_group: Temporarily revert load_balancers and…
e34a059 
… target_group_arns Computed behavior

The original change will likely occur in a future major version of the Terraform AWS Provider.

Reference: #9513

Output from acceptance testing:

```
--- PASS: TestAccAWSAutoScalingGroup_WithLoadBalancer_ToTargetGroup (645.69s)
```
@bflad bflad added bug Addresses a defect in current functionality. regression Pertains to a degraded workflow resulting from an upstream patch or internal enhancement. service/autoscaling Issues and PRs that pertain to the autoscaling service. labels Jul 26, 2019
@bflad bflad added this to the v2.21.1 milestone Jul 26, 2019
@bflad bflad requested a review from a team July 26, 2019 15:10
@ghost ghost added size/XS Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. labels Jul 26, 2019
@bflad bflad mentioned this pull request Jul 26, 2019
Closed
nywilken
nywilken approved these changes Jul 26, 2019
View reviewed changes
Copy link
Member

@nywilken nywilken left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍 👍

@bflad bflad merged commit 90a3d76 into master Jul 26, 2019
@bflad bflad deleted the b-aws_autoscaling_group-revert branch July 26, 2019 15:17
bflad added a commit that referenced this pull request Jul 26, 2019
@bflad
Update CHANGELOG for #9518
d1125ae
@ghost
Copy link

ghost commented Nov 2, 2019

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!

@ghost ghost locked and limited conversation to collaborators Nov 2, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@nywilken nywilken nywilken approved these changes

Assignees
No one assigned
Labels
bug Addresses a defect in current functionality. regression Pertains to a degraded workflow resulting from an upstream patch or internal enhancement. service/autoscaling Issues and PRs that pertain to the autoscaling service. size/XS Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Milestone
v2.21.1
Development

Successfully merging this pull request may close these issues.

resource/aws_autoscaling_group: Unexpected Removal of Target Group ARNs in version 2.21.0
2 participants
@bflad @nywilken