Enable container_insights for ecs_cluster

[chaspy]

Community Note

• Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
• Please do not leave "+1" comments, they generate extra noise for pull request followers and do not help prioritize the request

Relates OR Closes #9294

Release note for CHANGELOG:

resource/aws_ecs_cluster: Add `container_insights` argument 

Output from acceptance testing:

$ make testacc TESTARGS='-run=TestAccAWSEcsCluster_basic'

...

[chaspy]

🤔

$ make testacc TESTARGS='-run=TestAccAWSEcsCluster_basic'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./... -v -parallel 20 -run=TestAccAWSEcsCluster_basic -timeout 120m
# github.com/terraform-providers/terraform-provider-aws
./test.go:11:6: main redeclared in this block
	previous declaration at ./main.go:8:6
=== RUN   TestAccAWSEcsCluster_basic
=== PAUSE TestAccAWSEcsCluster_basic
=== CONT  TestAccAWSEcsCluster_basic
--- FAIL: TestAccAWSEcsCluster_basic (38.32s)
    testing.go:568: Step 1 error: ImportStateVerify attributes not equivalent. Difference is shown below. Top is actual, bottom is expected.

        (map[string]string) {
        }


        (map[string]string) (len=1) {
         (string) (len=18) "container_insights": (string) (len=4) "true"
        }

FAIL
FAIL	github.com/terraform-providers/terraform-provider-aws/aws	38.383s
make: *** [testacc] Error 2

[bflad]

Hi @chaspy 👋 Thank you so much for your contribution here and sorry it was never reviewed in its draft state. Since this was still work in progress and a fully finished implementation came along in #9720, we opted to merge that to release this functionality.

Some general notes that may help for future contributions:

testing.go:568: Step 1 error: ImportStateVerify attributes not equivalent. Difference is shown below. Top is actual, bottom is expected.

This error occurs when an attribute is not being saved correctly in the Terraform state during the Read function. e.g. d.Set("attribute_name", attributeValue)

• We typically prefer to match the AWS API implementations when implementing the Terraform resource to remove any abstractions or future complications with API changes in the future. This also helps Terraform match the AWS CLI, SDKs, and CloudFormation syntax. With the API using a data structure to represent each setting, we would prefer to match that in Terraform via configuration block syntax. resource/ecs_cluster: Add ability to enable ECS Cluster Insights #9720 shows this type of schema handling with a TypeSet attribute and expand/flatten functions.
• When enhancing an existing resource, we typically prefer to add a new acceptance test to cover the new functionality and leave the existing testing to cover potential regressions. More information about this can be found in the Contributing Guide.

We appreciate the effort you put in here and hope to see contributions from you in the future. 😄

[ghost]

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!