Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

9775 launch config with instance store #9810

Merged
merged 2 commits into from
Feb 12, 2020
Merged

9775 launch config with instance store #9810

merged 2 commits into from
Feb 12, 2020

Conversation

jc-asdf
Copy link
Contributor

@jc-asdf jc-asdf commented Aug 18, 2019 •
edited

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
  • Please do not leave "+1" comments, they generate extra noise for pull request followers and do not help prioritize the request

Closes #9775

Release note for CHANGELOG:

* fix unintended breakage of aws_launch_config when combined with instance-store AMIs

Output from acceptance testing:

Two sections affected.

aws_launch_configuration:

$ make testacc TEST=./aws TESTARGS='-run=TestAccAWSLaunchConfiguration'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws -v -parallel 20 -run=TestAccAWSLaunchConfiguration -timeout 120m
=== RUN   TestAccAWSLaunchConfigurationDataSource_basic
=== PAUSE TestAccAWSLaunchConfigurationDataSource_basic
=== RUN   TestAccAWSLaunchConfigurationDataSource_securityGroups
=== PAUSE TestAccAWSLaunchConfigurationDataSource_securityGroups
=== RUN   TestAccAWSLaunchConfiguration_importBasic
=== PAUSE TestAccAWSLaunchConfiguration_importBasic
=== RUN   TestAccAWSLaunchConfiguration_basic
=== PAUSE TestAccAWSLaunchConfiguration_basic
=== RUN   TestAccAWSLaunchConfiguration_withBlockDevices
=== PAUSE TestAccAWSLaunchConfiguration_withBlockDevices
=== RUN   TestAccAWSLaunchConfiguration_withInstanceStoreAMI
=== PAUSE TestAccAWSLaunchConfiguration_withInstanceStoreAMI
=== RUN   TestAccAWSLaunchConfiguration_updateRootBlockDevice
=== PAUSE TestAccAWSLaunchConfiguration_updateRootBlockDevice
=== RUN   TestAccAWSLaunchConfiguration_encryptedRootBlockDevice
=== PAUSE TestAccAWSLaunchConfiguration_encryptedRootBlockDevice
=== RUN   TestAccAWSLaunchConfiguration_withSpotPrice
=== PAUSE TestAccAWSLaunchConfiguration_withSpotPrice
=== RUN   TestAccAWSLaunchConfiguration_withVpcClassicLink
=== PAUSE TestAccAWSLaunchConfiguration_withVpcClassicLink
=== RUN   TestAccAWSLaunchConfiguration_withIAMProfile
=== PAUSE TestAccAWSLaunchConfiguration_withIAMProfile
=== RUN   TestAccAWSLaunchConfiguration_withEncryption
=== PAUSE TestAccAWSLaunchConfiguration_withEncryption
=== RUN   TestAccAWSLaunchConfiguration_updateEbsBlockDevices
=== PAUSE TestAccAWSLaunchConfiguration_updateEbsBlockDevices
=== RUN   TestAccAWSLaunchConfiguration_ebs_noDevice
=== PAUSE TestAccAWSLaunchConfiguration_ebs_noDevice
=== RUN   TestAccAWSLaunchConfiguration_userData
=== PAUSE TestAccAWSLaunchConfiguration_userData
=== CONT  TestAccAWSLaunchConfigurationDataSource_basic
=== CONT  TestAccAWSLaunchConfigurationDataSource_securityGroups
=== CONT  TestAccAWSLaunchConfiguration_withSpotPrice
=== CONT  TestAccAWSLaunchConfiguration_userData
=== CONT  TestAccAWSLaunchConfiguration_ebs_noDevice
=== CONT  TestAccAWSLaunchConfiguration_updateEbsBlockDevices
=== CONT  TestAccAWSLaunchConfiguration_withEncryption
=== CONT  TestAccAWSLaunchConfiguration_withIAMProfile
=== CONT  TestAccAWSLaunchConfiguration_encryptedRootBlockDevice
=== CONT  TestAccAWSLaunchConfiguration_updateRootBlockDevice
=== CONT  TestAccAWSLaunchConfiguration_withInstanceStoreAMI
=== CONT  TestAccAWSLaunchConfiguration_withBlockDevices
=== CONT  TestAccAWSLaunchConfiguration_basic
=== CONT  TestAccAWSLaunchConfiguration_importBasic
=== CONT  TestAccAWSLaunchConfiguration_withVpcClassicLink
--- PASS: TestAccAWSLaunchConfiguration_importBasic (33.94s)
--- PASS: TestAccAWSLaunchConfiguration_withSpotPrice (35.32s)
--- PASS: TestAccAWSLaunchConfiguration_withInstanceStoreAMI (35.36s)
--- PASS: TestAccAWSLaunchConfiguration_ebs_noDevice (37.86s)
--- PASS: TestAccAWSLaunchConfiguration_withEncryption (37.95s)
--- PASS: TestAccAWSLaunchConfiguration_withBlockDevices (38.67s)
--- PASS: TestAccAWSLaunchConfigurationDataSource_basic (39.52s)
--- PASS: TestAccAWSLaunchConfiguration_withIAMProfile (47.21s)
--- PASS: TestAccAWSLaunchConfiguration_basic (58.30s)
--- PASS: TestAccAWSLaunchConfiguration_userData (59.68s)
--- PASS: TestAccAWSLaunchConfiguration_updateRootBlockDevice (65.48s)
--- PASS: TestAccAWSLaunchConfiguration_encryptedRootBlockDevice (66.01s)
--- PASS: TestAccAWSLaunchConfiguration_updateEbsBlockDevices (67.17s)
--- PASS: TestAccAWSLaunchConfigurationDataSource_securityGroups (70.49s)
--- PASS: TestAccAWSLaunchConfiguration_withVpcClassicLink (75.17s)
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws	77.472s
terraform-provider
...

The aws_instance tests are odd - no matter what I try, it keeps trying to make some of the test resources in us-east-1, which is not where the test AMIs are located. I've set and exported AWS_DEFAULT_REGION=us-west-2, and set the region in the default aws configuration, etc... but no luck.

I suspect I'm running into some variation of what's described in #8316 when running the aws_instance tests. Running individually is working so far. Will attach a full list of the individual tests run.

Jonas Courteau added 2 commits August 18, 2019 14:42
revert part of 3d330bd
25fb1ca 
* this revers part of commit 3d330bd, re-enabling the ability to use instance-store volumes
* fetchRootDeviceName() will again return `nil, nil` when used against instance-store AMIs
* re-add the `nil` value checking to fetchRootDeviceName() usage in readBlockDeviceMappingsFromConfig()
added test coverage for aws_launch_config + instance store AMIs
feafaa3 
* added instance store data AMI source
* added basic acceptance test using this instance-store AMI
@jc-asdf jc-asdf requested a review from a team August 18, 2019 22:46
@ghost ghost added size/M Managed by automation to categorize the size of a PR. service/autoscaling Issues and PRs that pertain to the autoscaling service. service/ec2 Issues and PRs that pertain to the ec2 service. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. labels Aug 18, 2019
@jc-asdf jc-asdf mentioned this pull request Aug 18, 2019
Closed
@jc-asdf
Copy link
Contributor Author

jc-asdf commented Aug 19, 2019 •
edited

aws_instance acceptance test output.

Ended up having to extract a list of tests, and then run them each individually. Several tests were re-run due to low availability of m1 instances in us-west-2; perhaps more of these should be moved to t3 instances over time?

for I in `cat tests.txt`; do make testacc TEST=./aws TESTARGS="-run=$I"; done

==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws -v -parallel 1 -run=TestAccAWSInstance_importBasic -timeout 120m
=== RUN   TestAccAWSInstance_importBasic
=== PAUSE TestAccAWSInstance_importBasic
=== CONT  TestAccAWSInstance_importBasic
--- PASS: TestAccAWSInstance_importBasic (101.95s)
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws	105.094s

==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws -v -parallel 1 -run=TestAccAWSInstance_importInDefaultVpcBySgName -timeout 120m
=== RUN   TestAccAWSInstance_importInDefaultVpcBySgName
=== PAUSE TestAccAWSInstance_importInDefaultVpcBySgName
=== CONT  TestAccAWSInstance_importInDefaultVpcBySgName
--- PASS: TestAccAWSInstance_importInDefaultVpcBySgName (142.95s)
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws	143.462s

==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws -v -parallel 1 -run=TestAccAWSInstance_importInDefaultVpcBySgId -timeout 120m
=== RUN   TestAccAWSInstance_importInDefaultVpcBySgId
=== PAUSE TestAccAWSInstance_importInDefaultVpcBySgId
=== CONT  TestAccAWSInstance_importInDefaultVpcBySgId
--- PASS: TestAccAWSInstance_importInDefaultVpcBySgId (163.06s)
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws	163.574s

==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws -v -parallel 1 -run=TestAccAWSInstance_importInEc2Classic -timeout 120m
=== RUN   TestAccAWSInstance_importInEc2Classic
=== PAUSE TestAccAWSInstance_importInEc2Classic
=== CONT  TestAccAWSInstance_importInEc2Classic
--- SKIP: TestAccAWSInstance_importInEc2Classic (2.74s)
    provider_test.go:216: This test can only run in EC2 Classic, platforms available in us-east-1: ["VPC"]
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws	3.256s

==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws -v -parallel 1 -run=TestAccAWSInstance_basic -timeout 120m
=== RUN   TestAccAWSInstance_basic
=== PAUSE TestAccAWSInstance_basic
=== CONT  TestAccAWSInstance_basic
--- PASS: TestAccAWSInstance_basic (264.22s)
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws	264.727s

==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws -v -parallel 1 -run=TestAccAWSInstance_EbsBlockDevice_KmsKeyArn -timeout 120m
=== RUN   TestAccAWSInstance_EbsBlockDevice_KmsKeyArn
=== PAUSE TestAccAWSInstance_EbsBlockDevice_KmsKeyArn
=== CONT  TestAccAWSInstance_EbsBlockDevice_KmsKeyArn
--- PASS: TestAccAWSInstance_EbsBlockDevice_KmsKeyArn (164.25s)
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws	164.748s

==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws -v -parallel 1 -run=TestAccAWSInstance_RootBlockDevice_KmsKeyArn -timeout 120m
=== RUN   TestAccAWSInstance_RootBlockDevice_KmsKeyArn
=== PAUSE TestAccAWSInstance_RootBlockDevice_KmsKeyArn
=== CONT  TestAccAWSInstance_RootBlockDevice_KmsKeyArn
--- PASS: TestAccAWSInstance_RootBlockDevice_KmsKeyArn (204.42s)
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws	204.921s

==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws -v -parallel 1 -run=TestAccAWSInstance_userDataBase64 -timeout 120m
=== RUN   TestAccAWSInstance_userDataBase64
=== PAUSE TestAccAWSInstance_userDataBase64
=== CONT  TestAccAWSInstance_userDataBase64
--- PASS: TestAccAWSInstance_userDataBase64 (166.53s)
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws	167.037s

==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws -v -parallel 1 -run=TestAccAWSInstance_GP2IopsDevice -timeout 120m
=== RUN   TestAccAWSInstance_GP2IopsDevice
=== PAUSE TestAccAWSInstance_GP2IopsDevice
=== CONT  TestAccAWSInstance_GP2IopsDevice
--- PASS: TestAccAWSInstance_GP2IopsDevice (111.96s)
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws	112.479s

==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws -v -parallel 1 -run=TestAccAWSInstance_GP2WithIopsValue -timeout 120m
=== RUN   TestAccAWSInstance_GP2WithIopsValue
=== PAUSE TestAccAWSInstance_GP2WithIopsValue
=== CONT  TestAccAWSInstance_GP2WithIopsValue
--- PASS: TestAccAWSInstance_GP2WithIopsValue (144.62s)
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws	145.131s

==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws -v -parallel 1 -run=TestAccAWSInstance_blockDevices -timeout 120m
=== RUN   TestAccAWSInstance_blockDevices
=== PAUSE TestAccAWSInstance_blockDevices
=== CONT  TestAccAWSInstance_blockDevices
--- PASS: TestAccAWSInstance_blockDevices (123.85s)
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws	124.351s

==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws -v -parallel 1 -run=TestAccAWSInstance_rootInstanceStore -timeout 120m
=== RUN   TestAccAWSInstance_rootInstanceStore
=== PAUSE TestAccAWSInstance_rootInstanceStore
=== CONT  TestAccAWSInstance_rootInstanceStore
--- PASS: TestAccAWSInstance_rootInstanceStore (104.15s)
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws	104.656s

==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws -v -parallel 1 -run=TestAccAWSInstance_noAMIEphemeralDevices -timeout 120m
=== RUN   TestAccAWSInstance_noAMIEphemeralDevices
=== PAUSE TestAccAWSInstance_noAMIEphemeralDevices
=== CONT  TestAccAWSInstance_noAMIEphemeralDevices
--- PASS: TestAccAWSInstance_noAMIEphemeralDevices (89.67s)
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws	90.175s

==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws -v -parallel 1 -run=TestAccAWSInstance_sourceDestCheck -timeout 120m
=== RUN   TestAccAWSInstance_sourceDestCheck
=== PAUSE TestAccAWSInstance_sourceDestCheck
=== CONT  TestAccAWSInstance_sourceDestCheck
--- PASS: TestAccAWSInstance_sourceDestCheck (409.67s)
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws	410.209s

==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws -v -parallel 1 -run=TestAccAWSInstance_disableApiTermination -timeout 120m
=== RUN   TestAccAWSInstance_disableApiTermination
=== PAUSE TestAccAWSInstance_disableApiTermination
=== CONT  TestAccAWSInstance_disableApiTermination
--- PASS: TestAccAWSInstance_disableApiTermination (294.83s)
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws	295.341s

==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws -v -parallel 1 -run=TestAccAWSInstance_vpc -timeout 120m
=== RUN   TestAccAWSInstance_vpc
=== PAUSE TestAccAWSInstance_vpc
=== CONT  TestAccAWSInstance_vpc
--- PASS: TestAccAWSInstance_vpc (79.37s)
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws	79.901s

==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws -v -parallel 1 -run=TestAccAWSInstance_placementGroup -timeout 120m
=== RUN   TestAccAWSInstance_placementGroup
=== PAUSE TestAccAWSInstance_placementGroup
=== CONT  TestAccAWSInstance_placementGroup
--- PASS: TestAccAWSInstance_placementGroup (172.97s)
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws	173.467s


==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws -v -parallel 1 -run=TestAccAWSInstance_ipv6_supportAddressCount -timeout 120m
=== RUN   TestAccAWSInstance_ipv6_supportAddressCount
=== PAUSE TestAccAWSInstance_ipv6_supportAddressCount
=== RUN   TestAccAWSInstance_ipv6_supportAddressCountWithIpv4
=== PAUSE TestAccAWSInstance_ipv6_supportAddressCountWithIpv4
=== CONT  TestAccAWSInstance_ipv6_supportAddressCount
--- PASS: TestAccAWSInstance_ipv6_supportAddressCount (81.84s)
=== CONT  TestAccAWSInstance_ipv6_supportAddressCountWithIpv4
--- PASS: TestAccAWSInstance_ipv6_supportAddressCountWithIpv4 (208.47s)
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws	290.850s

==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws -v -parallel 1 -run=TestAccAWSInstance_ipv6AddressCountAndSingleAddressCausesError -timeout 120m
=== RUN   TestAccAWSInstance_ipv6AddressCountAndSingleAddressCausesError
=== PAUSE TestAccAWSInstance_ipv6AddressCountAndSingleAddressCausesError
=== CONT  TestAccAWSInstance_ipv6AddressCountAndSingleAddressCausesError
--- PASS: TestAccAWSInstance_ipv6AddressCountAndSingleAddressCausesError (64.27s)
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws	64.782s

==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws -v -parallel 1 -run=TestAccAWSInstance_ipv6_supportAddressCountWithIpv4 -timeout 120m
=== RUN   TestAccAWSInstance_ipv6_supportAddressCountWithIpv4
=== PAUSE TestAccAWSInstance_ipv6_supportAddressCountWithIpv4
=== CONT  TestAccAWSInstance_ipv6_supportAddressCountWithIpv4
--- PASS: TestAccAWSInstance_ipv6_supportAddressCountWithIpv4 (204.19s)
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws	204.713s

==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws -v -parallel 1 -run=TestAccAWSInstance_multipleRegions -timeout 120m
=== RUN   TestAccAWSInstance_multipleRegions
=== PAUSE TestAccAWSInstance_multipleRegions
=== CONT  TestAccAWSInstance_multipleRegions
--- PASS: TestAccAWSInstance_multipleRegions (314.46s)
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws	314.980s

==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws -v -parallel 1 -run=TestAccAWSInstance_NetworkInstanceSecurityGroups -timeout 120m
=== RUN   TestAccAWSInstance_NetworkInstanceSecurityGroups
=== PAUSE TestAccAWSInstance_NetworkInstanceSecurityGroups
=== CONT  TestAccAWSInstance_NetworkInstanceSecurityGroups
--- PASS: TestAccAWSInstance_NetworkInstanceSecurityGroups (185.57s)
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws	186.076s

==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws -v -parallel 1 -run=TestAccAWSInstance_NetworkInstanceRemovingAllSecurityGroups -timeout 120m
=== RUN   TestAccAWSInstance_NetworkInstanceRemovingAllSecurityGroups
=== PAUSE TestAccAWSInstance_NetworkInstanceRemovingAllSecurityGroups
=== CONT  TestAccAWSInstance_NetworkInstanceRemovingAllSecurityGroups
--- PASS: TestAccAWSInstance_NetworkInstanceRemovingAllSecurityGroups (222.81s)
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws	223.323s

==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws -v -parallel 1 -run=TestAccAWSInstance_NetworkInstanceVPCSecurityGroupIDs -timeout 120m
=== RUN   TestAccAWSInstance_NetworkInstanceVPCSecurityGroupIDs
=== PAUSE TestAccAWSInstance_NetworkInstanceVPCSecurityGroupIDs
=== CONT  TestAccAWSInstance_NetworkInstanceVPCSecurityGroupIDs
--- PASS: TestAccAWSInstance_NetworkInstanceVPCSecurityGroupIDs (189.27s)
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws	189.776s

==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws -v -parallel 1 -run=TestAccAWSInstance_tags -timeout 120m
=== RUN   TestAccAWSInstance_tags
=== PAUSE TestAccAWSInstance_tags
=== CONT  TestAccAWSInstance_tags
--- PASS: TestAccAWSInstance_tags (260.71s)
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws	261.213s

==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws -v -parallel 1 -run=TestAccAWSInstance_volumeTags -timeout 120m
=== RUN   TestAccAWSInstance_volumeTags
=== PAUSE TestAccAWSInstance_volumeTags
=== RUN   TestAccAWSInstance_volumeTagsComputed
=== PAUSE TestAccAWSInstance_volumeTagsComputed
=== CONT  TestAccAWSInstance_volumeTags
--- PASS: TestAccAWSInstance_volumeTags (260.42s)
=== CONT  TestAccAWSInstance_volumeTagsComputed
--- PASS: TestAccAWSInstance_volumeTagsComputed (201.36s)
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws	462.281s

==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws -v -parallel 1 -run=TestAccAWSInstance_volumeTagsComputed -timeout 120m
=== RUN   TestAccAWSInstance_volumeTagsComputed
=== PAUSE TestAccAWSInstance_volumeTagsComputed
=== CONT  TestAccAWSInstance_volumeTagsComputed
--- PASS: TestAccAWSInstance_volumeTagsComputed (214.75s)
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws	215.256s

==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws -v -parallel 1 -run=TestAccAWSInstance_instanceProfileChange -timeout 120m
=== RUN   TestAccAWSInstance_instanceProfileChange
=== PAUSE TestAccAWSInstance_instanceProfileChange
=== CONT  TestAccAWSInstance_instanceProfileChange
--- PASS: TestAccAWSInstance_instanceProfileChange (644.34s)
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws	644.842s

==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws -v -parallel 1 -run=TestAccAWSInstance_withIamInstanceProfile -timeout 120m
=== RUN   TestAccAWSInstance_withIamInstanceProfile
=== PAUSE TestAccAWSInstance_withIamInstanceProfile
=== CONT  TestAccAWSInstance_withIamInstanceProfile
--- PASS: TestAccAWSInstance_withIamInstanceProfile (209.58s)
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws	210.082s

==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws -v -parallel 1 -run=TestAccAWSInstance_privateIP -timeout 120m
=== RUN   TestAccAWSInstance_privateIP
=== PAUSE TestAccAWSInstance_privateIP
=== CONT  TestAccAWSInstance_privateIP
--- PASS: TestAccAWSInstance_privateIP (187.24s)
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws	187.745s

==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws -v -parallel 1 -run=TestAccAWSInstance_associatePublicIPAndPrivateIP -timeout 120m
=== RUN   TestAccAWSInstance_associatePublicIPAndPrivateIP
=== PAUSE TestAccAWSInstance_associatePublicIPAndPrivateIP
=== CONT  TestAccAWSInstance_associatePublicIPAndPrivateIP
--- PASS: TestAccAWSInstance_associatePublicIPAndPrivateIP (229.03s)
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws	229.529s

==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws -v -parallel 1 -run=TestAccAWSInstance_keyPairCheck -timeout 120m
=== RUN   TestAccAWSInstance_keyPairCheck
=== PAUSE TestAccAWSInstance_keyPairCheck
=== CONT  TestAccAWSInstance_keyPairCheck
--- PASS: TestAccAWSInstance_keyPairCheck (249.38s)
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws	249.875s

==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws -v -parallel 1 -run=TestAccAWSInstance_rootBlockDeviceMismatch -timeout 120m
=== RUN   TestAccAWSInstance_rootBlockDeviceMismatch
=== PAUSE TestAccAWSInstance_rootBlockDeviceMismatch
=== CONT  TestAccAWSInstance_rootBlockDeviceMismatch
--- PASS: TestAccAWSInstance_rootBlockDeviceMismatch (147.42s)
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws	147.920s

==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws -v -parallel 1 -run=TestAccAWSInstance_forceNewAndTagsDrift -timeout 120m
=== RUN   TestAccAWSInstance_forceNewAndTagsDrift
=== PAUSE TestAccAWSInstance_forceNewAndTagsDrift
=== CONT  TestAccAWSInstance_forceNewAndTagsDrift
--- PASS: TestAccAWSInstance_forceNewAndTagsDrift (261.78s)
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws	262.307s

==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws -v -parallel 1 -run=TestAccAWSInstance_changeInstanceType -timeout 120m
=== RUN   TestAccAWSInstance_changeInstanceType
=== PAUSE TestAccAWSInstance_changeInstanceType
=== CONT  TestAccAWSInstance_changeInstanceType
--- PASS: TestAccAWSInstance_changeInstanceType (208.50s)
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws	209.007s

==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws -v -parallel 1 -run=TestAccAWSInstance_primaryNetworkInterface -timeout 120m
=== RUN   TestAccAWSInstance_primaryNetworkInterface
=== PAUSE TestAccAWSInstance_primaryNetworkInterface
=== RUN   TestAccAWSInstance_primaryNetworkInterfaceSourceDestCheck
=== PAUSE TestAccAWSInstance_primaryNetworkInterfaceSourceDestCheck
=== CONT  TestAccAWSInstance_primaryNetworkInterface
--- PASS: TestAccAWSInstance_primaryNetworkInterface (171.65s)
=== CONT  TestAccAWSInstance_primaryNetworkInterfaceSourceDestCheck
--- PASS: TestAccAWSInstance_primaryNetworkInterfaceSourceDestCheck (173.96s)
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws	346.104s

==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws -v -parallel 1 -run=TestAccAWSInstance_primaryNetworkInterfaceSourceDestCheck -timeout 120m
=== RUN   TestAccAWSInstance_primaryNetworkInterfaceSourceDestCheck
=== PAUSE TestAccAWSInstance_primaryNetworkInterfaceSourceDestCheck
=== CONT  TestAccAWSInstance_primaryNetworkInterfaceSourceDestCheck
--- PASS: TestAccAWSInstance_primaryNetworkInterfaceSourceDestCheck (168.02s)
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws	168.531s

==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws -v -parallel 1 -run=TestAccAWSInstance_addSecondaryInterface -timeout 120m
=== RUN   TestAccAWSInstance_addSecondaryInterface
=== PAUSE TestAccAWSInstance_addSecondaryInterface
=== CONT  TestAccAWSInstance_addSecondaryInterface
--- PASS: TestAccAWSInstance_addSecondaryInterface (286.46s)
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws	286.972s

==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws -v -parallel 1 -run=TestAccAWSInstance_addSecurityGroupNetworkInterface -timeout 120m
=== RUN   TestAccAWSInstance_addSecurityGroupNetworkInterface
=== PAUSE TestAccAWSInstance_addSecurityGroupNetworkInterface
=== CONT  TestAccAWSInstance_addSecurityGroupNetworkInterface
--- PASS: TestAccAWSInstance_addSecurityGroupNetworkInterface (408.25s)
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws	408.762s

==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws -v -parallel 1 -run=TestAccAWSInstance_associatePublic_defaultPrivate -timeout 120m
=== RUN   TestAccAWSInstance_associatePublic_defaultPrivate
=== PAUSE TestAccAWSInstance_associatePublic_defaultPrivate
=== CONT  TestAccAWSInstance_associatePublic_defaultPrivate
--- PASS: TestAccAWSInstance_associatePublic_defaultPrivate (174.84s)
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws	175.352s

==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws -v -parallel 1 -run=TestAccAWSInstance_associatePublic_defaultPublic -timeout 120m
=== RUN   TestAccAWSInstance_associatePublic_defaultPublic
=== PAUSE TestAccAWSInstance_associatePublic_defaultPublic
=== CONT  TestAccAWSInstance_associatePublic_defaultPublic
--- PASS: TestAccAWSInstance_associatePublic_defaultPublic (176.42s)
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws	176.922s

==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws -v -parallel 1 -run=TestAccAWSInstance_associatePublic_explicitPublic -timeout 120m
=== RUN   TestAccAWSInstance_associatePublic_explicitPublic
=== PAUSE TestAccAWSInstance_associatePublic_explicitPublic
=== CONT  TestAccAWSInstance_associatePublic_explicitPublic
--- PASS: TestAccAWSInstance_associatePublic_explicitPublic (169.89s)
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws	170.421s

==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws -v -parallel 1 -run=TestAccAWSInstance_associatePublic_explicitPrivate -timeout 120m
=== RUN   TestAccAWSInstance_associatePublic_explicitPrivate
=== PAUSE TestAccAWSInstance_associatePublic_explicitPrivate
=== CONT  TestAccAWSInstance_associatePublic_explicitPrivate
--- PASS: TestAccAWSInstance_associatePublic_explicitPrivate (178.02s)
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws	178.534s

==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws -v -parallel 1 -run=TestAccAWSInstance_associatePublic_overridePublic -timeout 120m
=== RUN   TestAccAWSInstance_associatePublic_overridePublic
=== PAUSE TestAccAWSInstance_associatePublic_overridePublic
=== CONT  TestAccAWSInstance_associatePublic_overridePublic
--- PASS: TestAccAWSInstance_associatePublic_overridePublic (166.19s)
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws	166.705s

==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws -v -parallel 1 -run=TestAccAWSInstance_associatePublic_overridePrivate -timeout 120m
=== RUN   TestAccAWSInstance_associatePublic_overridePrivate
=== PAUSE TestAccAWSInstance_associatePublic_overridePrivate
=== CONT  TestAccAWSInstance_associatePublic_overridePrivate
--- PASS: TestAccAWSInstance_associatePublic_overridePrivate (266.01s)
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws	266.516s

==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws -v -parallel 1 -run=TestAccAWSInstance_getPasswordData_falseToTrue -timeout 120m
=== RUN   TestAccAWSInstance_getPasswordData_falseToTrue
=== PAUSE TestAccAWSInstance_getPasswordData_falseToTrue
=== CONT  TestAccAWSInstance_getPasswordData_falseToTrue
--- PASS: TestAccAWSInstance_getPasswordData_falseToTrue (249.25s)
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws	249.758s

==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws -v -parallel 1 -run=TestAccAWSInstance_getPasswordData_trueToFalse -timeout 120m
=== RUN   TestAccAWSInstance_getPasswordData_trueToFalse
=== PAUSE TestAccAWSInstance_getPasswordData_trueToFalse
=== CONT  TestAccAWSInstance_getPasswordData_trueToFalse
--- PASS: TestAccAWSInstance_getPasswordData_trueToFalse (245.42s)
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws	245.912s

==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws -v -parallel 1 -run=TestAccAWSInstance_creditSpecification_unspecifiedDefaultsToStandard -timeout 120m
=== RUN   TestAccAWSInstance_creditSpecification_unspecifiedDefaultsToStandard
=== PAUSE TestAccAWSInstance_creditSpecification_unspecifiedDefaultsToStandard
=== CONT  TestAccAWSInstance_creditSpecification_unspecifiedDefaultsToStandard
--- PASS: TestAccAWSInstance_creditSpecification_unspecifiedDefaultsToStandard (165.95s)
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws	166.455s

==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws -v -parallel 1 -run=TestAccAWSInstance_creditSpecification_standardCpuCredits -timeout 120m
=== RUN   TestAccAWSInstance_creditSpecification_standardCpuCredits
=== PAUSE TestAccAWSInstance_creditSpecification_standardCpuCredits
=== RUN   TestAccAWSInstance_creditSpecification_standardCpuCredits_t2Tot3Taint
=== PAUSE TestAccAWSInstance_creditSpecification_standardCpuCredits_t2Tot3Taint
=== CONT  TestAccAWSInstance_creditSpecification_standardCpuCredits
--- PASS: TestAccAWSInstance_creditSpecification_standardCpuCredits (230.37s)
=== CONT  TestAccAWSInstance_creditSpecification_standardCpuCredits_t2Tot3Taint
--- PASS: TestAccAWSInstance_creditSpecification_standardCpuCredits_t2Tot3Taint (349.74s)
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws	580.603s

==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws -v -parallel 1 -run=TestAccAWSInstance_creditSpecification_unlimitedCpuCredits -timeout 120m
=== RUN   TestAccAWSInstance_creditSpecification_unlimitedCpuCredits
=== PAUSE TestAccAWSInstance_creditSpecification_unlimitedCpuCredits
=== RUN   TestAccAWSInstance_creditSpecification_unlimitedCpuCredits_t2Tot3Taint
=== PAUSE TestAccAWSInstance_creditSpecification_unlimitedCpuCredits_t2Tot3Taint
=== CONT  TestAccAWSInstance_creditSpecification_unlimitedCpuCredits
--- PASS: TestAccAWSInstance_creditSpecification_unlimitedCpuCredits (243.27s)
=== CONT  TestAccAWSInstance_creditSpecification_unlimitedCpuCredits_t2Tot3Taint
--- PASS: TestAccAWSInstance_creditSpecification_unlimitedCpuCredits_t2Tot3Taint (318.15s)
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws	561.907s

==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws -v -parallel 1 -run=TestAccAWSInstance_creditSpecification_unknownCpuCredits_t2 -timeout 120m
=== RUN   TestAccAWSInstance_creditSpecification_unknownCpuCredits_t2
=== PAUSE TestAccAWSInstance_creditSpecification_unknownCpuCredits_t2
=== CONT  TestAccAWSInstance_creditSpecification_unknownCpuCredits_t2
--- PASS: TestAccAWSInstance_creditSpecification_unknownCpuCredits_t2 (168.79s)
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws	169.309s

==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws -v -parallel 1 -run=TestAccAWSInstance_creditSpecification_unknownCpuCredits_t3 -timeout 120m
=== RUN   TestAccAWSInstance_creditSpecification_unknownCpuCredits_t3
=== PAUSE TestAccAWSInstance_creditSpecification_unknownCpuCredits_t3
=== CONT  TestAccAWSInstance_creditSpecification_unknownCpuCredits_t3
--- PASS: TestAccAWSInstance_creditSpecification_unknownCpuCredits_t3 (155.70s)
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws	156.204s

==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws -v -parallel 1 -run=TestAccAWSInstance_creditSpecification_updateCpuCredits -timeout 120m
=== RUN   TestAccAWSInstance_creditSpecification_updateCpuCredits
=== PAUSE TestAccAWSInstance_creditSpecification_updateCpuCredits
=== CONT  TestAccAWSInstance_creditSpecification_updateCpuCredits
--- PASS: TestAccAWSInstance_creditSpecification_updateCpuCredits (343.97s)
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws	344.492s

==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws -v -parallel 1 -run=TestAccAWSInstance_creditSpecification_isNotAppliedToNonBurstable -timeout 120m
=== RUN   TestAccAWSInstance_creditSpecification_isNotAppliedToNonBurstable
=== PAUSE TestAccAWSInstance_creditSpecification_isNotAppliedToNonBurstable
=== CONT  TestAccAWSInstance_creditSpecification_isNotAppliedToNonBurstable
--- PASS: TestAccAWSInstance_creditSpecification_isNotAppliedToNonBurstable (209.52s)
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws	210.026s

==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws -v -parallel 1 -run=TestAccAWSInstance_creditSpecificationT3_unspecifiedDefaultsToUnlimited -timeout 120m
=== RUN   TestAccAWSInstance_creditSpecificationT3_unspecifiedDefaultsToUnlimited
=== PAUSE TestAccAWSInstance_creditSpecificationT3_unspecifiedDefaultsToUnlimited
=== CONT  TestAccAWSInstance_creditSpecificationT3_unspecifiedDefaultsToUnlimited
--- PASS: TestAccAWSInstance_creditSpecificationT3_unspecifiedDefaultsToUnlimited (182.80s)
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws	183.302s

==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws -v -parallel 1 -run=TestAccAWSInstance_creditSpecificationT3_standardCpuCredits -timeout 120m
=== RUN   TestAccAWSInstance_creditSpecificationT3_standardCpuCredits
=== PAUSE TestAccAWSInstance_creditSpecificationT3_standardCpuCredits
=== CONT  TestAccAWSInstance_creditSpecificationT3_standardCpuCredits
--- PASS: TestAccAWSInstance_creditSpecificationT3_standardCpuCredits (254.13s)
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws	254.634s

==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws -v -parallel 1 -run=TestAccAWSInstance_creditSpecificationT3_unlimitedCpuCredits -timeout 120m
=== RUN   TestAccAWSInstance_creditSpecificationT3_unlimitedCpuCredits
=== PAUSE TestAccAWSInstance_creditSpecificationT3_unlimitedCpuCredits
=== CONT  TestAccAWSInstance_creditSpecificationT3_unlimitedCpuCredits
--- PASS: TestAccAWSInstance_creditSpecificationT3_unlimitedCpuCredits (268.60s)
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws	269.096s

==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws -v -parallel 1 -run=TestAccAWSInstance_creditSpecificationT3_updateCpuCredits -timeout 120m
=== RUN   TestAccAWSInstance_creditSpecificationT3_updateCpuCredits
=== PAUSE TestAccAWSInstance_creditSpecificationT3_updateCpuCredits
=== CONT  TestAccAWSInstance_creditSpecificationT3_updateCpuCredits
--- PASS: TestAccAWSInstance_creditSpecificationT3_updateCpuCredits (333.21s)
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws	333.704s

==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws -v -parallel 1 -run=TestAccAWSInstance_creditSpecification_standardCpuCredits_t2Tot3Taint -timeout 120m
=== RUN   TestAccAWSInstance_creditSpecification_standardCpuCredits_t2Tot3Taint
=== PAUSE TestAccAWSInstance_creditSpecification_standardCpuCredits_t2Tot3Taint
=== CONT  TestAccAWSInstance_creditSpecification_standardCpuCredits_t2Tot3Taint
--- PASS: TestAccAWSInstance_creditSpecification_standardCpuCredits_t2Tot3Taint (337.80s)
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws	338.311s

==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws -v -parallel 1 -run=TestAccAWSInstance_creditSpecification_unlimitedCpuCredits_t2Tot3Taint -timeout 120m
=== RUN   TestAccAWSInstance_creditSpecification_unlimitedCpuCredits_t2Tot3Taint
=== PAUSE TestAccAWSInstance_creditSpecification_unlimitedCpuCredits_t2Tot3Taint
=== CONT  TestAccAWSInstance_creditSpecification_unlimitedCpuCredits_t2Tot3Taint
--- PASS: TestAccAWSInstance_creditSpecification_unlimitedCpuCredits_t2Tot3Taint (328.50s)
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws	329.005s

==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws -v -parallel 1 -run=TestAccAWSInstance_disappears -timeout 120m
=== RUN   TestAccAWSInstance_disappears
=== PAUSE TestAccAWSInstance_disappears
=== CONT  TestAccAWSInstance_disappears
--- PASS: TestAccAWSInstance_disappears (197.03s)
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws	197.534s

==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws -v -parallel 1 -run=TestAccAWSInstance_UserData_EmptyStringToUnspecified -timeout 120m
=== RUN   TestAccAWSInstance_UserData_EmptyStringToUnspecified
=== PAUSE TestAccAWSInstance_UserData_EmptyStringToUnspecified
=== CONT  TestAccAWSInstance_UserData_EmptyStringToUnspecified
--- PASS: TestAccAWSInstance_UserData_EmptyStringToUnspecified (248.02s)
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws	248.530s

==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws -v -parallel 1 -run=TestAccAWSInstance_UserData_UnspecifiedToEmptyString -timeout 120m
=== RUN   TestAccAWSInstance_UserData_UnspecifiedToEmptyString
=== PAUSE TestAccAWSInstance_UserData_UnspecifiedToEmptyString
=== CONT  TestAccAWSInstance_UserData_UnspecifiedToEmptyString
--- PASS: TestAccAWSInstance_UserData_UnspecifiedToEmptyString (243.78s)
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws	244.281s

@ghost ghost mentioned this pull request Sep 20, 2019
Closed
@nywilken nywilken added regression Pertains to a degraded workflow resulting from an upstream patch or internal enhancement. bug Addresses a defect in current functionality. and removed regression Pertains to a degraded workflow resulting from an upstream patch or internal enhancement. labels Oct 2, 2019
@viggeh
Copy link

viggeh commented Dec 13, 2019

Thank you for your work!

Any chance to get some traction on this? This is something that we have run into more than once. I would love to get a proper fix in instead of having to do workarounds.

@bflad bflad self-assigned this Feb 12, 2020
@bflad bflad added the regression Pertains to a degraded workflow resulting from an upstream patch or internal enhancement. label Feb 12, 2020
@bflad bflad added this to the v2.49.0 milestone Feb 12, 2020
@bflad bflad removed the service/ec2 Issues and PRs that pertain to the ec2 service. label Feb 12, 2020
bflad
bflad approved these changes Feb 12, 2020
View reviewed changes
Copy link
Member

@bflad bflad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, thank you so much for this fix and associated testing, @jc-asdf 🚀

New test prior to fix:

--- FAIL: TestAccAWSLaunchConfiguration_withInstanceStoreAMI (13.84s)
    testing.go:640: Step 0 error: errors during apply:

        Error: Instance store backed AMIs do not provide a root device name - Use an EBS AMI

Output from acceptance testing:

--- PASS: TestAccAWSLaunchConfiguration_withSpotPrice (19.05s)
--- PASS: TestAccAWSLaunchConfiguration_withInstanceStoreAMI (20.40s)
--- PASS: TestAccAWSLaunchConfiguration_withBlockDevices (20.90s)
--- PASS: TestAccAWSLaunchConfiguration_withEncryption (21.66s)
--- PASS: TestAccAWSLaunchConfiguration_ebs_noDevice (21.67s)
--- PASS: TestAccAWSLaunchConfiguration_withIAMProfile (29.41s)
--- PASS: TestAccAWSLaunchConfiguration_encryptedRootBlockDevice (34.32s)
--- PASS: TestAccAWSLaunchConfiguration_basic (35.35s)
--- PASS: TestAccAWSLaunchConfiguration_userData (37.26s)
--- PASS: TestAccAWSLaunchConfiguration_updateEbsBlockDevices (37.48s)
--- PASS: TestAccAWSLaunchConfiguration_updateRootBlockDevice (39.25s)
--- PASS: TestAccAWSLaunchConfiguration_withVpcClassicLink (39.58s)

@bflad bflad merged commit d59c9f3 into hashicorp:master Feb 12, 2020
bflad added a commit that referenced this pull request Feb 12, 2020
@bflad
Update CHANGELOG for #9810
10c9ffb
bflad added a commit that referenced this pull request Feb 12, 2020
@bflad
Update CHANGELOG for #12009 and #9810
30aaaa3
@ghost
Copy link

ghost commented Feb 14, 2020

This has been released in version 2.49.0 of the Terraform AWS provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template for triage. Thanks!

@ghost
Copy link

ghost commented Mar 27, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!

@ghost ghost locked and limited conversation to collaborators Mar 27, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@bflad bflad bflad approved these changes

Assignees

@bflad bflad

Labels
bug Addresses a defect in current functionality. regression Pertains to a degraded workflow resulting from an upstream patch or internal enhancement. service/autoscaling Issues and PRs that pertain to the autoscaling service. size/M Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Milestone
v2.49.0
Development

Successfully merging this pull request may close these issues.

aws_launch_config fails with instance-store AMIs - new in 2.23.0
4 participants
@jc-asdf @viggeh @bflad @nywilken