Add defaults for ECS Task Definition health checks

[edtan]

This PR adds defaults for ECS Task Definition health checks. The defaults are documented at https://docs.aws.amazon.com/AmazonECS/latest/APIReference/API_HealthCheck.html.

Community Note

• Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
• Please do not leave "+1" comments, they generate extra noise for pull request followers and do not help prioritize the request

Closes #4730

Release note for CHANGELOG:

BUG FIXES:
* resource/resource_aws_ecs_task_definition: Add ECS Task Definition default health check parameters if not specified (#4730)

Output from acceptance testing:

$ make testacc TESTARGS='-run=TestAwsEcsContainerDefinitionsAreEquivalent*'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./... -v -parallel 20 -run=TestAwsEcsContainerDefinitionsAreEquivalent* -timeout 120m
?   	github.com/terraform-providers/terraform-provider-aws	[no test files]
=== RUN   TestAwsEcsContainerDefinitionsAreEquivalent_basic
--- PASS: TestAwsEcsContainerDefinitionsAreEquivalent_basic (0.00s)
=== RUN   TestAwsEcsContainerDefinitionsAreEquivalent_portMappings
--- PASS: TestAwsEcsContainerDefinitionsAreEquivalent_portMappings (0.00s)
=== RUN   TestAwsEcsContainerDefinitionsAreEquivalent_portMappingsIgnoreHostPort
2019/08/29 11:16:36 [DEBUG] Canonical definitions are not equal.
First: [{"essential":true,"image":"wordpress","name":"wordpress","portMappings":[{"containerPort":80,"hostPort":80}]}]
Second: [{"essential":true,"image":"wordpress","name":"wordpress","portMappings":[{"containerPort":80}]}]
--- PASS: TestAwsEcsContainerDefinitionsAreEquivalent_portMappingsIgnoreHostPort (0.00s)
=== RUN   TestAwsEcsContainerDefinitionsAreEquivalent_arrays
--- PASS: TestAwsEcsContainerDefinitionsAreEquivalent_arrays (0.00s)
=== RUN   TestAwsEcsContainerDefinitionsAreEquivalent_healthCheck
--- PASS: TestAwsEcsContainerDefinitionsAreEquivalent_healthCheck (0.00s)
=== RUN   TestAwsEcsContainerDefinitionsAreEquivalent_negative
2019/08/29 11:16:36 [DEBUG] Canonical definitions are not equal.
First: [{"cpu":10,"environment":[{"name":"EXAMPLE_NAME","value":"foobar"}],"essential":true,"image":"wordpress","memory":500,"name":"wordpress"}]
Second: [{"cpu":10,"essential":true,"image":"wordpress","memory":500,"name":"wordpress"}]
--- PASS: TestAwsEcsContainerDefinitionsAreEquivalent_negative (0.00s)
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws	0.024s

[zhelding]

Pull request #21306 has significantly refactored the AWS Provider codebase. As a result, most PRs opened prior to the refactor now have merge conflicts that must be resolved before proceeding.

Specifically, PR #21306 relocated the code for all AWS resources and data sources from a single aws directory to a large number of separate directories in internal/service, each corresponding to a particular AWS service. This separation of code has also allowed for us to simplify the names of underlying functions -- while still avoiding namespace collisions.

We recognize that many pull requests have been open for some time without yet being addressed by our maintainers. Therefore, we want to make it clear that resolving these conflicts in no way affects the prioritization of a particular pull request. Once a pull request has been prioritized for review, the necessary changes will be made by a maintainer -- either directly or in collaboration with the pull request author.

For a more complete description of this refactor, including examples of how old filepaths and function names correspond to their new counterparts: please refer to issue #20000.

For a quick guide on how to amend your pull request to resolve the merge conflicts resulting from this refactor and bring it in line with our new code patterns: please refer to our Service Package Refactor Pull Request Guide.