Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Handle write-only properties #86

Merged
merged 8 commits into from
Aug 5, 2021
Merged

Handle write-only properties #86

merged 8 commits into from
Aug 5, 2021

Commits on Aug 5, 2021

  1. Add and use 'CopyValueAtPath'.

    @ewbankkit
    ewbankkit committed Aug 5, 2021
    Configuration menu
    Copy the full SHA
    513164f View commit details
    Browse the repository at this point in the history

  2. Add KMS Key resource.

    @ewbankkit
    ewbankkit committed Aug 5, 2021
    Configuration menu
    Copy the full SHA
    212f499 View commit details
    Browse the repository at this point in the history

  3. Better error message when request status is FAILED.

    @ewbankkit
    ewbankkit committed Aug 5, 2021
    Configuration menu
    Copy the full SHA
    b3c905c View commit details
    Browse the repository at this point in the history

  4. More 'CopyValueAtPath' unit tests.

    @ewbankkit
    ewbankkit committed Aug 5, 2021
    Configuration menu
    Copy the full SHA
    408f223 View commit details
    Browse the repository at this point in the history

  5. Handle JSON strings (e.g. IAM policies).

    @ewbankkit
    ewbankkit committed Aug 5, 2021
    Configuration menu
    Copy the full SHA
    98fe540 View commit details
    Browse the repository at this point in the history

  6. Ignore object fields which are in the CloudFormation resource model b… 

    …ut not in the Terraform schema.
    @ewbankkit
    ewbankkit committed Aug 5, 2021
    Configuration menu
    Copy the full SHA
    afe5375 View commit details
    Browse the repository at this point in the history

  7. Prevent crash in Terraform Core for empty sets: 

    panic: must not call SetVal with empty slice

goroutine 68 [running]:
github.com/zclconf/go-cty/cty.SetVal(0x47ed998, 0x0, 0x0, 0x47ed998, 0x0, 0x0, 0x0)
        /Users/distiller/go/pkg/mod/github.com/zclconf/go-cty@v1.9.0/cty/value_init.go:267 +0x865
github.com/hashicorp/terraform/internal/command/format.(*blockBodyDiffPrinter).writeNestedAttrDiff(0xc00085d2a8, 0xc0005a5610, 0x4, 0xc0006d12c0, 0x3748ad0, 0xc0004977d0, 0x0, 0x0, 0x3748ad0, 0xc000497c60, ...)
        /Users/distiller/project/project/internal/command/format/diff.go:615 +0x246a
github.com/hashicorp/terraform/internal/command/format.(*blockBodyDiffPrinter).writeAttrDiff(0xc0006492a8, 0xc0005a5610, 0x4, 0xc000932ec0, 0x3748ad0, 0xc0004977d0, 0x0, 0x0, 0x3748ad0, 0xc000497c60, ...)
        /Users/distiller/project/project/internal/command/format/diff.go:473 +0x7a7
github.com/hashicorp/terraform/internal/command/format.(*blockBodyDiffPrinter).writeAttrsDiff(0xc00085d2a8, 0xc000956060, 0x3748a98, 0xc000497f70, 0x2f41440, 0xc00076e1b0, 0x3748a98, 0xc0007e3210, 0x2f41440, 0xc00076e450, ...)
        /Users/distiller/project/project/internal/command/format/diff.go:434 +0x685
...
    @ewbankkit
    ewbankkit committed Aug 5, 2021
    Configuration menu
    Copy the full SHA
    e3ab4aa View commit details
    Browse the repository at this point in the history

  8. Test aws_kms_key.

    @ewbankkit
    ewbankkit committed Aug 5, 2021
    Configuration menu
    Copy the full SHA
    e75ef0b View commit details
    Browse the repository at this point in the history