Apply suggestions from code review

hashicorp · Apr 27, 2023 · c4af184 · c4af184
1 parent 9776e1a
commit c4af184
Show file tree

Hide file tree

Showing 3 changed files with 4 additions and 3 deletions.
diff --git a/docs/data-sources/access_package_catalog_role.md b/docs/data-sources/access_package_catalog_role.md
@@ -26,7 +26,7 @@ data "azuread_access_package_catalog_role" "example" {
 *Look up by object ID*
 ```terraform
 data "azuread_access_package_catalog_role" "example" {
-  object_id = "ae79f266-94d4-4dab-b730-feca7e132178"
+  object_id = "00000000-0000-0000-0000-000000000000"
 }
 ```
 

diff --git a/internal/services/identitygovernance/access_package_catalog_role_assignment_resource.go b/internal/services/identitygovernance/access_package_catalog_role_assignment_resource.go
@@ -24,7 +24,7 @@ func accessPackageCatalogRoleAssignmentResource() *schema.Resource {
 	return &schema.Resource{
 		CreateContext: accessPackageCatalogRoleAssignmentResourceCreate,
 		ReadContext:   accessPackageCatalogRoleAssignmentResourceRead,
-		DeleteContext: accessPackageCatalogRoleRoleAssignmentResourceDelete,
+		DeleteContext: accessPackageCatalogRoleAssignmentResourceDelete,
 
 		Timeouts: &schema.ResourceTimeout{
 			Create: schema.DefaultTimeout(5 * time.Minute),
@@ -117,7 +117,7 @@ func accessPackageCatalogRoleAssignmentResourceRead(ctx context.Context, d *sche
 	return nil
 }
 
-func accessPackageCatalogRoleRoleAssignmentResourceDelete(ctx context.Context, d *schema.ResourceData, meta interface{}) diag.Diagnostics {
+func accessPackageCatalogRoleAssignmentResourceDelete(ctx context.Context, d *schema.ResourceData, meta interface{}) diag.Diagnostics {
 	client := meta.(*clients.Client).IdentityGovernance.AccessPackageCatalogRoleAssignmentsClient
 
 	if _, err := client.Delete(ctx, d.Id()); err != nil {

diff --git a/internal/services/identitygovernance/access_package_catalog_role_assignment_resource_test.go b/internal/services/identitygovernance/access_package_catalog_role_assignment_resource_test.go
@@ -31,6 +31,7 @@ func TestAccAccessPackageCatalogRoleAssignmentResource_basic(t *testing.T) {
 				check.That(data.ResourceName).Key("role_id").Exists(),
 			),
 		},
+		data.ImportStep(),
 	})
 }