Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix regression: writeback configuration should be omitted on creation #1070

Merged
merged 1 commit into from
Apr 17, 2023
Merged

Fix regression: writeback configuration should be omitted on creation #1070

merged 1 commit into from
Apr 17, 2023

Conversation

manicminer
Copy link
Member

@manicminer manicminer commented Apr 17, 2023 •
edited

Writeback configuration should be omitted on creation instead of using the default value, and unsetting onpremises_group_type should cause a ForceNew

Fixes: #1067

@manicminer
Fix regression: writeback configuration should be omitted on creation…
f3bdbc9 
… instead of using the default value, unsetting onpremises_group_type should cause a ForceNew
@manicminer manicminer requested a review from a team April 17, 2023 21:15
catriona-m
catriona-m approved these changes Apr 17, 2023
View reviewed changes
Copy link
Member

@catriona-m catriona-m left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@manicminer manicminer mentioned this pull request Apr 17, 2023
Closed
@manicminer manicminer added this to the v2.37.1 milestone Apr 17, 2023
katbyte
katbyte approved these changes Apr 17, 2023
View reviewed changes
Copy link
Collaborator

@katbyte katbyte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🌩️

@manicminer
Copy link
Member Author

Test results

Screenshot 2023-04-17 at 22 33 09

@manicminer manicminer merged commit f071634 into main Apr 17, 2023
7 checks passed
@manicminer manicminer deleted the bugfix/writeback-regression branch April 17, 2023 22:02
manicminer added a commit that referenced this pull request Apr 17, 2023
@manicminer
Changelog for #1070
f41b532
@github-actions
Copy link

This functionality has been released in v2.37.1 of the Terraform Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@audunsolemdal
Copy link
Contributor

I had already applied this change to quite a few groups in 2.37.0, and I would like the groups not to be recreated as it would cause some extra work in fixing broken role assignments

Is it possible to reset the onpremsies_group_type value to null without recreating the group, via Azure Powershell for instance?

adding ignore_changes is an option, but I consider it suboptimal

@manicminer
Copy link
Member Author

@audunsolemdal Unfortunately it doesn't seem to be possible to unset this field via Azure Portal or PowerShell. This is an API bug that will hopefully be fixed at some point, which will enable us to remove the conditional ForceNew enforcement for this property. In the meantime, the best workaround is to allow Terraform to recreate the group, or to use the ignore_changes meta property to suppress this diff,

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 18, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@katbyte katbyte katbyte approved these changes

@catriona-m catriona-m catriona-m approved these changes

Assignees
No one assigned
Labels
bug regression size/S
Projects
None yet
Milestone
v2.37.1
Development

Successfully merging this pull request may close these issues.

azuread_group onpremises_group_type change appears during terraform plan even if writeback is disabled
4 participants
@manicminer @audunsolemdal @katbyte @catriona-m