Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove Workaround for US Gov Bug #987

Merged
merged 5 commits into from
Jan 30, 2023
Merged

Conversation

MarkDordoy
Copy link
Contributor

@MarkDordoy MarkDordoy commented Jan 25, 2023

Remove the workaround as the bug is now resolved. This was confirmed to me by Microsoft in a support ticket and I've also no longer been able to reproduce the issue using V1.0 of the API.

PR change reverses the use of the beta endpoint.

Original PR to fix bug can be found here #936

@manicminer manicminer added bug env/usgovernment Issue affects this environment labels Jan 25, 2023
@manicminer manicminer added this to the v2.35.0 milestone Jan 25, 2023
@dlwyatt
Copy link

dlwyatt commented Jan 25, 2023

TFW you spend all your time on github enterprise, then "approve" a PR without realizing it's someone else's repo on github.com 🤣

@manicminer
Copy link
Member

@dlwyatt Extra eyes are always welcome :)

@manicminer
Copy link
Member

manicminer commented Jan 30, 2023

Thanks for rebasing. Since we didn't have a release last week, we'll bump this forward to this week.

@manicminer manicminer modified the milestones: v2.35.0, v2.34.0 Jan 30, 2023
@manicminer manicminer merged commit 02942df into hashicorp:main Jan 30, 2023
manicminer added a commit that referenced this pull request Jan 30, 2023
@github-actions
Copy link

This functionality has been released in v2.34.0 of the Terraform Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active contributions.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 19, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug env/usgovernment Issue affects this environment size/XS
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants