Bug Fix for US Gov cloud current issue #936
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Moved to hamilton SDK version 0.52.0, which had a breaking change on DirectoryObject.ID
manicminer
approved these changes
Dec 1, 2022
|
This functionality has been released in v2.31.0 of the Terraform Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you! |
|
I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active contributions. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Microsoft US Gov cloud has an issue with the application Template: instantiate API call. They are actively working on fixing the bug, but the fix is not expected until February 2023.
The bug is intermittent, however when it occurs you can end up with multiple app registrations and Service Principals, all with the same name. The bug under the hood shows itself in the form of a 504 status code (timeout) and the Azure Library (Hamilton) performs a retry. Eventually that 504 call will complete and you end up with Mutiple applications created. This bug does not exist on the beta API.
This PR will place anyone using the environment
MsGraphUSGovL4Endpointonto the beta endpoint just for the application templates client. The response model changes slightly going to beta so this PR also accommodates for this.This PR required manicminer/hamilton#198 to be merged and released which has a breaking change regarding the DirectoryObject ID struct field. This has been replaced with a function of
.ID()which returns the Id regardless of objectID or Id return response from the Graph API