Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for azuread_authentication_strength_policy #1171

Merged
merged 4 commits into from
Oct 20, 2023

Conversation

alexwilcox9
Copy link
Contributor

@alexwilcox9 alexwilcox9 commented Aug 14, 2023

Adding a new resource azuread_authentication_strength_policy and adding a new attribute in azuread_conditional_access_policy for the new resource.

Depends on manicminer/hamilton#257

@alexwilcox9 alexwilcox9 force-pushed the authstrengthpolicy branch 5 times, most recently from bd2d282 to dff78cf Compare August 15, 2023 10:40
@alexwilcox9 alexwilcox9 marked this pull request as ready for review August 15, 2023 10:40
@manicminer
Copy link
Member

Closes #1185

@pmca31
Copy link

pmca31 commented Oct 4, 2023

closes #944

@manicminer manicminer linked an issue Oct 4, 2023 that may be closed by this pull request
@manicminer manicminer added this to the v2.44.0 milestone Oct 20, 2023
Copy link
Member

@manicminer manicminer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this @alexwilcox9 and for keeping the branch updated! I've made some updates to align with recent additions like the pluginsdk package, renamed authentication_strength_id to authentication_strength_policy_id, and made a couple additional fixes to the flatten/expand functions. Tests are now passing and this looks good to merge, thanks again!

Screenshot 2023-10-20 at 03 34 58

(failure is unrelated)

@manicminer manicminer merged commit 8ea1129 into hashicorp:main Oct 20, 2023
18 checks passed
manicminer added a commit that referenced this pull request Oct 20, 2023
dduportal pushed a commit to jenkins-infra/azure that referenced this pull request Oct 25, 2023
<Actions>
<action
id="c2aadc6326b4b0bc58df11ee286b0f67ccdb5888bd77f391e6473570113337ec">
        <h3>Bump Terraform `azuread` provider version</h3>
<details
id="1d9343c012f5434ac9fe8a98135bae3667b399259be16d9b14302ea3bd424a24">
            <summary>Update Terraform lock file</summary>
<p>&#34;hashicorp/azuread&#34; updated from &#34;2.43.0&#34; to
&#34;2.44.0&#34; in file &#34;.terraform.lock.hcl&#34;</p>
            <details>
                <summary>2.44.0</summary>
<pre>Changelog retrieved
from:&#xA;&#x9;https://github.com/hashicorp/terraform-provider-azuread/releases/tag/v2.44.0&#xA;*
Developer Note: the Typed Resource SDK, as also used in the AzureRM
provider, is now the preferred way of introducing new resources
([#1188](https://github.com/hashicorp/terraform-provider-azuread/issues/1188))&#xA;&#xA;FEATURES:&#xA;&#xA;*
**New Resource:** `azuread_application_api_access`
([#1214](https://github.com/hashicorp/terraform-provider-azuread/issues/1214))&#xA;*
**New Resource:** `azuread_application_app_role`
([#1214](https://github.com/hashicorp/terraform-provider-azuread/issues/1214))&#xA;*
**New Resource:** `azuread_application_fallback_public_client`
([#1214](https://github.com/hashicorp/terraform-provider-azuread/issues/1214))&#xA;*
**New Resource:** `azuread_application_from_template`
([#1214](https://github.com/hashicorp/terraform-provider-azuread/issues/1214))&#xA;*
**New Resource:** `azuread_application_identifier_uri`
([#1214](https://github.com/hashicorp/terraform-provider-azuread/issues/1214))&#xA;*
**New Resource:** `azuread_application_known_clients`
([#1214](https://github.com/hashicorp/terraform-provider-azuread/issues/1214))&#xA;*
**New Resource:** `azuread_application_owner`
([#1214](https://github.com/hashicorp/terraform-provider-azuread/issues/1214))&#xA;*
**New Resource:** `azuread_application_permission_scope
([#1214](https://github.com/hashicorp/terraform-provider-azuread/issues/1214))`&#xA;*
**New Resource:** `azuread_application_redirect_uris`
([#1214](https://github.com/hashicorp/terraform-provider-azuread/issues/1214))&#xA;*
**New Resource:** `azuread_application_registration`
([#1214](https://github.com/hashicorp/terraform-provider-azuread/issues/1214))&#xA;*
**New Resource:** `azuread_authentication_strength_policy`
([#1171](https://github.com/hashicorp/terraform-provider-azuread/issues/1171))&#xA;&#xA;ENHANCEMENTS:&#xA;&#xA;*
`data.azuread_application` - export the `client_id` attribute, deprecate
the `application_id` attribute
([#1214](https://github.com/hashicorp/terraform-provider-azuread/issues/1214))&#xA;*
`data.azuread_service_principal` - support for the `client_id` property,
deprecate the `application_id` property
([#1214](https://github.com/hashicorp/terraform-provider-azuread/issues/1214))&#xA;*
`data.azuread_service_principals` - support for the `client_ids`
property, deprecate the `application_ids` property
([#1214](https://github.com/hashicorp/terraform-provider-azuread/issues/1214))&#xA;*
`data.azuread_service_principals` - export the `client_id` attribute in
the `service_principals` block, deprecate the `application_id` attribute
([#1214](https://github.com/hashicorp/terraform-provider-azuread/issues/1214))&#xA;*
`azuread_application` - export the `client_id` attribute, deprecate the
`application_id` attribute
([#1214](https://github.com/hashicorp/terraform-provider-azuread/issues/1214))&#xA;*
`azuread_application_federated_identity_credential` - support for the
`application_id` property, deprecate the `application_object_id`
property
([#1214](https://github.com/hashicorp/terraform-provider-azuread/issues/1214))&#xA;*
`azuread_application_certificate` - support for the `application_id`
property, deprecate the `application_object_id` property
([#1214](https://github.com/hashicorp/terraform-provider-azuread/issues/1214))&#xA;*
`azuread_application_password` - support for the `application_id`
property, deprecate the `application_object_id` property
([#1214](https://github.com/hashicorp/terraform-provider-azuread/issues/1214))&#xA;*
`azuread_application_pre_authorized` - support for the `application_id`
property, deprecate the `application_object_id` property
([#1214](https://github.com/hashicorp/terraform-provider-azuread/issues/1214))&#xA;*
`azuread_service_principal` - support for the `client_id` property,
deprecate the `application_id` property
([#1214](https://github.com/hashicorp/terraform-provider-azuread/issues/1214))&#xA;*
`azuread_conditional_access_policy` - support for the
`authentication_strength_policy_id` property in the `grant_controls`
block [GH_1171]&#xA;&#xA;BUG FIXES:&#xA;&#xA;* `azuread_group_member` -
resolve a bug when refreshing state if the group is missing
([#1198](https://github.com/hashicorp/terraform-provider-azuread/issues/1198))&#xA;&#xA;&#xA;</pre>
            </details>
            <details>
                <summary>2.44.1</summary>
<pre>Changelog retrieved
from:&#xA;&#x9;https://github.com/hashicorp/terraform-provider-azuread/releases/tag/v2.44.1&#xA;BUG
FIXES:&#xA;&#xA;* `azuread_application_certificate` - work around an
unexpected diff with the `application_object_id` property
([#1221](https://github.com/hashicorp/terraform-provider-azuread/issues/1221))&#xA;*
`azuread_application_federated_identity_credential` - work around an
unexpected diff with the `application_object_id` property
([#1221](https://github.com/hashicorp/terraform-provider-azuread/issues/1221))&#xA;*
`azuread_application_password` - work around an unexpected diff with the
`application_object_id` property
([#1221](https://github.com/hashicorp/terraform-provider-azuread/issues/1221))&#xA;*
`azuread_application_pre_authorized` - work around an unexpected diff
with the `application_object_id` property
([#1221](https://github.com/hashicorp/terraform-provider-azuread/issues/1221))&#xA;&#xA;&#xA;</pre>
            </details>
        </details>
    </action>
</Actions>

---

<table>
  <tr>
    <td width="77">
<img src="https://www.updatecli.io/images/updatecli.png" alt="Updatecli
logo" width="50" height="50">
    </td>
    <td>
      <p>
Created automatically by <a
href="https://www.updatecli.io/">Updatecli</a>
      </p>
      <details><summary>Options:</summary>
        <br />
<p>Most of Updatecli configuration is done via <a
href="https://www.updatecli.io/docs/prologue/quick-start/">its
manifest(s)</a>.</p>
        <ul>
<li>If you close this pull request, Updatecli will automatically reopen
it, the next time it runs.</li>
<li>If you close this pull request and delete the base branch, Updatecli
will automatically recreate it, erasing all previous commits made.</li>
        </ul>
        <p>
Feel free to report any issues at <a
href="https://github.com/updatecli/updatecli/issues">github.com/updatecli/updatecli</a>.<br
/>
If you find this tool useful, do not hesitate to star <a
href="https://github.com/updatecli/updatecli/stargazers">our GitHub
repository</a> as a sign of appreciation, and/or to tell us directly on
our <a
href="https://matrix.to/#/#Updatecli_community:gitter.im">chat</a>!
        </p>
      </details>
    </td>
  </tr>
</table>

---------

Co-authored-by: Jenkins Infra Bot (updatecli) <60776566+jenkins-infra-bot@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants