New resource: azurerm_virtual_hub_bgp_connection (#8959)

azurerm/internal/services/network/client/client.go

@@ -41,6 +41,7 @@ type Client struct {
 	ServiceTagsClient                    *network.ServiceTagsClient
 	SubnetsClient                        *network.SubnetsClient
 	NatGatewayClient                     *network.NatGatewaysClient
+	VirtualHubBgpConnectionClient        *network.VirtualHubBgpConnectionClient
 	VirtualHubIPClient                   *network.VirtualHubIPConfigurationClient
 	VnetGatewayConnectionsClient         *network.VirtualNetworkGatewayConnectionsClient
 	VnetGatewayClient                    *network.VirtualNetworkGatewaysClient
@@ -174,6 +175,9 @@ func NewClient(o *common.ClientOptions) *Client {
 	SubnetsClient := network.NewSubnetsClientWithBaseURI(o.ResourceManagerEndpoint, o.SubscriptionId)
 	o.ConfigureClient(&SubnetsClient.Client, o.ResourceManagerAuthorizer)
 
+	VirtualHubBgpConnectionClient := network.NewVirtualHubBgpConnectionClientWithBaseURI(o.ResourceManagerEndpoint, o.SubscriptionId)
+	o.ConfigureClient(&VirtualHubBgpConnectionClient.Client, o.ResourceManagerAuthorizer)
+
 	VirtualHubIPClient := network.NewVirtualHubIPConfigurationClientWithBaseURI(o.ResourceManagerEndpoint, o.SubscriptionId)
 	o.ConfigureClient(&VirtualHubIPClient.Client, o.ResourceManagerAuthorizer)
 
@@ -245,6 +249,7 @@ func NewClient(o *common.ClientOptions) *Client {
 		ServiceTagsClient:                    &ServiceTagsClient,
 		SubnetsClient:                        &SubnetsClient,
 		NatGatewayClient:                     &NatGatewayClient,
+		VirtualHubBgpConnectionClient:        &VirtualHubBgpConnectionClient,
 		VirtualHubIPClient:                   &VirtualHubIPClient,
 		VnetGatewayConnectionsClient:         &VnetGatewayConnectionsClient,
 		VnetGatewayClient:                    &VnetGatewayClient,

azurerm/internal/services/network/parse/virtual_hub_bgp_connection.go

@@ -0,0 +1,38 @@
+package parse
+
+import (
+	"fmt"
+
+	"github.com/terraform-providers/terraform-provider-azurerm/azurerm/helpers/azure"
+)
+
+type VirtualHubBgpConnectionId struct {
+	ResourceGroup  string
+	VirtualHubName string
+	Name           string
+}
+
+func VirtualHubBgpConnectionID(input string) (*VirtualHubBgpConnectionId, error) {
+	id, err := azure.ParseAzureResourceID(input)
+	if err != nil {
+		return nil, fmt.Errorf("parsing virtualHubBgpConnection ID %q: %+v", input, err)
+	}
+
+	virtualHubBgpConnection := VirtualHubBgpConnectionId{
+		ResourceGroup: id.ResourceGroup,
+	}
+
+	if virtualHubBgpConnection.VirtualHubName, err = id.PopSegment("virtualHubs"); err != nil {
+		return nil, err
+	}
+
+	if virtualHubBgpConnection.Name, err = id.PopSegment("bgpConnections"); err != nil {
+		return nil, err
+	}
+
+	if err := id.ValidateNoEmptySegments(input); err != nil {
+		return nil, err
+	}
+
+	return &virtualHubBgpConnection, nil
+}

azurerm/internal/services/network/parse/virtual_hub_bgp_connection_test.go

@@ -0,0 +1,77 @@
+package parse
+
+import (
+	"testing"
+)
+
+func TestVirtualHubBgpConnectionID(t *testing.T) {
+	testData := []struct {
+		Name     string
+		Input    string
+		Expected *VirtualHubBgpConnectionId
+	}{
+		{
+			Name:     "Empty",
+			Input:    "",
+			Expected: nil,
+		},
+		{
+			Name:     "No Resource Groups Segment",
+			Input:    "/subscriptions/00000000-0000-0000-0000-000000000000",
+			Expected: nil,
+		},
+		{
+			Name:     "No Resource Groups Value",
+			Input:    "/subscriptions/00000000-0000-0000-0000-000000000000/resourceGroups/",
+			Expected: nil,
+		},
+		{
+			Name:     "Resource Group ID",
+			Input:    "/subscriptions/00000000-0000-0000-0000-000000000000/resourceGroups/foo/",
+			Expected: nil,
+		},
+		{
+			Name:     "Missing VirtualHubBgpConnection Value",
+			Input:    "/subscriptions/00000000-0000-0000-0000-000000000000/resourceGroups/resourceGroup1/providers/Microsoft.Network/virtualHubs/virtualHub1/bgpConnections",
+			Expected: nil,
+		},
+		{
+			Name:  "VirtualHubBgpConnection ID",
+			Input: "/subscriptions/00000000-0000-0000-0000-000000000000/resourceGroups/resourceGroup1/providers/Microsoft.Network/virtualHubs/virtualHub1/bgpConnections/connection1",
+			Expected: &VirtualHubBgpConnectionId{
+				ResourceGroup:  "resourceGroup1",
+				VirtualHubName: "virtualHub1",
+				Name:           "connection1",
+			},
+		},
+		{
+			Name:     "Wrong Casing",
+			Input:    "/subscriptions/00000000-0000-0000-0000-000000000000/resourceGroups/resourceGroup1/providers/Microsoft.Network/virtualHubs/virtualHub1/BgpConnections/connection1",
+			Expected: nil,
+		},
+	}
+
+	for _, v := range testData {
+		t.Logf("[DEBUG] Testing %q..", v.Name)
+
+		actual, err := VirtualHubBgpConnectionID(v.Input)
+		if err != nil {
+			if v.Expected == nil {
+				continue
+			}
+			t.Fatalf("Expected a value but got an error: %s", err)
+		}
+
+		if actual.ResourceGroup != v.Expected.ResourceGroup {
+			t.Fatalf("Expected %q but got %q for ResourceGroup", v.Expected.ResourceGroup, actual.ResourceGroup)
+		}
+
+		if actual.VirtualHubName != v.Expected.VirtualHubName {
+			t.Fatalf("Expected %q but got %q for VirtualHubName", v.Expected.VirtualHubName, actual.VirtualHubName)
+		}
+
+		if actual.Name != v.Expected.Name {
+			t.Fatalf("Expected %q but got %q for Name", v.Expected.Name, actual.Name)
+		}
+	}
+}

azurerm/internal/services/network/registration.go

@@ -109,6 +109,7 @@ func (r Registration) SupportedResources() map[string]*schema.Resource {
 		"azurerm_subnet_nat_gateway_association":                                         resourceArmSubnetNatGatewayAssociation(),
 		"azurerm_subnet":                                                                 resourceArmSubnet(),
 		"azurerm_virtual_hub":                                                            resourceArmVirtualHub(),
+		"azurerm_virtual_hub_bgp_connection":                                             resourceArmVirtualHubBgpConnection(),
 		"azurerm_virtual_hub_connection":                                                 resourceArmVirtualHubConnection(),
 		"azurerm_virtual_hub_ip":                                                         resourceArmVirtualHubIP(),
 		"azurerm_virtual_hub_route_table":                                                resourceArmVirtualHubRouteTable(),

azurerm/internal/services/network/tests/virtual_hub_bgp_connection_resource_test.go

@@ -0,0 +1,182 @@
+package tests
+
+import (
+	"fmt"
+	"testing"
+
+	"github.com/hashicorp/terraform-plugin-sdk/helper/resource"
+	"github.com/hashicorp/terraform-plugin-sdk/terraform"
+	"github.com/terraform-providers/terraform-provider-azurerm/azurerm/internal/acceptance"
+	"github.com/terraform-providers/terraform-provider-azurerm/azurerm/internal/clients"
+	"github.com/terraform-providers/terraform-provider-azurerm/azurerm/internal/services/network/parse"
+	"github.com/terraform-providers/terraform-provider-azurerm/azurerm/utils"
+)
+
+func TestAccAzureRMVirtualHubBgpConnection_basic(t *testing.T) {
+	data := acceptance.BuildTestData(t, "azurerm_virtual_hub_bgp_connection", "test")
+	resource.ParallelTest(t, resource.TestCase{
+		PreCheck:     func() { acceptance.PreCheck(t) },
+		Providers:    acceptance.SupportedProviders,
+		CheckDestroy: testCheckAzureRMVirtualHubBgpConnectionDestroy,
+		Steps: []resource.TestStep{
+			{
+				Config: testAccAzureRMVirtualHubBgpConnection_basic(data),
+				Check: resource.ComposeTestCheckFunc(
+					testCheckAzureRMVirtualHubBgpConnectionExists(data.ResourceName),
+				),
+			},
+			data.ImportStep(),
+		},
+	})
+}
+
+func TestAccAzureRMVirtualHubBgpConnection_requiresImport(t *testing.T) {
+	data := acceptance.BuildTestData(t, "azurerm_virtual_hub_bgp_connection", "test")
+	resource.ParallelTest(t, resource.TestCase{
+		PreCheck:     func() { acceptance.PreCheck(t) },
+		Providers:    acceptance.SupportedProviders,
+		CheckDestroy: testCheckAzureRMVirtualHubBgpConnectionDestroy,
+		Steps: []resource.TestStep{
+			{
+				Config: testAccAzureRMVirtualHubBgpConnection_basic(data),
+				Check: resource.ComposeTestCheckFunc(
+					testCheckAzureRMVirtualHubBgpConnectionExists(data.ResourceName),
+				),
+			},
+			data.RequiresImportErrorStep(testAccAzureRMVirtualHubBgpConnection_requiresImport),
+		},
+	})
+}
+
+func testCheckAzureRMVirtualHubBgpConnectionExists(resourceName string) resource.TestCheckFunc {
+	return func(s *terraform.State) error {
+		client := acceptance.AzureProvider.Meta().(*clients.Client).Network.VirtualHubBgpConnectionClient
+		ctx := acceptance.AzureProvider.Meta().(*clients.Client).StopContext
+
+		rs, ok := s.RootModule().Resources[resourceName]
+		if !ok {
+			return fmt.Errorf("virtualHubBgpConnection not found: %s", resourceName)
+		}
+
+		id, err := parse.VirtualHubBgpConnectionID(rs.Primary.ID)
+		if err != nil {
+			return err
+		}
+
+		if resp, err := client.Get(ctx, id.ResourceGroup, id.VirtualHubName, id.Name); err != nil {
+			if utils.ResponseWasNotFound(resp.Response) {
+				return fmt.Errorf("bad: Network VirtualHubBgpConnection %q does not exist", id.Name)
+			}
+
+			return fmt.Errorf("bad: Get on Network.VirtualHubBgpConnectionClient: %+v", err)
+		}
+
+		return nil
+	}
+}
+
+func testCheckAzureRMVirtualHubBgpConnectionDestroy(s *terraform.State) error {
+	client := acceptance.AzureProvider.Meta().(*clients.Client).Network.VirtualHubBgpConnectionClient
+	ctx := acceptance.AzureProvider.Meta().(*clients.Client).StopContext
+
+	for _, rs := range s.RootModule().Resources {
+		if rs.Type != "azurerm_virtual_hub_bgp_connection" {
+			continue
+		}
+
+		id, err := parse.VirtualHubBgpConnectionID(rs.Primary.ID)
+		if err != nil {
+			return err
+		}
+
+		if resp, err := client.Get(ctx, id.ResourceGroup, id.VirtualHubName, id.Name); err != nil {
+			if !utils.ResponseWasNotFound(resp.Response) {
+				return fmt.Errorf("bad: Get on Network.VirtualHubBgpConnectionClient: %+v", err)
+			}
+		}
+
+		return nil
+	}
+
+	return nil
+}
+
+func testAccAzureRMVirtualHubBgpConnection_template(data acceptance.TestData) string {
+	return fmt.Sprintf(`
+provider "azurerm" {
+  features {}
+}
+
+resource "azurerm_resource_group" "test" {
+  name     = "acctestRG-VHub-%d"
+  location = "%s"
+}
+
+resource "azurerm_virtual_hub" "test" {
+  name                = "acctest-VHub-%d"
+  resource_group_name = azurerm_resource_group.test.name
+  location            = azurerm_resource_group.test.location
+  sku                 = "Standard"
+}
+
+resource "azurerm_public_ip" "test" {
+  name                = "acctest-PIP-%d"
+  location            = azurerm_resource_group.test.location
+  resource_group_name = azurerm_resource_group.test.name
+  allocation_method   = "Dynamic"
+}
+
+resource "azurerm_virtual_network" "test" {
+  name                = "acctest-VNet-%d"
+  address_space       = ["10.5.0.0/16"]
+  location            = azurerm_resource_group.test.location
+  resource_group_name = azurerm_resource_group.test.name
+}
+
+resource "azurerm_subnet" "test" {
+  name                 = "acctest-Subnet-%d"
+  resource_group_name  = azurerm_resource_group.test.name
+  virtual_network_name = azurerm_virtual_network.test.name
+  address_prefix       = "10.5.1.0/24"
+}
+
+resource "azurerm_virtual_hub_ip" "test" {
+  name                         = "acctest-VHub-IP-%d"
+  virtual_hub_id               = azurerm_virtual_hub.test.id
+  private_ip_address           = "10.5.1.18"
+  private_ip_allocation_method = "Static"
+  public_ip_address_id         = azurerm_public_ip.test.id
+  subnet_id                    = azurerm_subnet.test.id
+}
+`, data.RandomInteger, data.Locations.Primary, data.RandomInteger, data.RandomInteger, data.RandomInteger, data.RandomInteger, data.RandomInteger)
+}
+
+func testAccAzureRMVirtualHubBgpConnection_basic(data acceptance.TestData) string {
+	template := testAccAzureRMVirtualHubBgpConnection_template(data)
+	return fmt.Sprintf(`
+%s
+
+resource "azurerm_virtual_hub_bgp_connection" "test" {
+  name           = "acctest-VHub-BgpConnection-%d"
+  virtual_hub_id = azurerm_virtual_hub.test.id
+  peer_asn       = 65514
+  peer_ip        = "169.254.21.5"
+
+  depends_on = [azurerm_virtual_hub_ip.test]
+}
+`, template, data.RandomInteger)
+}
+
+func testAccAzureRMVirtualHubBgpConnection_requiresImport(data acceptance.TestData) string {
+	config := testAccAzureRMVirtualHubBgpConnection_basic(data)
+	return fmt.Sprintf(`
+%s
+
+resource "azurerm_virtual_hub_bgp_connection" "import" {
+  name           = azurerm_virtual_hub_bgp_connection.test.name
+  virtual_hub_id = azurerm_virtual_hub_bgp_connection.test.virtual_hub_id
+  peer_asn       = azurerm_virtual_hub_bgp_connection.test.peer_asn
+  peer_ip        = azurerm_virtual_hub_bgp_connection.test.peer_ip
+}
+`, config)
+}