azurerm_kubernetes_cluster: Expose automatic_channel_upgrade

[jackbatzner]

Fixes #10407

=== RUN TestAccKubernetesCluster_upgradeChannel
=== PAUSE TestAccKubernetesCluster_upgradeChannel
=== CONT TestAccKubernetesCluster_upgradeChannel
--- PASS: TestAccKubernetesCluster_upgradeChannel (824.85s)
PASS
ok github.com/terraform-providers/terraform-provider-azurerm/azurerm/internal/services/containers 828.691s

[tombuildsstuff]

hey @Brunhil

Thanks for pushing those changes.

Taking a look through on the whole this looks pretty good - but we should remove the none option here in favour of inferring that when the field is omitted (since this is Optional and will be unset by default). Since this otherwise looks good and I've got a few other Kubernetes PR's to get in today, I hope you don't mind but I'm going to push a commit to fix up the comments so that we can get this merged.

Thanks!

[tombuildsstuff]

(as above) we can make this field empty when it's None:

Suggested change

string(containerservice.UpgradeChannelNone),

[tombuildsstuff]

since we're inferring none based on the field being omitted - can we make this:

Suggested change

	* `automatic_channel_upgrade` - (Optional) The upgrade channel for this Kubernetes Cluster. Possible values are `none`, `patch`, `rapid`, and `stable`. The default value is `none`.
	* `automatic_channel_upgrade` - (Optional) The upgrade channel for this Kubernetes Cluster. Possible values are `patch`, `rapid`, and `stable`.

[tombuildsstuff]

since this value is updateable, could we take this from: rapid -> patch -> none -> stable to ensure the lifecycle works?

dismissing since changes have been pushed

[jackofallops]

Thanks @Brunhil & @tombuildsstuff - LGTM 👍

[tombuildsstuff]

The basicVMSS and Upgrade Channel tests look good:

$ TF_ACC=1 go test -v ./azurerm/internal/services/containers -run=TestAccKubernetesCluster_upgradeChannel -timeout=60m
=== RUN   TestAccKubernetesCluster_upgradeChannel
=== PAUSE TestAccKubernetesCluster_upgradeChannel
=== CONT  TestAccKubernetesCluster_upgradeChannel
--- PASS: TestAccKubernetesCluster_upgradeChannel (1045.71s)
PASS
ok  	github.com/terraform-providers/terraform-provider-azurerm/azurerm/internal/services/containers	1045.774s

[ghost]

This has been released in version 2.48.0 of the provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. As an example:

provider "azurerm" {
    version = "~> 2.48.0"
}
# ... other configuration ...

[ghost]

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 hashibot-feedback@hashicorp.com. Thanks!