Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

New Resource: azurerm_application_insights_smart_detection_rule #10539

Merged
merged 4 commits into from Feb 11, 2021
Merged

New Resource: azurerm_application_insights_smart_detection_rule #10539

merged 4 commits into from Feb 11, 2021

Conversation

mbfrahry
Copy link
Member

@mbfrahry mbfrahry commented Feb 11, 2021 •
edited

Fixes #8812

--- PASS: TestAccApplicationInsightsSmartDetectionRule_multiple (116.48s)
--- PASS: TestAccApplicationInsightsSmartDetectionRule_basic (116.48s)
--- PASS: TestAccApplicationInsightsSmartDetectionRule_longDependencyDuration (117.27s)
--- PASS: TestAccApplicationInsightsSmartDetectionRule_update (186.80s)

@mbfrahry mbfrahry requested a review from a team February 11, 2021 16:05
@mbfrahry mbfrahry added this to the v2.48.0 milestone Feb 11, 2021
katbyte
katbyte approved these changes Feb 11, 2021
View reviewed changes
Copy link
Collaborator

@katbyte katbyte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Aside from one minor schema comments this LGTM 👍

.../internal/services/applicationinsights/application_insights_smart_detection_rule_resource.go Outdated
Default: true,
},

"additional_emails": {
Copy link
Collaborator

@katbyte katbyte Feb 11, 2021 •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

would this make more sense as

Suggested change
"additional_emails": {
"addtional_email_recipients": {

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure does!

@mbfrahry mbfrahry modified the milestones: v2.48.0, v2.47.0 Feb 11, 2021
@mbfrahry mbfrahry merged commit 070ebf2 into master Feb 11, 2021
@mbfrahry mbfrahry deleted the f-ai-pdc branch February 11, 2021 19:05
mbfrahry added a commit that referenced this pull request Feb 11, 2021
@mbfrahry
Update changelog for #10539
1d9ad3e
@ghost
Copy link

ghost commented Feb 11, 2021

This has been released in version 2.47.0 of the provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. As an example:

provider "azurerm" {
    version = "~> 2.47.0"
}
# ... other configuration ...

@ghost
Copy link

ghost commented Mar 14, 2021

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 hashibot-feedback@hashicorp.com. Thanks!

@hashicorp hashicorp locked as resolved and limited conversation to collaborators Mar 14, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@katbyte katbyte katbyte approved these changes

Assignees
No one assigned
Labels
documentation new-resource service/application-insights size/XL
Projects
None yet
Milestone
v2.47.0
Development

Successfully merging this pull request may close these issues.

Feature Request : Support for toggling/disabling the smart detection functionality of azure app insights
2 participants
@mbfrahry @katbyte