Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"azurerm_kubernetes_cluster" - supports property "dns_prefix_private_cluster" #11321

Merged
merged 2 commits into from Apr 27, 2021

Conversation

njuCZ
Copy link
Contributor

@njuCZ njuCZ commented Apr 14, 2021

this property in swagger is "fqdnSubdomain", it is used in private cluster to set custom dns subdomain, so I renamed it to "private_cluster_custom_dns_prefix"

Doc refer to https://docs.microsoft.com/en-us/azure/aks/private-clusters#configure-private-dns-zone

difference between property dns_prefix and private_cluster_custom_dns_prefix:

  1. use "dns_prefix", the fqdn format is like <dns-prefix>-<random-hash>.xxx.<region>.azmk8s.io
  2. use "private_cluster_custom_dns_prefix", the fqdn format is like <fqdnsubdomain>.privatelink.<region>.azmk8s.io

there should be exactly one of dns_prefix and private_cluster_custom_dns_prefix, otherwise the rest api will report error.

image

Copy link
Collaborator

@katbyte katbyte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

aside from one comment about this property name this is looking good

website/docs/r/kubernetes_cluster.html.markdown Outdated Show resolved Hide resolved
@njuCZ njuCZ changed the title "azurerm_kubernetes_cluster" - supports property "private_cluster_custom_dns_prefix" "azurerm_kubernetes_cluster" - supports property "dns_prefix_private_cluster" Apr 21, 2021
@njuCZ
Copy link
Contributor Author

njuCZ commented Apr 21, 2021

@katbyte Thanks for the suggestion. I have renamed this property

Copy link
Collaborator

@katbyte katbyte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @njuCZ - LGTM 👍

@katbyte katbyte added this to the v2.57.0 milestone Apr 27, 2021
@katbyte katbyte merged commit 0cc2517 into hashicorp:master Apr 27, 2021
katbyte added a commit that referenced this pull request Apr 27, 2021
@ghost
Copy link

ghost commented Apr 30, 2021

This has been released in version 2.57.0 of the provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. As an example:

provider "azurerm" {
    version = "~> 2.57.0"
}
# ... other configuration ...

@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active contributions.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 30, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants