Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow auto os upgrades for service fabric #11723

Merged
merged 5 commits into from May 25, 2021

Conversation

hbuckle
Copy link
Contributor

@hbuckle hbuckle commented May 14, 2021

For service fabric scale sets automatic OS upgrade can be enabled without a health probe - https://docs.microsoft.com/en-gb/azure/virtual-machine-scale-sets/virtual-machine-scale-sets-automatic-upgrade#service-fabric-requirements

In addition, automatic OS upgrade can be enabled without re-creating the scale set (tested in the Azure portal/PowerShell)

@ghost ghost added the size/XS label May 14, 2021
@@ -1236,20 +1236,17 @@ func VirtualMachineScaleSetAutomatedOSUpgradePolicySchema() *schema.Schema {
return &schema.Schema{
Type: schema.TypeList,
Optional: true,
ForceNew: true,
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This probably requires docs update as well, normally docs state that "Changing this forces a new resource to be created"?

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yep, both windows and linux scaleset docs need an update.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Docs updated

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@favoretti - is this OK now?

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@hbuckle LGTM, thank you, but a maintainer has to approve still.

@ghost ghost added the documentation label May 14, 2021
@favoretti favoretti added the service/vmss Virtual Machine Scale Sets label May 19, 2021
Copy link
Collaborator

@katbyte katbyte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR @hbuckle - looks good but could we get a linux and windows VM test so we can confirm this behaviour works - and catch any changes to the APIs and if it breaks in the future. Thanks!

@ghost ghost added size/XL and removed size/XS labels May 22, 2021
@hbuckle
Copy link
Contributor Author

hbuckle commented May 25, 2021

@katbyte - tests added

Copy link
Collaborator

@katbyte katbyte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @hbuckle - LGTM 👍

@katbyte katbyte added this to the v2.61.0 milestone May 25, 2021
@katbyte katbyte merged commit ce635ee into hashicorp:master May 25, 2021
katbyte added a commit that referenced this pull request May 25, 2021
@ghost
Copy link

ghost commented May 27, 2021

This has been released in version 2.61.0 of the provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. As an example:

provider "azurerm" {
    version = "~> 2.61.0"
}
# ... other configuration ...

@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active contributions.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 27, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants