azurerm_redis_cache - support replicas_per_primary, redis_version, tenant_settings #12820

xuzhang3 · 2021-08-03T08:28:23Z

Redis Cache enhancemnent:

Support redisVersion, tenantSettings, replicasPerPrimary
Bump redis cache API from 2020-06-01 to 2020-12-01

AccTest:

TestAccRedisCacheDataSource:

==> Checking that code complies with gofmt requirements...
==> Checking that Custom Timeouts are used...
==> Checking that acceptance test packages are used...
TF_ACC=1 go test -v ./azurerm/internal/services/redis -run=TestAccRedisCacheDataSource -timeout 60m -ldflags="-X=github.com/terraform-providers/terraform-provider-azurerm/version.ProviderVersion=acc"
=== RUN   TestAccRedisCacheDataSource_standard
=== PAUSE TestAccRedisCacheDataSource_standard
=== CONT  TestAccRedisCacheDataSource_standard
--- PASS: TestAccRedisCacheDataSource_standard (2112.87s)
PASS
ok      github.com/terraform-providers/terraform-provider-azurerm/azurerm/internal/services/redis       2116.717s



TestAccRedisFirewallRule:

==> Checking that code complies with gofmt requirements...
==> Checking that Custom Timeouts are used...
==> Checking that acceptance test packages are used...
TF_ACC=1 go test -v ./azurerm/internal/services/redis -run=TestAccRedisFirewallRule
-timeout 60m -ldflags="-X=github.com/terraform-providers/terraform-provider-azurerm/
version.ProviderVersion=acc"
=== RUN   TestAccRedisFirewallRule_basic
=== PAUSE TestAccRedisFirewallRule_basic
=== RUN   TestAccRedisFirewallRule_multi
=== PAUSE TestAccRedisFirewallRule_multi
=== RUN   TestAccRedisFirewallRule_requiresImport
=== PAUSE TestAccRedisFirewallRule_requiresImport
=== RUN   TestAccRedisFirewallRule_update
=== PAUSE TestAccRedisFirewallRule_update
=== CONT  TestAccRedisFirewallRule_basic
=== CONT  TestAccRedisFirewallRule_requiresImport
=== CONT  TestAccRedisFirewallRule_update
=== CONT  TestAccRedisFirewallRule_multi
--- PASS: TestAccRedisFirewallRule_basic (1523.07s)
--- PASS: TestAccRedisFirewallRule_multi (1550.96s)
--- PASS: TestAccRedisFirewallRule_requiresImport (1573.64s)
--- PASS: TestAccRedisFirewallRule_update (1645.75s)
PASS
ok      github.com/terraform-providers/terraform-provider-azurerm/azurerm/internal/services/redis       1649.861s


TestAccRedisLinkedServer:

==> Checking that code complies with gofmt requirements...
==> Checking that Custom Timeouts are used...
==> Checking that acceptance test packages are used...
TF_ACC=1 go test -count=1  -v ./azurerm/internal/services/redis -run=TestAccRedisLinkedServer -timeout 60m -ldflags="-X=github.com/terraform-providers/terraform-provider-azurerm/version.
ProviderVersion=acc"
=== RUN   TestAccRedisLinkedServer_basic
=== PAUSE TestAccRedisLinkedServer_basic
=== RUN   TestAccRedisLinkedServer_requiresImport
=== PAUSE TestAccRedisLinkedServer_requiresImport
=== CONT  TestAccRedisLinkedServer_basic
=== CONT  TestAccRedisLinkedServer_requiresImport
--- PASS: TestAccRedisLinkedServer_basic (2444.06s)
--- PASS: TestAccRedisLinkedServer_requiresImport (2529.45s)
PASS
ok      github.com/terraform-providers/terraform-provider-azurerm/azurerm/internal/services/redis  2533.750s

TestAccRedisCache:

==> Checking that code complies with gofmt requirements...
==> Checking that Custom Timeouts are used...
==> Checking that acceptance test packages are used...
TF_ACC=1 go test -v ./azurerm/internal/services/redis -run=TestAccRedisCache -timeout 240m -ldflags="-X=github.com/terraform-providers/terraform-provider-azurerm/version
.ProviderVersion=acc"
=== RUN   TestAccRedisCacheDataSource_standard
=== PAUSE TestAccRedisCacheDataSource_standard
=== RUN   TestAccRedisCache_basic
=== PAUSE TestAccRedisCache_basic
=== RUN   TestAccRedisCache_withoutSSL
=== PAUSE TestAccRedisCache_withoutSSL
=== RUN   TestAccRedisCache_requiresImport
=== PAUSE TestAccRedisCache_requiresImport
=== RUN   TestAccRedisCache_standard
=== PAUSE TestAccRedisCache_standard
=== RUN   TestAccRedisCache_premium
=== PAUSE TestAccRedisCache_premium
=== RUN   TestAccRedisCache_premiumSharded
=== PAUSE TestAccRedisCache_premiumSharded
=== RUN   TestAccRedisCache_premiumShardedScaling
=== PAUSE TestAccRedisCache_premiumShardedScaling
=== RUN   TestAccRedisCache_NonStandardCasing
=== PAUSE TestAccRedisCache_NonStandardCasing
=== RUN   TestAccRedisCache_BackupDisabled
=== PAUSE TestAccRedisCache_BackupDisabled
=== RUN   TestAccRedisCache_BackupEnabled
=== PAUSE TestAccRedisCache_BackupEnabled
=== RUN   TestAccRedisCache_BackupEnabledDisabled
=== PAUSE TestAccRedisCache_BackupEnabledDisabled
=== RUN   TestAccRedisCache_AOFBackupEnabled
=== PAUSE TestAccRedisCache_AOFBackupEnabled
=== RUN   TestAccRedisCache_AOFBackupEnabledDisabled
=== PAUSE TestAccRedisCache_AOFBackupEnabledDisabled
=== RUN   TestAccRedisCache_PatchSchedule
=== PAUSE TestAccRedisCache_PatchSchedule
=== RUN   TestAccRedisCache_PatchScheduleUpdated
=== PAUSE TestAccRedisCache_PatchScheduleUpdated
=== RUN   TestAccRedisCache_PublicNetworkAccessDisabledEnabled
=== PAUSE TestAccRedisCache_PublicNetworkAccessDisabledEnabled
=== RUN   TestAccRedisCache_InternalSubnet
=== PAUSE TestAccRedisCache_InternalSubnet
=== RUN   TestAccRedisCache_InternalSubnetStaticIP
=== PAUSE TestAccRedisCache_InternalSubnetStaticIP
=== RUN   TestAccRedisCache_InternalSubnet_withZone
=== PAUSE TestAccRedisCache_InternalSubnet_withZone
=== RUN   TestAccRedisCache_SubscribeAllEvents
=== PAUSE TestAccRedisCache_SubscribeAllEvents
=== RUN   TestAccRedisCache_WithoutAuth
=== PAUSE TestAccRedisCache_WithoutAuth
=== RUN   TestAccRedisCache_ReplicasPerMaster
=== PAUSE TestAccRedisCache_ReplicasPerMaster
=== RUN   TestAccRedisCache_ReplicasPerPrimary
=== PAUSE TestAccRedisCache_ReplicasPerPrimary
=== RUN   TestAccRedisCache_RedisVersion
=== PAUSE TestAccRedisCache_RedisVersion
=== RUN   TestAccRedisCache_TenantSettings
=== PAUSE TestAccRedisCache_TenantSettings
=== CONT  TestAccRedisCacheDataSource_standard
=== CONT  TestAccRedisCache_PatchSchedule
=== CONT  TestAccRedisCache_AOFBackupEnabled
=== CONT  TestAccRedisCache_WithoutAuth
=== CONT  TestAccRedisCache_RedisVersion
=== CONT  TestAccRedisCache_BackupEnabled
=== CONT  TestAccRedisCache_premiumShardedScaling
=== CONT  TestAccRedisCache_AOFBackupEnabledDisabled
=== CONT  TestAccRedisCache_ReplicasPerPrimary
--- PASS: TestAccRedisCache_WithoutAuth (1476.97s)
--- PASS: TestAccRedisCache_RedisVersion (1532.80s)
=== CONT  TestAccRedisCache_BackupDisabled
=== CONT  TestAccRedisCache_BackupEnabledDisabled
--- PASS: TestAccRedisCache_PatchSchedule (1537.95s)
--- PASS: TestAccRedisCache_AOFBackupEnabled (1624.05s)
=== CONT  TestAccRedisCache_standard
--- PASS: TestAccRedisCache_BackupEnabled (1937.85s)
=== CONT  TestAccRedisCache_premiumSharded
--- PASS: TestAccRedisCacheDataSource_standard (2175.88s)
=== CONT  TestAccRedisCache_premium
--- PASS: TestAccRedisCache_premiumShardedScaling (2805.35s)
=== CONT  TestAccRedisCache_ReplicasPerMaster
--- PASS: TestAccRedisCache_AOFBackupEnabledDisabled (2828.37s)
=== CONT  TestAccRedisCache_InternalSubnetStaticIP
--- PASS: TestAccRedisCache_ReplicasPerPrimary (1491.88s)
=== CONT  TestAccRedisCache_SubscribeAllEvents
--- PASS: TestAccRedisCache_BackupDisabled (1519.75s)
=== CONT  TestAccRedisCache_InternalSubnet_withZone
--- PASS: TestAccRedisCache_BackupEnabledDisabled (1537.81s)
=== CONT  TestAccRedisCache_PublicNetworkAccessDisabledEnabled
--- PASS: TestAccRedisCache_premiumSharded (1568.10s)
=== CONT  TestAccRedisCache_InternalSubnet
--- PASS: TestAccRedisCache_standard (2039.38s)
=== CONT  TestAccRedisCache_withoutSSL
--- PASS: TestAccRedisCache_premium (1535.45s)
=== CONT  TestAccRedisCache_requiresImport
--- PASS: TestAccRedisCache_ReplicasPerMaster (1459.14s)
=== CONT  TestAccRedisCache_PatchScheduleUpdated
--- PASS: TestAccRedisCache_SubscribeAllEvents (1436.77s)
=== CONT  TestAccRedisCache_NonStandardCasing
--- PASS: TestAccRedisCache_PublicNetworkAccessDisabledEnabled (2203.87s)
=== CONT  TestAccRedisCache_basic
--- PASS: TestAccRedisCache_withoutSSL (1976.11s)
=== CONT  TestAccRedisCache_TenantSettings
--- PASS: TestAccRedisCache_requiresImport (2083.57s)
--- PASS: TestAccRedisCache_PatchScheduleUpdated (1572.15s)
--- PASS: TestAccRedisCache_InternalSubnetStaticIP (3557.88s)
--- PASS: TestAccRedisCache_NonStandardCasing (1985.46s)
--- PASS: TestAccRedisCache_InternalSubnet_withZone (3359.18s)
--- PASS: TestAccRedisCache_InternalSubnet (2917.59s)
--- PASS: TestAccRedisCache_TenantSettings (1589.67s)
--- PASS: TestAccRedisCache_basic (2065.85s)
PASS
ok      github.com/terraform-providers/terraform-provider-azurerm/azurerm/internal/services/redis       7349.246s

Signed-off-by: xuzhang3 <Zhangxu894765>

BzSpi · 2021-08-04T13:42:28Z

website/docs/r/redis_cache.html.markdown

@@ -73,6 +73,14 @@ The following arguments are supported:

 ~> **Note:** Configuring the number of replicas per master is only available when using the Premium SKU and cannot be used in conjunction with shards.

+* `replicas_per_primary` - (Optional) Amount of replicas to create per primary for this Redis Cache. If both `replicas_per_primary` and `replicas_per_master` are set, they need to be equal.
+
+* `redis_version` - (Optional) Redis version. Only major version needed. Valid values: `4`, `6`. 


If it's optional, what is the default value ?

Its computed so its derived from the API (and can change depending on what azure defaults too)

@BzSpi For current API, the default value will be 4.

katbyte

Thanks @xuzhang3 - LGTM ❄️

katbyte · 2021-08-04T16:58:25Z

website/docs/r/redis_cache.html.markdown

@@ -73,6 +73,14 @@ The following arguments are supported:

 ~> **Note:** Configuring the number of replicas per master is only available when using the Premium SKU and cannot be used in conjunction with shards.

+* `replicas_per_primary` - (Optional) Amount of replicas to create per primary for this Redis Cache. If both `replicas_per_primary` and `replicas_per_master` are set, they need to be equal.
+
+* `redis_version` - (Optional) Redis version. Only major version needed. Valid values: `4`, `6`. 


Its computed so its derived from the API (and can change depending on what azure defaults too)

github-actions · 2021-08-06T03:14:34Z

This functionality has been released in v2.71.0 of the Terraform Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

github-actions · 2021-09-06T02:08:47Z

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active contributions.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

xuzhang3 added 2 commits July 22, 2021 12:32

bump redis cache API from 2020-06-01 to 2020-12-01

703404e

Signed-off-by: xuzhang3 <Zhangxu894765>

support redisVersion, tenantSettings, replicasPerPrimary

58b4e64

github-actions bot added dependencies documentation size/XL labels Aug 3, 2021

support redis6

1fd9d0d

Poil mentioned this pull request Aug 4, 2021

r/redis_cache: Add support for Redis 6 #9403

Closed

BzSpi reviewed Aug 4, 2021

View reviewed changes

katbyte added this to the v2.71.0 milestone Aug 4, 2021

katbyte approved these changes Aug 4, 2021

View reviewed changes

katbyte changed the title ~~Redis Cache enhance~~ azurerm_redis_cache - support replicas_per_primary, redis_version, tenant_settings Aug 4, 2021

katbyte merged commit e110150 into hashicorp:master Aug 4, 2021

katbyte added a commit that referenced this pull request Aug 4, 2021

CHANGELOG.md for #12820

52b0dda

github-actions bot locked as resolved and limited conversation to collaborators Sep 6, 2021

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

azurerm_redis_cache - support replicas_per_primary, redis_version, tenant_settings #12820

azurerm_redis_cache - support replicas_per_primary, redis_version, tenant_settings #12820

xuzhang3 commented Aug 3, 2021

BzSpi Aug 4, 2021

katbyte Aug 4, 2021

xuzhang3 Aug 5, 2021

katbyte left a comment

katbyte Aug 4, 2021

github-actions bot commented Aug 6, 2021

github-actions bot commented Sep 6, 2021

azurerm_redis_cache - support replicas_per_primary, redis_version, tenant_settings #12820

azurerm_redis_cache - support replicas_per_primary, redis_version, tenant_settings #12820

Conversation

xuzhang3 commented Aug 3, 2021

BzSpi Aug 4, 2021

Choose a reason for hiding this comment

katbyte Aug 4, 2021

Choose a reason for hiding this comment

xuzhang3 Aug 5, 2021

Choose a reason for hiding this comment

katbyte left a comment

Choose a reason for hiding this comment

katbyte Aug 4, 2021

Choose a reason for hiding this comment

github-actions bot commented Aug 6, 2021

github-actions bot commented Sep 6, 2021