State migration for storage account resource #13607
Conversation
| } | ||
| schemaVersion := 2 | ||
|
|
||
| if features.ThreePointOhBetaResources() { |
There was a problem hiding this comment.
@tombuildsstuff I'm assuming you did not leave this out on purpose?
There was a problem hiding this comment.
hey @koikonom
Thanks for pushing those changes - I've left a couple of comments inline but this otherwise LGTM 👍
Thanks!
There was a problem hiding this comment.
hey @koikonom
Thanks for pushing those changes - apologies for the delayed re-review here.
Taking a look through if we can strip out the validation functions and expand the common schema (since State Migrations are a point-in-time reference, so these shouldn't change over time which common schema may) then this should otherwise be good to go, I've tried to call all of those out so 🤞 most of those can be fixed with Github
Thanks!
koikonom
force-pushed
the
storage_resource_statemigration
branch
from
1fffc84
to
05de20b
Compare
|
Rebased on top of latest main |
In 3.0 we're renaming `allow_blob_public_access` to `allow_nested_items_to_be_public`. This PR adds a state migration to support this change that only takes place when we're actually running on 3.0 or the user has opted-in.
We need to call schemaStorageAccountCorsRule from package other than storage, so we're moving it on its own package that can be imported from two places.
Remove validation and default settings from state migration schema Co-authored-by: Tom Harvey <tombuildsstuff@users.noreply.github.com>
koikonom
force-pushed
the
storage_resource_statemigration
branch
from
05de20b
to
2fc5e36
Compare
koikonom
force-pushed
the
storage_resource_statemigration
branch
from
2fc5e36
to
78d0957
Compare
|
This functionality has been released in v2.86.0 of the Terraform Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you! |
|
I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active contributions. |
In 3.0 we're renaming
allow_blob_public_accesstoallow_nested_items_to_be_public.This PR adds a state migration to support this change that only takes
place when we're actually running on 3.0 or the user has opted-in.