Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New resources azurerm_stream_analytics_cluster and azurerm_stream_analytics_managed_private_endpoint #14082

Merged
merged 21 commits into from Nov 19, 2021

Conversation

stephybun
Copy link
Member

Closes #13877

@stephybun stephybun requested a review from a team November 8, 2021 12:46
Copy link
Collaborator

@katbyte katbyte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @stephybun - LGTM 🏗️ thou the build is failing in TC:

Step 4/5] # github.com/hashicorp/terraform-provider-azurerm/internal/services/streamanalytics
[01:53:54]	[Step 4/5] ./stream_analytics_cluster_resource.go:41:9: undefined: "github.com/hashicorp/terraform-provider-azurerm/internal/services/eventhub/validate".ClusterID
[01:55:25]	[Step 4/5] Process exited with code 2

Copy link
Collaborator

@katbyte katbyte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

err meant to approve with that one comment 😅

@stephybun
Copy link
Member Author

Oops, thanks for catching that! Fixed and tests are passing.
image

@stephybun stephybun merged commit 6494dda into main Nov 19, 2021
@stephybun stephybun deleted the f/stream-analytics-cluster branch November 19, 2021 11:13
@github-actions github-actions bot added this to the v2.87.0 milestone Nov 19, 2021
stephybun added a commit that referenced this pull request Nov 19, 2021
@github-actions
Copy link

This functionality has been released in v2.87.0 of the Terraform Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active contributions.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Dec 27, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support for Stream Analytics Cluster
2 participants