Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Azure DNS CAA record support #1450

Merged
merged 8 commits into from Jun 26, 2018
Merged

Azure DNS CAA record support #1450

merged 8 commits into from Jun 26, 2018

Conversation

ranieuwe
Copy link
Contributor

This PR Fixes #890

Steps taken:

  • Upgraded vendor.json to include new DNS API from 2017-10-01
  • Upgraded API for all other DNS providers
  • Implemented the CAA provider based of the SRV provider
  • Set up tests for the CAA provider
  • Ran tests for DNS and CAA provider and they are all ✔️
  • Documentation

All DNS tests have been executed (testacc, test) and are successful.

Introduction of the 2017-10-01 API does also allow for extended ASCII sets for TXT records. Have not tested or implemented that yet.

First contribution to Terraform. Looking forward to your review!

Copy link
Collaborator

@WodansSon WodansSon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @ranieuwe,

Thanks for the PR and congrats on your first contribution to Terraform. After review it LGTM.

@WodansSon WodansSon merged commit f8aa5e0 into hashicorp:master Jun 26, 2018
katbyte added a commit that referenced this pull request Jun 27, 2018
@WodansSon WodansSon added this to the 1.8.0 milestone Jun 27, 2018
@ghost
Copy link

ghost commented Mar 30, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 hashibot-feedback@hashicorp.com. Thanks!

@hashicorp hashicorp locked and limited conversation to collaborators Mar 30, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Feature request: Support for CAA DNS record
2 participants