Adding shared private link resource for the Azure web pubsub resource

[xiaxyi]

ACC test:

--- PASS: TestAccWebPubsubPrivateLinkedService_basic (424.23s)
PASS
ok      github.com/hashicorp/terraform-provider-azurerm/internal/services/signalr       425.031s
--- PASS: TestAccWebPubsubSharedPrivateLinkResource_basic (567.02s)
--- PASS: TestAccWebPubsubSharedPrivateLinkResource_requiresImport (597.15s)
PASS
ok      github.com/hashicorp/terraform-provider-azurerm/internal/services/signalr       597.831s

[tombuildsstuff]

a Data Source cannot contain a Set - this needs to be a List

furthermore: what's the intention of this data source? why isn't this part of the WebPubSub data source?

[xiaxyi]

This data source is intended to provide a reference of supported sub resource that can be linked by a web pubsub resource, just as the same as the purpose of azurerm_monitor_diagnostic_categories. I thought it would be more straight-forward to get this information separately since user may would only like to refer to such information?

[xiaxyi]

@tombuildsstuff may I know if you have any other concerns that I can help to address? :)

[katbyte]

In what instances would a user need this information? I searched the repo and I cannot find any other services with such a private link resource data source?

[xiaxyi]

My first thought was to provide a reference to the user, just in case they don't know what information to put in the propertysubresource_name. I can remove it if it looks like unnecessary.

[katbyte]

that is the entire resource thou? thjats why i am asking what is the use to a user for this resoruce?

[xiaxyi]

sorry I don't quite follow your concerns. I added this data source just in case the user doesn't know what value to put in the subresource_name when using the resource azurerm_web_pubsub_shared_private_link_resource

the supported subresource varies from different resources, for example, the output of this datasource is:

webpubsub_private_supported_resource = {
  "id" = "/subscriptions/733b9054-5ed8-4f10-a444-c32458359d40/resourceGroups/xiaxintest/providers/Microsoft.SignalRService/WebPubSub/acctestWebPubsub"
  "shared_private_link_resource_types" = tolist([
    {
      "description" = "Azure App Service can be used as an upstream"
      "subresource_name" = "sites"
    },
    {
      "description" = "Azure Key Vault can be used as credentials store"
      "subresource_name" = "vault"
    },
  ])

The user can put either site or vault in the property subresource_name in below tf block:

resource "azurerm_web_pubsub_shared_private_link_resource" "test" {
  name               = "acctest-%d"
  web_pubsub_id      = azurerm_web_pubsub.test.id
  subresource_name   = "vault"
  target_resource_id = azurerm_key_vault.test.id
}

[xiaxyi]

replied inline

[tombuildsstuff]

the casing here is wrong, this needs to be:

Suggested change

	//go:generate go run ../../tools/generator-resource-id/main.go -path=./ -name=WebPubsubSharedPrivateLinkResource -id=/subscriptions/12345678-1234-9876-4563-123456789012/resourcegroups/resGroup1/providers/Microsoft.SignalRService/WebPubSub/Webpubsub1/sharedPrivateLinkResources/resource1
	//go:generate go run ../../tools/generator-resource-id/main.go -path=./ -name=WebPubsubSharedPrivateLinkResource -id=/subscriptions/12345678-1234-9876-4563-123456789012/resourceGroups/resGroup1/providers/Microsoft.SignalRService/webPubSub/Webpubsub1/sharedPrivateLinkResources/resource1

[xiaxyi]

Thanks @tombuildsstuff, I will make resourceGroups as camel cased, however, for webPubSub oe, the service is returning the value as WebPubSub and this behavior is the same as its parent WebPubSub resource. Shall we keep it as capital cased?

[katbyte]

we should be correcting it to the proper case

[xiaxyi]

@katbyte I updated the ID, feel free to let me know if everything looks good to you. :)

[katbyte]

LGTM 🔝

[github-actions]

This functionality has been released in v3.15.0 of the Terraform Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

[github-actions]

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active contributions.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.