Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dependencies: Upgrade sqlvirtualmachine to 2021-11-01-preview #15835

Merged
merged 1 commit into from
Apr 27, 2022

Conversation

myc2h6o
Copy link
Contributor

@myc2h6o myc2h6o commented Mar 15, 2022

To prepare for supporting instance_settings mentioned in #15824

@@ -811,7 +811,7 @@ func flattenSqlVirtualMachineStorageConfigurationSettings(input *sqlvirtualmachi
"disk_type": string(input.DiskConfigurationType),
"data_settings": flattenSqlVirtualMachineStorageSettings(input.SQLDataSettings),
"log_settings": flattenSqlVirtualMachineStorageSettings(input.SQLLogSettings),
"temp_db_settings": flattenSqlVirtualMachineStorageSettings(input.SQLTempDbSettings),
"temp_db_settings": flattenSqlVirtualMachineTempDbSettings(input.SQLTempDbSettings),
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The type has been changed in the new api version so created a copy of the old expand/flatten

@myc2h6o
Copy link
Contributor Author

myc2h6o commented Apr 19, 2022

Hi @katbyte there seems to be multiple features waiting for the api upgrade, would you be able to take a look?

Copy link
Collaborator

@katbyte katbyte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@myc2h6o - all tests are failing with this PR:

image

@myc2h6o
Copy link
Contributor Author

myc2h6o commented Apr 23, 2022

Hi @katbyte I found these tests failing on main as well due to dangling os_disk during delete phase, fixing them with #16519. Please take a look.

@myc2h6o
Copy link
Contributor Author

myc2h6o commented Apr 26, 2022

@katbyte The fixing pr #16519 is merged, updated test result with this change:
image

Among these, the test TestAccMsSqlVirtualMachine_autoPatching is intermittently failing ever since it's introduced due to the API refresh latency, similar to the other property auto_backup, we may need to apply the same workaround for it, will address it in a separate pr:

// Wait for the auto backup settings to take effect
// See: https://github.com/Azure/azure-rest-api-specs/issues/12818
if autoBackup := d.Get("auto_backup"); (d.IsNewResource() && len(autoBackup.([]interface{})) > 0) || (!d.IsNewResource() && d.HasChange("auto_backup")) {
log.Printf("[DEBUG] Waiting for SQL Virtual Machine %q AutoBackupSettings to take effect", d.Id())
stateConf := &pluginsdk.StateChangeConf{
Pending: []string{"Retry", "Pending"},
Target: []string{"Updated"},
Refresh: resourceMsSqlVirtualMachineAutoBackupSettingsRefreshFunc(ctx, client, d),
MinTimeout: 1 * time.Minute,
ContinuousTargetOccurence: 2,
}

Copy link
Collaborator

@katbyte katbyte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚜

@katbyte katbyte merged commit 321df7e into hashicorp:main Apr 27, 2022
katbyte added a commit that referenced this pull request Apr 27, 2022
@github-actions github-actions bot added this to the v3.4.0 milestone Apr 27, 2022
@myc2h6o myc2h6o deleted the sqlvm_upgrade branch April 28, 2022 01:05
@github-actions
Copy link

This functionality has been released in v3.4.0 of the Terraform Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active contributions.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 30, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants