azurerm_api_management: support recovery of soft deleted instances and enable purge on deletion by default #15871
Conversation
manicminer
force-pushed
the
feature/apim-soft-delete
branch
from
1336852
to
f650725
Compare
manicminer
changed the title
azurerm_api_mamnagement support recovering soft deleted
internal/provider/features.go
Outdated
| Default: true, | ||
| }, | ||
|
|
||
| "recover_soft_deleted_api_managements": { |
There was a problem hiding this comment.
I'm not sure we need to have api management on the end given it is in a block api_management? and above we have a property without the post fix applying to the same type of resource?
| "recover_soft_deleted_api_managements": { | |
| "recover_soft_deleted": { |
There was a problem hiding this comment.
also i wonder if the purge one should be purge_soft_deleted_on_destroy 🤔
There was a problem hiding this comment.
Thanks, agreed on shortening the first one, the naming didn't quite sit right. For the second one, it's inkeeping with the existing equivalent property for other services so perhaps best to leave it for now.
manicminer
force-pushed
the
feature/apim-soft-delete
branch
from
f650725
to
dc6aadc
Compare
…d enable purge on deletion by default
manicminer
force-pushed
the
feature/apim-soft-delete
branch
from
dc6aadc
to
95a3471
Compare
|
Test results
|
|
This functionality has been released in v3.0.0 of the Terraform Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you! |
|
I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active contributions. |
Fixes: #15865