Dependency New Resource/Data Source azurerm_healthcare_dicom_service

[xiaxyi]

adding new resource: healthcare dicom service. Dependency of #15759

DICOM (Digital Imaging and Communications in Medicine) is the international standard to transmit, store, retrieve, print, process, and display medical imaging information, and is the primary medical imaging standard accepted across healthcare.

The DICOM service is a managed service within Azure Health Data Services that ingests and persists DICOM objects at multiple thousands of images per second.

acc tests:

--- PASS: TestAccHealthCareDicomResource_updateUserAssignedIdentity (1315.96s)
--- PASS: TestAccHealthCareDicomResource_update (1361.68s)
--- PASS: TestAccHealthCareDicomResource_basic (1410.94s)
--- PASS: TestAccHealthCareDicomResource_requiresImport (1458.96s)
PASS
ok      github.com/hashicorp/terraform-provider-azurerm/internal/services/healthcare    1459.692s

--- PASS: TestAccHealthCareDicomDataSource_basic (799.27s)
PASS
ok      github.com/hashicorp/terraform-provider-azurerm/internal/services/healthcare    799.909s

[katbyte]

thanks @xiaxyi - took a quick look and left some comments inline. also what does "dicom" stand for" is that the best name for the resoruce? also we have a lot of test failureS:

[katbyte]

what is "dicom"

[xiaxyi]

Thanks @katbyte

DICOM service stands for Digital Imaging and Communications in Medicine (https://docs.microsoft.com/en-us/azure/healthcare-apis/dicom/dicom-services-overview), DICOM service was named by Microsoft upstream team. Shall we use the full name or the abbreviation?

updated the property name and the test cases

[xiaxyi]

self checking the failed acc tests

[katbyte]

Thanks @xiaxyi - lets just use DICOM in the resource and expand it in the docs (i've made a suggestion)

also in the docs/comments etc we should capitalize DICOM as in the msft docs, thanks!

[katbyte]

DICO should be all caps? and lets expand the abbreviation here

Suggested change

	Manages a Healthcare Dicom Service.
	Manages a Healthcare DICOM (Digital Imaging and Communications in Medicine) Service.

[xiaxyi]

@katbyte updated the code as suggested.

[katbyte]

LGTM 🌮

[github-actions]

This functionality has been released in v3.5.0 of the Terraform Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

[github-actions]

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active contributions.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.