Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

azurerm_application_insights - Disable Rule and Action Group that are automatically created when creating this resource #15892

Merged
merged 8 commits into from
Mar 23, 2022
Merged

azurerm_application_insights - Disable Rule and Action Group that are automatically created when creating this resource #15892

merged 8 commits into from
Mar 23, 2022

Conversation

mbfrahry
Copy link
Member

Fixes #10563

katbyte
katbyte approved these changes Mar 20, 2022
View reviewed changes
Copy link
Collaborator

@katbyte katbyte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🦀

@github-actions github-actions bot added size/L and removed size/S labels Mar 22, 2022
@mbfrahry mbfrahry marked this pull request as ready for review March 22, 2022 14:53
tombuildsstuff
tombuildsstuff approved these changes Mar 23, 2022
View reviewed changes
Copy link
Contributor

@tombuildsstuff tombuildsstuff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Three comments but this otherwise LGTM 👍

internal/services/applicationinsights/application_insights_resource.go Show resolved Hide resolved
internal/services/applicationinsights/application_insights_resource.go Outdated Show resolved Hide resolved
internal/provider/features.go Show resolved Hide resolved
@tombuildsstuff tombuildsstuff added this to the v3.0.0 milestone Mar 23, 2022
mbfrahry and others added 3 commits March 23, 2022 13:14
@mbfrahry @tombuildsstuff
Update website/docs/guides/features-block.html.markdown
b16b895 
Co-authored-by: Tom Harvey <tombuildsstuff@users.noreply.github.com>
@mbfrahry @tombuildsstuff
Update internal/services/applicationinsights/application_insights_res…
6a0bba9 
…ource.go

Co-authored-by: Tom Harvey <tombuildsstuff@users.noreply.github.com>
@mbfrahry @tombuildsstuff
Update internal/services/applicationinsights/application_insights_res…
bbe6553 
…ource.go

Co-authored-by: Tom Harvey <tombuildsstuff@users.noreply.github.com>
tombuildsstuff
tombuildsstuff approved these changes Mar 23, 2022
View reviewed changes
Copy link
Contributor

@tombuildsstuff tombuildsstuff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@tombuildsstuff
Copy link
Contributor

Build failure fixes in #15952

@katbyte katbyte merged commit 5f5bbbe into main Mar 23, 2022
@katbyte katbyte deleted the f-applicationinsight-10563 branch March 23, 2022 21:43
katbyte added a commit that referenced this pull request Mar 23, 2022
@katbyte
CHANGELOG.md for #15892
62abe47
@michelefa1988
Copy link

michelefa1988 commented Mar 24, 2022 •
edited
Loading

@tombuildsstuff would you know when this version will be available or minimally how the release cycle works?

@github-actions
Copy link

This functionality has been released in v3.0.0 of the Terraform Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@sebader
Copy link
Contributor

sebader commented Mar 28, 2022

It would be super helpful if this toggle was mentioned on the doc for the Application Insights resource. I just found this by chance here, looking at the features docs page is not the most natural place for people to check.

https://registry.terraform.io/providers/hashicorp/azurerm/latest/docs/resources/application_insights

@katbyte katbyte mentioned this pull request Mar 30, 2022
Closed
@mbfrahry mbfrahry mentioned this pull request Mar 30, 2022
Merged
@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active contributions.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 29, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@tombuildsstuff tombuildsstuff tombuildsstuff approved these changes

@katbyte katbyte katbyte approved these changes

Assignees
No one assigned
Labels
documentation service/application-insights size/L
Projects
None yet
Milestone
v3.0.0
Development

Successfully merging this pull request may close these issues.

r/application_insights: Terraform should remove the automatically created nested items post-creation
5 participants
@mbfrahry @tombuildsstuff @michelefa1988 @sebader @katbyte