Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

3.0: adding missing import validators #15989

Merged
merged 3 commits into from Mar 23, 2022
Merged

3.0: adding missing import validators #15989

merged 3 commits into from Mar 23, 2022

Conversation

tombuildsstuff
Copy link
Member

This PR adds the remaining import-time validators, with the exception of azurerm_template_deployment (which is deprecated) and azurerm_security_center_server_vulnerability_assessment (which will be deprecated in #15747).

Copy link
Collaborator

@katbyte katbyte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚜

@tombuildsstuff
Copy link
Member Author

Changelog:

ENHANCEMENTS
* provider: all (non-deprecated) resources now validate the Resource ID during import [GH-15989]

BUG FIXES

* `azurerm_key_vault_access_policy` - validating the Resource ID during import [GH-15989]
* `azurerm_security_center_auto_provisioning ` - validating the Resource ID during import [GH-15989] 

@katbyte katbyte merged commit 1db46b9 into main Mar 23, 2022
@katbyte katbyte deleted the f/missing-importers branch March 23, 2022 21:32
katbyte added a commit that referenced this pull request Mar 23, 2022
@github-actions
Copy link

This functionality has been released in v3.0.0 of the Terraform Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active contributions.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 26, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants