Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

azurerm_linux_function_app and azurerm_linux_function_app_slot remove RequiredWith constraints on app insights settings #16134

Merged
merged 1 commit into from
Mar 30, 2022

Conversation

jackofallops
Copy link
Member

resolves #16077

@jackofallops jackofallops added this to the v3.1.0 milestone Mar 29, 2022
@jackofallops jackofallops requested a review from a team March 29, 2022 15:25
Copy link
Collaborator

@katbyte katbyte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚜

@jackofallops jackofallops merged commit 0640eee into main Mar 30, 2022
@jackofallops jackofallops deleted the b/function-app-insights-constraints branch March 30, 2022 05:13
jackofallops added a commit that referenced this pull request Mar 30, 2022
@tiagoboeing
Copy link

Will this fix enter on the next release?

@jackofallops
Copy link
Member Author

Will this fix enter on the next release?

HI @tiagoboeing - This will ship in the v3.1.0 release, yes.

@tiagoboeing
Copy link

Will this fix enter on the next release?

HI @tiagoboeing - This will ship in the v3.1.0 release, yes.

@jackofallops exist a way to install a version appointing to this snapshot? I'm having this issue linking my function app with the application insights resource created.

@enorlando
Copy link

enorlando commented Apr 4, 2022

Hi @jackofallops
We are getting a similar issue with the azurerm_windows_function_app resource where setting the argument application_insights_connection_string under the site_config block causes the following error

│ Error: Missing required argument

│ with azurerm_windows_function_app.xxx,
│ on xxx.tf line 75, in resource "azurerm_windows_function_app" "xxx":
│ 75: application_insights_connection_string = azurerm_application_insights.xxx.connection_string

│ "site_config.0.application_insights_connection_string": all of site_config.0.application_insights_connection_string,site_config.0.application_insights_key must be specified

Will this fix this issue too?

@tiagoboeing
Copy link

@enorlando see this #16077 (comment)

@enorlando
Copy link

@tiagoboeing Thank you very much. Adding both application_insights_key and application_insights_connection_string uner the site_config block fixed the issue

@github-actions
Copy link

github-actions bot commented Apr 8, 2022

This functionality has been released in v3.1.0 of the Terraform Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@github-actions
Copy link

github-actions bot commented May 9, 2022

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active contributions.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 9, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

azurerm_linux_function_app requires both connection string and instrumentation key for app insights
4 participants