Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

new resources: azurerm_data_lake_analytics_account & azurerm_data_lake_analytics_firewall_rule #1618

Merged
merged 4 commits into from Jul 20, 2018
Merged

new resources: azurerm_data_lake_analytics_account & azurerm_data_lake_analytics_firewall_rule #1618

merged 4 commits into from Jul 20, 2018

Conversation

katbyte
Copy link
Collaborator

@katbyte katbyte commented Jul 20, 2018

No description provided.

@katbyte katbyte added this to the 1.10.0 milestone Jul 20, 2018
paultyng
paultyng reviewed Jul 20, 2018
View reviewed changes
Copy link
Contributor

@paultyng paultyng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some minor comments, but otherwise LGTM

azurerm/resource_arm_data_lake_analytics_account.go Outdated

import (
"fmt"
"github.com/Azure/azure-sdk-for-go/services/datalake/analytics/mgmt/2016-11-01/account"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

these imports probably need some minor reordering.

azurerm/resource_arm_data_lake_analytics_account.go Outdated
client := meta.(*ArmClient).dataLakeAnalyticsAccountClient
ctx := meta.(*ArmClient).StopContext

log.Printf("[INFO] preparing arguments for Azure ARM Date Lake Store creation.")
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

maybe add the name to this log?

azurerm/resource_arm_data_lake_analytics_firewall_rule.go Outdated
client := meta.(*ArmClient).dataLakeAnalyticsFirewallRulesClient
ctx := meta.(*ArmClient).StopContext

log.Printf("[INFO] preparing arguments for Date Lake Analytics Firewall Rule creation.")
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can you add name to this log?

azurerm/resource_arm_data_lake_store.go Outdated
"github.com/terraform-providers/terraform-provider-azurerm/azurerm/helpers/response"
"github.com/terraform-providers/terraform-provider-azurerm/azurerm/utils"
"log"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

weird ordering here

@paultyng
Copy link
Contributor

Not sure why Travis failed, hmmm...

tombuildsstuff
tombuildsstuff reviewed Jul 20, 2018
View reviewed changes
Copy link
Member

@tombuildsstuff tombuildsstuff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Noticed a couple of tests looked invalid when scrolling through prior to running the tests for this, but it's otherwise 👍

azurerm/resource_arm_data_lake_analytics_account_test.go Outdated

tier = "Commitment100AUHours"

default_store_account_name = "${azurerm_data_lake_store
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this test is invalid?

azurerm/resource_arm_data_lake_analytics_account_test.go Outdated
resource_group_name = "${azurerm_resource_group.test.name}"
location = "${azurerm_resource_group.test.location}"

default_store_account_name = "${azurerm_data_lake_store
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(same here)

azurerm/resource_arm_data_lake_analytics_account_test.go Outdated
resource_group_name = "${azurerm_resource_group.test.name}"
location = "${azurerm_resource_group.test.location}"

default_store_account_name = "${azurerm_data_lake_store
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(same here)

@katbyte katbyte force-pushed the r-datalake-analytics-account_firewall branch from 2d61d0d to d05a178 Compare July 20, 2018 21:14
@katbyte katbyte merged commit ad16844 into master Jul 20, 2018
katbyte added a commit that referenced this pull request Jul 20, 2018
@katbyte
Update CHANGELOG.md to include #1618
02a7599
@katbyte
Copy link
Collaborator Author

katbyte commented Jul 20, 2018

tests pass:

[14:14:16] kt@snowbook:~/hashi/..3../terraform-providers/terraform-provider-azurerm$ make fmt; make testacc TEST=./azurerm TESTARGS=-test.run=TestAccAzureRMDataLake
gofmt -w $(find . -name '*.go' |grep -v vendor)
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./azurerm -v -test.run=TestAccAzureRMDataLake -timeout 180m
=== RUN   TestAccAzureRMDataLakeAnalyticsAccount_basic
--- PASS: TestAccAzureRMDataLakeAnalyticsAccount_basic (211.26s)
=== RUN   TestAccAzureRMDataLakeAnalyticsAccount_tier
--- PASS: TestAccAzureRMDataLakeAnalyticsAccount_tier (270.96s)
=== RUN   TestAccAzureRMDataLakeAnalyticsAccount_withTags
--- PASS: TestAccAzureRMDataLakeAnalyticsAccount_withTags (221.77s)
=== RUN   TestAccAzureRMDataLakeAnalyticsFirewallRule_basic
--- PASS: TestAccAzureRMDataLakeAnalyticsFirewallRule_basic (214.68s)
=== RUN   TestAccAzureRMDataLakeAnalyticsFirewallRule_update
--- PASS: TestAccAzureRMDataLakeAnalyticsFirewallRule_update (230.42s)
=== RUN   TestAccAzureRMDataLakeAnalyticsFirewallRule_azureServices
--- PASS: TestAccAzureRMDataLakeAnalyticsFirewallRule_azureServices (214.02s)
=== RUN   TestAccAzureRMDataLakeStoreFirewallRule_basic
--- PASS: TestAccAzureRMDataLakeStoreFirewallRule_basic (140.75s)
=== RUN   TestAccAzureRMDataLakeStoreFirewallRule_update
--- PASS: TestAccAzureRMDataLakeStoreFirewallRule_update (151.38s)
=== RUN   TestAccAzureRMDataLakeStoreFirewallRule_azureServices
--- PASS: TestAccAzureRMDataLakeStoreFirewallRule_azureServices (140.49s)
=== RUN   TestAccAzureRMDataLakeStore_basic
--- PASS: TestAccAzureRMDataLakeStore_basic (132.96s)
=== RUN   TestAccAzureRMDataLakeStore_tier
--- PASS: TestAccAzureRMDataLakeStore_tier (131.89s)
=== RUN   TestAccAzureRMDataLakeStore_withTags
--- PASS: TestAccAzureRMDataLakeStore_withTags (146.22s)
PASS
ok  	github.com/terraform-providers/terraform-provider-azurerm/azurerm	2206.836s

@tombuildsstuff tombuildsstuff deleted the r-datalake-analytics-account_firewall branch July 24, 2018 07:28
This was referenced Jul 30, 2018
Closed
Closed
@ghost
Copy link

ghost commented Mar 30, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 hashibot-feedback@hashicorp.com. Thanks!

@hashicorp hashicorp locked and limited conversation to collaborators Mar 30, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@tombuildsstuff tombuildsstuff tombuildsstuff left review comments

@paultyng paultyng paultyng approved these changes

Assignees
No one assigned
Labels
new-resource service/data-lake
Projects
None yet
Milestone
v1.10.0
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@katbyte @paultyng @tombuildsstuff