Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Control cross tenant replication #16351

Merged
merged 11 commits into from
May 3, 2022
Merged

Control cross tenant replication #16351

merged 11 commits into from
May 3, 2022

Conversation

koikonom
Copy link
Contributor

No description provided.

@koikonom koikonom requested a review from a team April 12, 2022 17:58
katbyte
katbyte requested changes Apr 12, 2022
View reviewed changes
Copy link
Collaborator

@katbyte katbyte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @koikonom - couple comments left inline and I think we're missing docs?

internal/services/storage/storage_account_resource.go Outdated Show resolved Hide resolved
tombuildsstuff
tombuildsstuff previously requested changes Apr 13, 2022
View reviewed changes
Copy link
Contributor

@tombuildsstuff tombuildsstuff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left a few comments inline, but if we can fix those up this should be good to go 👍

internal/services/storage/storage_account_resource.go Outdated Show resolved Hide resolved
internal/services/storage/storage_account_resource.go Outdated Show resolved Hide resolved
internal/services/storage/storage_account_resource.go Outdated Show resolved Hide resolved
internal/services/storage/storage_account_resource.go Outdated Show resolved Hide resolved
internal/services/storage/storage_account_resource.go Outdated Show resolved Hide resolved
internal/services/storage/storage_account_resource.go Outdated Show resolved Hide resolved
internal/services/storage/storage_account_resource.go Outdated Show resolved Hide resolved
internal/services/storage/storage_account_resource.go Outdated Show resolved Hide resolved
website/docs/r/storage_account.html.markdown Outdated Show resolved Hide resolved
katbyte
katbyte approved these changes Apr 14, 2022
View reviewed changes
Copy link
Collaborator

@katbyte katbyte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🦀

@koikonom koikonom merged commit 87534e3 into main May 3, 2022
@koikonom koikonom deleted the crosstenantreplication branch May 3, 2022 13:08
@github-actions github-actions bot added this to the v3.5.0 milestone May 3, 2022
koikonom pushed a commit that referenced this pull request May 3, 2022
Update changelog for #16351
294b5da
@github-actions
Copy link

github-actions bot commented May 6, 2022

This functionality has been released in v3.5.0 of the Terraform Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@github-actions
Copy link

github-actions bot commented Jun 5, 2022

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active contributions.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 5, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@katbyte katbyte katbyte approved these changes

@tombuildsstuff tombuildsstuff Awaiting requested review from tombuildsstuff

Assignees
No one assigned
Labels
documentation enhancement service/storage size/L
Projects
None yet
Milestone
v3.5.0
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@koikonom @tombuildsstuff @katbyte