Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

data.azurerm_service_plan: fix missing setting values of “kind” and “os_type” properties issue #16431

Merged
merged 2 commits into from
May 5, 2022
Merged

data.azurerm_service_plan: fix missing setting values of “kind” and “os_type” properties issue #16431

merged 2 commits into from
May 5, 2022

Conversation

sinbai
Copy link
Contributor

@sinbai sinbai commented Apr 18, 2022

The purpose of this PR:

  1. Setting the value of the kind property in func (r ServicePlanDataSource) Read() sdk.ResourceFunc.
  2. When the os_type is "Windows", it should be set value in func (r ServicePlanDataSource) Read() sdk.ResourceFunc .

Fix issue #16401.

jackofallops
jackofallops requested changes May 5, 2022
View reviewed changes
Copy link
Member

@jackofallops jackofallops left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @sinbai - Thanks for this PR. Just one small change, but should be good to go after that 👍

internal/services/appservice/service_plan_data_source.go Outdated Show resolved Hide resolved
@katbyte @jackofallops
Update internal/services/appservice/service_plan_data_source.go
d850952 
Co-authored-by: jackofallops <11830746+jackofallops@users.noreply.github.com>
katbyte
katbyte approved these changes May 5, 2022
View reviewed changes
Copy link
Collaborator

@katbyte katbyte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @sinbai - committed that suggestion and now LGTM 🍔

@katbyte katbyte merged commit 7d28136 into hashicorp:main May 5, 2022
@github-actions github-actions bot added this to the v3.5.0 milestone May 5, 2022
katbyte added a commit that referenced this pull request May 5, 2022
@katbyte
CHANGELOG.md for #16431
216900d
@github-actions
Copy link

github-actions bot commented May 6, 2022

This functionality has been released in v3.5.0 of the Terraform Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@github-actions
Copy link

github-actions bot commented Jun 5, 2022

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active contributions.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 5, 2022
@sinbai sinbai deleted the appservice/fix_issue_16401 branch March 28, 2024 03:02
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@jackofallops jackofallops jackofallops requested changes

@katbyte katbyte katbyte approved these changes

Assignees
No one assigned
Labels
service/app-service size/XS
Projects
None yet
Milestone
v3.5.0
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@sinbai @katbyte @jackofallops