Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

New Resource azurerm_stream_analytics_output_powerbi #16439

Merged
merged 6 commits into from
May 12, 2022
Merged

New Resource azurerm_stream_analytics_output_powerbi #16439

merged 6 commits into from
May 12, 2022

Conversation

jiaweitao001
Copy link
Contributor

  • Adding Power BI resource, to make Power BI as a stream analytics job output.

katbyte
katbyte requested changes Apr 21, 2022
View reviewed changes
website/docs/r/stream_analytics_output_powerbi.html.markdown Outdated

* `group_name` - (Required) The name of the Power BI group. Use this property to help remember which specific Power BI group id was used.

* `authentication_mode` - (Optional) Authentication mode. Default to "Msi".
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

grammar and correct quoting

Suggested change
* `authentication_mode` - (Optional) Authentication mode. Default to "Msi".
* `authentication_mode` - (Optional) Authentication mode. Defaults to `Msi`.

internal/services/streamanalytics/stream_analytics_output_powerbi_resource_test.go Outdated
Comment on lines 95 to 96
stream_analytics_job_name = azurerm_stream_analytics_job.test.name
resource_group_name = azurerm_stream_analytics_job.test.resource_group_name
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

could these be combined

Suggested change
stream_analytics_job_name = azurerm_stream_analytics_job.test.name
resource_group_name = azurerm_stream_analytics_job.test.resource_group_name
stream_analytics_job_id = azurerm_stream_analytics_job.test.id

@jiaweitao001 jiaweitao001 requested a review from katbyte May 9, 2022 02:24
katbyte
katbyte requested changes May 9, 2022
View reviewed changes
website/docs/r/stream_analytics_output_powerbi.html.markdown Outdated
Comment on lines 43 to 45
* `resource_group_name` - (Required) The name of the Resource Group where the Stream Analytics Job exists. Changing this forces a new resource to be created.

* `stream_analytics_job_name` - (Required) The name of the Stream Analytics Job. Changing this forces a new resource to be created.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this needs to be updated to reflect schema?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for reminding. Will update.

@jiaweitao001 jiaweitao001 requested a review from katbyte May 10, 2022 09:59
@katbyte katbyte changed the title Adding powerBI as a stream analytic job output New Resource azurerm_stream_analytics_output_powerbi May 12, 2022
katbyte
katbyte approved these changes May 12, 2022
View reviewed changes
Copy link
Collaborator

@katbyte katbyte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @jiaweitao001 ! LGTM now 🔥

@katbyte katbyte merged commit 96f7fab into hashicorp:main May 12, 2022
@github-actions github-actions bot added this to the v3.6.0 milestone May 12, 2022
katbyte added a commit that referenced this pull request May 12, 2022
@katbyte
CHANGELOG #16439
401ad72
@github-actions
Copy link

This functionality has been released in v3.6.0 of the Terraform Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active contributions.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 17, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@katbyte katbyte katbyte approved these changes

Assignees
No one assigned
Labels
documentation service/stream-analytics size/XL
Projects
None yet
Milestone
v3.6.0
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@jiaweitao001 @katbyte