New Resource - azurerm_route_server_bgp_connection, azurerm_route_server

[xiaxyi]

Adding new resource Azure Route Server

acc tests:

--- PASS: TestAccRouteServer_requiresImport (1455.63s)
--- PASS: TestAccRouteServer_basic (1527.78s)
--- PASS: TestAccRouteServer_complete (1648.24s)
--- PASS: TestAccRouteServerBgpConnection_basic (1659.84s)
--- PASS: TestAccRouteServerBgpConnection_requiresImport (1730.02s)
--- PASS: TestAccRouteServer_update (1779.95s)
PASS
ok  	github.com/hashicorp/terraform-provider-azurerm/internal/services/network	1780.465s

[tombuildsstuff]

hi @xiaxyi

The Provider already supports Route Server (as azurerm_virtual_hub, which is what this is called in the API / before the marketing rebrand). Whilst this has been rebranded in Azure it's only the marketing name and not the resource name (within the API) which has changed - so I'm not sure we should be renaming this resource?

Thanks!

[xiaxyi]

Thanks @tombuildsstuff for the comment. It's two separate resources, they are using the same API. Virtual Hub is created when specifying the virtual_wan while route server is an independent resource.

just for your reference, PowerShell's practice:

virtual hub:https://docs.microsoft.com/en-us/powershell/module/az.network/new-azvirtualhub?view=azps-7.5.0
route server:https://docs.microsoft.com/en-us/azure/route-server/quickstart-configure-route-server-powershell

[katbyte]

compile failure:

[xiaxyi]

@katbyte Thanks for the comment, I updated the sdk and tests are passing now.

[katbyte]

LGTM 🦕

[github-actions]

This functionality has been released in v3.15.0 of the Terraform Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

[github-actions]

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active contributions.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.