Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

azurerm_virtual_network_gateway_connection Add new feature to set custom_bgp_addresses #16631

Merged
merged 9 commits into from
May 13, 2022

Conversation

HappyTobi
Copy link
Contributor

Hi all,

I just added the new Azure feature to set a "custom_bgp_address" to the virtual network gateway connection.

The configuration looks like:

resource "azurerm_virtual_network_gateway_connection" "TestTunnelInstance" {
  name                = "TestTunnelInstance"
  resource_group_name = azurerm_resource_group.TestRG1.name
  location            = azurerm_resource_group.TestRG1.location

  type                       = "IPsec"
  virtual_network_gateway_id = azurerm_virtual_network_gateway.VNet1GW.id
  local_network_gateway_id   = azurerm_local_network_gateway.TestGateway.id
  shared_key                 = "SECRET"

  enable_bgp = true

  custom_bgp_addresses {
    primary_address   = "169.254.22.2"
    secondary_address = "169.254.22.6"
  }
}

Azure Documentation about that topic:
https://docs.microsoft.com/en-us/azure/vpn-gateway/vpn-gateway-howto-aws-bgp?msclkid=11de8e64c6f411eca4c7b7511dbc44d7

I also had to update the hole Networking api vom 2021-05-01 to 2021-08-01

The test runs fine when I locally updated the vendor dependencies.

I don't know if I should check in the updated dependencies, if that is required please let me know.

Regards,
Tobi

@HappyTobi
Copy link
Contributor Author

Hi @katbyte,
is it possible that someone of you can review the pr?

Regards
Tobi

Copy link
Collaborator

@katbyte katbyte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR @HappyTobi - aside from 1 comment on schema names this LGTM! once thats fixed up this should be good to merge

@HappyTobi HappyTobi requested a review from katbyte May 10, 2022 08:11
Copy link
Collaborator

@katbyte katbyte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @HappyTobi - LGTM 🍰

@katbyte katbyte merged commit c83af6d into hashicorp:main May 13, 2022
@github-actions github-actions bot added this to the v3.6.0 milestone May 13, 2022
katbyte added a commit that referenced this pull request May 13, 2022
katbyte added a commit that referenced this pull request May 13, 2022
@HappyTobi HappyTobi deleted the gateway-connection branch May 13, 2022 10:23
@github-actions
Copy link

This functionality has been released in v3.6.0 of the Terraform Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@katbyte
Copy link
Collaborator

katbyte commented May 17, 2022

network API upgrade had a breaking change for application gateway: #16793

@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active contributions.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 17, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants