azurerm_container_registry - support update replications on demand

[magodo]

This PR adds more finer grained control on how to update the replications for azurerm_container_registry.

Previously, any change in the georeplications will cause all replications to be recreated. This causes unexpected downtime for replications that are not affected (see #16634). This PR fixes it in way that:

• Only delete replications that are deleted from the config
• Only create replications that are newly added into the config
• Only Update replications that are updated in the config
• Otherwise, do nothing to the replication

Specially for update replications, API currently doesn't support updating the zoneRedundancy in place, which makes us have to delete then create it. Also, API has a bug when create a just deleted replication, see: Azure/azure-rest-api-specs#18934. Therefore, I have added a explicit wait in this PR to avoid that.

Additionally, during the test I noticed the LIST api of the replication will return the replications in arbitrary order. I have sorted it for the georeplications alphabetically during flattening. So that make the plan diff more readable for users (assuming users order their config alphabetically as well). Ideally, it should use Set instead, but it can't.

Fixes #16634.

Test

💢  TF_ACC=1 go test -v -timeout=20h ./internal/services/containers -run='TestAccContainerRegistry_geoReplication|TestAccContainerRegistry_geoReplicationLocation'
=== RUN   TestAccContainerRegistry_geoReplicationLocation
=== PAUSE TestAccContainerRegistry_geoReplicationLocation
=== RUN   TestAccContainerRegistry_geoReplication
=== PAUSE TestAccContainerRegistry_geoReplication
=== RUN   TestAccContainerRegistry_geoReplicationZoneRedundancy
=== PAUSE TestAccContainerRegistry_geoReplicationZoneRedundancy
=== RUN   TestAccContainerRegistry_geoReplicationRegionEndpoint
=== PAUSE TestAccContainerRegistry_geoReplicationRegionEndpoint
=== CONT  TestAccContainerRegistry_geoReplicationLocation
=== CONT  TestAccContainerRegistry_geoReplicationZoneRedundancy
=== CONT  TestAccContainerRegistry_geoReplicationRegionEndpoint
=== CONT  TestAccContainerRegistry_geoReplication
--- PASS: TestAccContainerRegistry_geoReplicationRegionEndpoint (259.38s)
--- PASS: TestAccContainerRegistry_geoReplicationZoneRedundancy (350.45s)
--- PASS: TestAccContainerRegistry_geoReplicationLocation (1235.67s)
--- PASS: TestAccContainerRegistry_geoReplication (1965.56s)
PASS
ok      github.com/hashicorp/terraform-provider-azurerm/internal/services/containers    1965.580s

Additionally, I've locally inspected the API sequence and confirmed it worked as expected.

[katbyte]

Thanks @magodo - LGTM 🐍

[katbyte]

@magodo - could we fix up the merge conflics to get this merged? thanks

[magodo]

@katbyte Sure, I've resolved it. Thank you for the review!

[github-actions]

This functionality has been released in v3.7.0 of the Terraform Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

[github-actions]

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active contributions.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.